From: "Luck, Tony" <tony.luck@intel.com>
To: Shuai Xue <xueshuai@linux.alibaba.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"james.morse@arm.com" <james.morse@arm.com>,
"lenb@kernel.org" <lenb@kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"zhangliguang@linux.alibaba.com" <zhangliguang@linux.alibaba.com>,
"zhuo.song@linux.alibaba.com" <zhuo.song@linux.alibaba.com>
Subject: RE: [PATCH v2] ACPI, APEI, EINJ: Relax platform response timeout to 1 second.
Date: Mon, 25 Oct 2021 15:59:08 +0000 [thread overview]
Message-ID: <bb5582286b13495b9d91e3f13b61cbd9@intel.com> (raw)
In-Reply-To: <f976af5e-6821-9ce1-0575-b4e2d7fd4479@linux.alibaba.com>
>> No, I don't. EINJ provides a hardware error injection mechanism to develop
>> and debug firmware code and hardware RAS feature. While we test on Arm
>> platform, it cannot meet the original timeout limit. Therefore, we send
>> this patch to relax the upper bound of timeout. In order to facilitate
>> other platforms to encounter the same problems, we expose timeout as a
>> configurable parameter in user space.
>
> What's your opinion about this interface?
I can't see a case where anyone would use it. So it is just useless fluff.
I say drop it from the next rev of the patch.
-Tony
next prev parent reply other threads:[~2021-10-25 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 3:38 [PATCH] ACPI, APEI, EINJ: Relax platform response timeout to 1 second Shuai Xue
2021-10-15 15:37 ` Luck, Tony
2021-10-17 4:06 ` Shuai Xue
2021-10-18 15:40 ` Luck, Tony
2021-10-19 13:33 ` Shuai Xue
2021-10-22 13:44 ` [PATCH v2] " Shuai Xue
2021-10-22 23:54 ` Luck, Tony
2021-10-24 9:10 ` Shuai Xue
2021-10-25 12:49 ` Shuai Xue
2021-10-25 15:59 ` Luck, Tony [this message]
2021-10-26 7:28 ` [PATCH v3] " Shuai Xue
2021-10-26 17:05 ` Luck, Tony
2021-10-27 2:18 ` Shuai Xue
2021-10-27 18:24 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb5582286b13495b9d91e3f13b61cbd9@intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=xueshuai@linux.alibaba.com \
--cc=zhangliguang@linux.alibaba.com \
--cc=zhuo.song@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.