From: Jacob Keller <jacob.e.keller@intel.com>
To: Leon Romanovsky <leon@kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, <netdev@vger.kernel.org>,
<richardcochran@gmail.com>,
Gurucharan G <gurucharanx.g@intel.com>
Subject: Re: [PATCH net-next 08/14] ice: protect init and calibrating fields with spinlock
Date: Fri, 2 Dec 2022 15:07:16 -0800 [thread overview]
Message-ID: <bb5d4351-af35-e40f-5c2c-031c83dd82c4@intel.com> (raw)
In-Reply-To: <ba949af0-7de6-ab12-6501-46a5af06001f@intel.com>
On 12/2/2022 10:36 AM, Jacob Keller wrote:
> I am not sure what the best way to fix c) is. Perhaps an additional flag
> of some sort which indicates that the timestamp thread function is
> processing so that tear down can wait until after the interrupt function
> completes. Once init is cleared, the function will stop re-executing,
> but we need a way to wait until it has stopped. That method in tear down
> can't hold the lock or else we'd potentially deadlock... Maybe an
> additional "processing" flag which is set under lock only if the init
> flag is set? and then cleared when the function exits. Then the tear
> down can check and wait for the processing to be complete? Hmm.
>
For what its worth, I think this is an issue regardless of whether this
series is applied, since the change from kthread to threaded IRQ was
done a while ago.
next prev parent reply other threads:[~2022-12-02 23:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 19:43 [PATCH net-next 00/14][pull request] Intel Wired LAN Driver Updates 2022-11-30 (ice) Tony Nguyen
2022-11-30 19:43 ` [PATCH net-next 01/14] ice: Use more generic names for ice_ptp_tx fields Tony Nguyen
2022-11-30 19:43 ` [PATCH net-next 02/14] ice: Remove the E822 vernier "bypass" logic Tony Nguyen
2022-11-30 19:43 ` [PATCH net-next 03/14] ice: Reset TS memory for all quads Tony Nguyen
2022-11-30 19:43 ` [PATCH net-next 04/14] ice: fix misuse of "link err" with "link status" Tony Nguyen
2022-11-30 19:43 ` [PATCH net-next 05/14] ice: always call ice_ptp_link_change and make it void Tony Nguyen
2022-11-30 19:43 ` [PATCH net-next 06/14] ice: handle discarding old Tx requests in ice_ptp_tx_tstamp Tony Nguyen
2022-12-01 14:58 ` Paolo Abeni
2022-12-01 15:04 ` Paolo Abeni
2022-12-02 17:59 ` Jacob Keller
2022-11-30 19:43 ` [PATCH net-next 07/14] ice: check Tx timestamp memory register for ready timestamps Tony Nguyen
2022-11-30 19:43 ` [PATCH net-next 08/14] ice: protect init and calibrating fields with spinlock Tony Nguyen
2022-12-01 9:18 ` Leon Romanovsky
2022-12-02 18:36 ` Jacob Keller
2022-12-02 23:07 ` Jacob Keller [this message]
2022-12-04 13:30 ` Leon Romanovsky
2022-12-05 19:57 ` Jacob Keller
2022-11-30 19:43 ` [PATCH net-next 09/14] ice: disable Tx timestamps while link is down Tony Nguyen
2022-11-30 19:43 ` [PATCH net-next 10/14] ice: cleanup allocations in ice_ptp_alloc_tx_tracker Tony Nguyen
2022-11-30 19:43 ` [PATCH net-next 11/14] ice: handle flushing stale Tx timestamps in ice_ptp_tx_tstamp Tony Nguyen
2022-11-30 19:43 ` [PATCH net-next 12/14] ice: only check set bits in ice_ptp_flush_tx_tracker Tony Nguyen
2022-11-30 19:43 ` [PATCH net-next 13/14] ice: make Tx and Rx vernier offset calibration independent Tony Nguyen
2022-11-30 19:43 ` [PATCH net-next 14/14] ice: reschedule ice_ptp_wait_for_offset_valid during reset Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb5d4351-af35-e40f-5c2c-031c83dd82c4@intel.com \
--to=jacob.e.keller@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gurucharanx.g@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.