All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Łukasz Majewski" <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN variable with env
Date: Tue, 5 Sep 2017 12:27:37 +0200	[thread overview]
Message-ID: <bb5dc507-e27c-744b-5c97-e99d5857009d@denx.de> (raw)
In-Reply-To: <CAKaJLVumB5D+2AhECwUBPU5Oi36VKrxXm1TY5yg81xGakuvZcA@mail.gmail.com>

Hi Sam,

> On 4 September 2017 at 08:36, Heiko Schocher <hs@denx.de> wrote:
>> Hello Lukasz,
>>
>> Am 02.09.2017 um 13:08 schrieb Łukasz Majewski:
>>>
>>> Hi Heiko,
>>>
>>> Would you find some time and run this patch through your test setup?
>>>
>>> Thanks in advance.
>>
>>
>> Of course, as it is automated ;-)
>>
>> Okay, I had to add an oneliner, to say tbot, which patchwork patch it
>> has to download... for the records see [1].
>>
>> Here the results for the smartweb board (in short, my dfu test are
>> working with this patch):
>>
>> http://xeidos.ddns.net/tests/test_db_auslesen.php#408
>>
>> Logs:
>> http://xeidos.ddns.net/tbot/id_408/html_log.html
>>
>> Especially the steps:
>>
>> (download patchwork patch, check with checkpatch, apply to mainline):
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#92
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#95
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#98
>>
>> and the dfu test:
>>
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#398
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#409
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#413
>> http://xeidos.ddns.net/tbot/id_408/html_log.html#417
>>
>> My browser (firefox) seems to have problems with jumping to the correct
>> "id"s in the html file ...
>>
>> Hope you can find the logs, if not, look into the raw logfile:
>>
>> http://xeidos.ddns.net/tbot/id_408/tbot.txt
>>
>> but this is not very comfortable ...
>>
>> So, please add my:
>>
>> Tested-by: Heiko Schocher <hs@denx.de>
>>
> 
> Hi Lukasz,
> 
> Now that testing is done (thanks Heiko!), can you please Ack or Review
> this patch? I really want it to go in v2017.09 release, as it's
> critical bug fix for us.

No problem from my side:

Acked-by: Łukasz Majewski <lukma@denx.de>


If Marek don't mind - I would like to ask Tom to apply it directly to 
-master branch (because of the patch importance).


> 
> Thanks!
> 
>> bye,
>> Heiko
>>
>> [1] tbot patch for adding a patchworkpatch
>>
>> root at raspberrypi:/home/pi/data/tbot# git diff
>> diff --git a/config/smartweb.py b/config/smartweb.py
>> index 72a7972..98c8e0f 100644
>> --- a/config/smartweb.py
>> +++ b/config/smartweb.py
>> @@ -37,6 +37,8 @@ tc_workfd_apply_patchwork_patches_list_hand = [
>> ]
>> tc_workfd_apply_patchwork_patches_blacklist = ['204183', '561384']
>>
>> +tc_workfd_apply_patchwork_patches_list = ['808671']
>> +
>> uboot_get_parameter_file_list = ['.config', 'include/configs/smartweb.h',
>> 'arch/arm/mach-at91/include/mach/at91sam9260.h']
>>
>> tc_workfd_set_toolchain_arch = 'arm'
>> root at raspberrypi:/home/pi/data/tbot#
>>
>>
>> --
>> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> 


-- 
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

  reply	other threads:[~2017-09-05 10:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-01 12:42 [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN variable with env Sam Protsenko
2017-09-02 11:08 ` Łukasz Majewski
2017-09-04  5:36   ` Heiko Schocher
2017-09-05 10:23     ` Sam Protsenko
2017-09-05 10:27       ` Łukasz Majewski [this message]
2017-09-05 13:23 ` Marek Vasut
2017-09-06  0:35 ` [U-Boot] [U-Boot, v3, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb5dc507-e27c-744b-5c97-e99d5857009d@denx.de \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.