From: Jens Axboe <axboe@kernel.dk>
To: Hongnan Li <hongnan.li@linux.alibaba.com>, linux-block@vger.kernel.org
Subject: Re: [PATCH v2] blk-iolatency: postpone ktime_get() execution until blk_iolatency_enabled() return true
Date: Wed, 1 Jul 2020 08:05:41 -0600 [thread overview]
Message-ID: <bb6e02cb-052c-e94c-e38e-b6d02b55da48@kernel.dk> (raw)
In-Reply-To: <1593590978-23382-1-git-send-email-hongnan.li@linux.alibaba.com>
On 7/1/20 2:09 AM, Hongnan Li wrote:
> ktime_to_ns(ktime_get()) which is expensive do not need to be executed if
> blk_iolatency_enabled() return false in blkcg_iolatency_done_bio().
> Postponing ktime_to_ns(ktime_get()) execution can reduce CPU usage
> when blk_iolatency was disabled.
>
> ---
> V2:
> 1.Fix compile warnings.
>
> Signed-off-by: Hongnan Li <hongnan.li@linux.alibaba.com>
I've applied this (rewrote header+commit message somewhat). But a note for the
future - anything below the first --- is removed, so you'll need to put your
SOB right below the commit message. And the v2 etc info should go here:
> ---
> block/blk-iolatency.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
instead of having two --- sections.
--
Jens Axboe
prev parent reply other threads:[~2020-07-01 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 8:09 [PATCH v2] blk-iolatency: postpone ktime_get() execution until blk_iolatency_enabled() return true Hongnan Li
2020-07-01 14:05 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb6e02cb-052c-e94c-e38e-b6d02b55da48@kernel.dk \
--to=axboe@kernel.dk \
--cc=hongnan.li@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.