From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1840DC36008 for ; Wed, 26 Mar 2025 14:32:17 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.927914.1330668 (Exim 4.92) (envelope-from ) id 1txRnc-0007mO-4L; Wed, 26 Mar 2025 14:32:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 927914.1330668; Wed, 26 Mar 2025 14:32:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1txRnc-0007mH-0U; Wed, 26 Mar 2025 14:32:08 +0000 Received: by outflank-mailman (input) for mailman id 927914; Wed, 26 Mar 2025 14:32:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1txRnb-00075K-Ee for xen-devel@lists.xenproject.org; Wed, 26 Mar 2025 14:32:07 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 174a9325-0a4f-11f0-9ffa-bf95429c2676; Wed, 26 Mar 2025 15:32:05 +0100 (CET) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4394345e4d5so45726995e9.0 for ; Wed, 26 Mar 2025 07:32:05 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d830f5b41sm3741605e9.27.2025.03.26.07.32.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Mar 2025 07:32:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 174a9325-0a4f-11f0-9ffa-bf95429c2676 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1742999525; x=1743604325; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Rs47t0LiX9/ghEzUBn5tRSEWz2mfQnNRpiMULrtdb7g=; b=IKD4LSWdsVbWadTb9O6wCSeoIoixXrEDYxi9lJV2aOhdQrDUPgPS3n5+PCg1sN0Cks N99ZTViYAkvpr4aS8ZVFxJbemIMfifkZ/tiNzV9213mMCuTt0qa+QQNbkwz/1aNJLxu1 mOY9KRG1rXHXdxCzb2mmQQnJhnDIZtKsb032FhRynXun+8tFfz6w/TU+D4CWK1BQeLtM SYvtQBYEgovpPhsB5vYXfTJ2ldtTlOaI0SmEpTayAlYC4Hi3WeLc6KQpZp6Bpv4e/fvB 80BpfyJHdR6obXjyyxhRw6DbPJXqqJGGh6oFg85zJA79jsit8gcAjfSwO6+Zs+93tIbj vvAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742999525; x=1743604325; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Rs47t0LiX9/ghEzUBn5tRSEWz2mfQnNRpiMULrtdb7g=; b=XqFSY+lwsdcZX3184nBhP2Sq4hiFCrUGb3fnwrmbnOIF9jwBpnMTemx1+6TuP1qu5j 1V5FPYCmhXY8AnoffKCT7aCeB9HinTiOkfnEBNJPLFlAZyhc+tJaI5gNY7RtOoDBsBDf G5TYZb7IpG2hHQr4yLKidKqIQH/QmUTevaI3BsKpxtUBREDvJDx5gkq1r3EmDKPGoHIM R8dQS8LxZU6CMWWvUFfmScPtBBHyw2wnUHp5EAU/vBRBoAHXH7A3V6c3BAN9BA9MEzub VF5couKdX31H28+TMaP3wyKfndTGqIJTd+HG91oFT46YChJwSGvyAUfRo07kd32q/MD0 zUBQ== X-Forwarded-Encrypted: i=1; AJvYcCUKZUpF5YqlgQV69gdF+eBvz76A+KV7/jon/cLhZ3PHx6tCz4BX/lDdOWfHWsFAy6WO4wa8ZpR4dgc=@lists.xenproject.org X-Gm-Message-State: AOJu0Yy272HyM/96ld8aIaY2Yj+JYDQMk1FlHy2xkmIkkibi5HGvamQp QsG6QdcxJzs2ec3QyFqSyl5LLRcqeRnLw1f9PwZ+Z8fm++gWtRtsoAysJsbzg1oBmZHPwbSPWY0 = X-Gm-Gg: ASbGnctW+xwzBHNPAVF9t90ccHanoUiRb01sfmP50rPdd8v8pd1DJEu+4CRAa/NDnLR 6zBlWSOAqPZmAFcOAyU9ZAOws/6Cm5HHMzxDYkok+oNlWksMOhID46lJRJZya+PiLLzG75NajPn FgORbp/kuoLN/YMhXZ16zblZ2u7ywWx76h5s2rAk1X0j9sRN1nGQFTdlOQCJHkQdZlMMF9Taab9 bpNA/szArmRPDPdKy9Wt7lrm6vgUcduJFPdancafiZNRyDe6fcPZcQkRIGYw64JlicqoxYbS0pb clKTY3b7gW0/V8MDfCeesPTJOn5FhFx6hRYdqRw3Ao2heRJvgMBNc3YKJcfjCHSKfOmi6Ksw1Hb I2lu4LPN+QAqgonLuUWXeklm3AlSgFKSTwxmgM7OA X-Google-Smtp-Source: AGHT+IEisIeR9Ln3piPvJSU4cOdXJrpDihq0BunTw/bGFzMLmier0IdaLbLeB2RAxKHSNM3kWdtPEQ== X-Received: by 2002:a05:600c:468a:b0:43c:fe15:41d4 with SMTP id 5b1f17b1804b1-43d509f4d2fmr228900635e9.18.1742999525276; Wed, 26 Mar 2025 07:32:05 -0700 (PDT) Message-ID: Date: Wed, 26 Mar 2025 15:32:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 7/8] xen/console: introduce console_set_focus() To: dmkhn@proton.me Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org, dmukhin@ford.com, xen-devel@lists.xenproject.org References: <20250318233617.849903-1-dmukhin@ford.com> <20250318233617.849903-8-dmukhin@ford.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20250318233617.849903-8-dmukhin@ford.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19.03.2025 00:37, dmkhn@proton.me wrote: > +/* > + * Switch console focus. > + * Rotates input focus among Xen, dom0 and boot-time created domUs while > + * skipping switching serial input to non existing domains. > + */ > +static void console_switch_focus(void) > +{ > + const domid_t n = domid_top + 1; The use of this renamed identifier is now in sharp conflict with the comment, talking about boot-time created domains only. > + domid_t i = ( console_focus == DOMID_XEN ) > + ? get_initial_domain_id() : console_focus + 1; > + > + for ( ; i < n; i++ ) > + if ( !console_set_focus(i) ) This being the sole call caring about the function's return value, why isn't the function returning a mere boolean? Jan