From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 3/5] drm/i915/execlists: Direct submit onto idle engines Date: Fri, 11 May 2018 09:25:00 +0100 Message-ID: References: <20180509142801.28130-1-chris@chris-wilson.co.uk> <20180509142801.28130-3-chris@chris-wilson.co.uk> <52b631ff-5760-dc18-bc9f-e385fe8f10b9@linux.intel.com> <152596950582.19716.12455454575905000362@mail.alporthouse.com> <68b5b65f-e504-9cc5-a8a5-6d106cade0f5@linux.intel.com> <152597404503.19716.572953919894671400@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 91C806F086 for ; Fri, 11 May 2018 08:25:03 +0000 (UTC) In-Reply-To: <152597404503.19716.572953919894671400@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEwLzA1LzIwMTggMTg6NDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA1LTEwIDE4OjI2OjMxKQo+Pgo+PiBPbiAxMC8wNS8yMDE4IDE3OjI1 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE4LTA1 LTEwIDE3OjA5OjE0KQo+Pj4+Cj4+Pj4gT24gMDkvMDUvMjAxOCAxNToyNywgQ2hyaXMgV2lsc29u IHdyb3RlOgo+Pj4+PiBCeXBhc3MgdXNpbmcgdGhlIHRhc2tsZXQgdG8gc3VibWl0IHRoZSBmaXJz dCByZXF1ZXN0IHRvIEhXLCBhcyB0aGUKPj4+Pj4gdGFza2xldCBtYXkgYmUgZGVmZXJyZWQgdW50 byBrc29mdGlycWQgYW5kIGF0IGEgbWluaW11bSB3aWxsIGFkZCBpbgo+Pj4+PiBleGNlc3Mgb2Yg MTB1cyAoYW5kIG1heWJlIHRlbnMgb2YgbWlsbGlzZWNvbmRzKSB0byBvdXIgZXhlY3V0aW9uCj4+ Pj4+IGxhdGVuY3kuIFRoaXMgbGF0ZW5jeSByZWR1Y3Rpb24gaXMgbW9zdCBub3RhYmxlIHdoZW4g ZXhlY3V0aW9uIGZsb3dzCj4+Pj4+IGJldHdlZW4gZW5naW5lcy4KPj4+Pj4KPj4+Pj4gdjI6IEJl d2FyZSBoYW5kbGluZyBwcmVlbXB0aW9uIGNvbXBsZXRpb24gZnJvbSB0aGUgZGlyZWN0IHN1Ym1p dCBwYXRoIGFzCj4+Pj4+IHdlbGwuCj4+Pj4+IHYzOiBNYWtlIHRoZSBhYnVzZSBjbGVhciBhbmQg dHJhY2sgb3VyIGV4dHJhIHN0YXRlIGluc2lkZSBpOTE1X3Rhc2tsZXQuCj4+Pj4+Cj4+Pj4+IFN1 Z2dlc3RlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4+ Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+ Cj4+Pj4+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pj4+ PiAtLS0KPj4+Pj4gICAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdGFza2xldC5oICAgICAg ICAgfCAyNCArKysrKysrCj4+Pj4+ICAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNf c3VibWlzc2lvbi5jIHwgMTAgKystCj4+Pj4+ICAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9scmMuYyAgICAgICAgICAgIHwgNzEgKysrKysrKysrKysrKysrKystLS0tCj4+Pj4+ICAgICAz IGZpbGVzIGNoYW5nZWQsIDg5IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+Pj4+Pgo+ Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV90YXNrbGV0LmggYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Rhc2tsZXQuaAo+Pj4+PiBpbmRleCA0MmIwMDJiODhl ZGIuLjk5ZTJmYTIyNDFiYSAxMDA2NDQKPj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV90YXNrbGV0LmgKPj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV90YXNr bGV0LmgKPj4+Pj4gQEAgLTgsOCArOCwxMSBAQAo+Pj4+PiAgICAgI2RlZmluZSBfSTkxNV9UQVNL TEVUX0hfCj4+Pj4+ICAgICAKPj4+Pj4gICAgICNpbmNsdWRlIDxsaW51eC9hdG9taWMuaD4KPj4+ Pj4gKyNpbmNsdWRlIDxsaW51eC9iaXRvcHMuaD4KPj4+Pj4gICAgICNpbmNsdWRlIDxsaW51eC9p bnRlcnJ1cHQuaD4KPj4+Pj4gICAgIAo+Pj4+PiArI2luY2x1ZGUgImk5MTVfZ2VtLmgiCj4+Pj4+ ICsKPj4+Pj4gICAgIC8qKgo+Pj4+PiAgICAgICogc3RydWN0IGk5MTVfdGFza2xldCAtIHdyYXBw ZXIgYXJvdW5kIHRhc2tsZXRfc3RydWN0Cj4+Pj4+ICAgICAgKgo+Pj4+PiBAQCAtMTksNiArMjIs OCBAQAo+Pj4+PiAgICAgICovCj4+Pj4+ICAgICBzdHJ1Y3QgaTkxNV90YXNrbGV0IHsKPj4+Pj4g ICAgICAgICBzdHJ1Y3QgdGFza2xldF9zdHJ1Y3QgYmFzZTsKPj4+Pj4gKyAgICAgdW5zaWduZWQg bG9uZyBmbGFnczsKPj4+Pj4gKyNkZWZpbmUgSTkxNV9UQVNLTEVUX0RJUkVDVF9TVUJNSVQgQklU KDApCj4+Pj4KPj4+PiBJIHdvdWxkIHN1Z2dlc3QgYSBtb3JlIGdlbmVyaWMgbmFtZSBmb3IgdGhl IGJpdCBzaW5jZSBpOTE1X3Rhc2tsZXQgaXMKPj4+PiBnZW5lcmljLWlzaC4gRm9yIGluc3RhbmNl IHNpbXBseSBJOTE1X1RBU0tMRVRfRElSRUNUIHdvdWxkIHNpZ25pZnkgdGhlCj4+Pj4gY2FsbGJh Y2sgaGFzIGJlZW4gaW52b2tlZCBkaXJlY3RseSBhbmQgbm90IChuZWNlc3NhcmlseSkgZnJvbSBz b2Z0aXJxCj4+Pj4gY29udGV4dC4gVGhlbiBpdCBpcyBmb3IgZWFjaCB1c2VyIHRvIGtub3cgd2hh dCB0aGF0IG1lYW5zIGZvciB0aGVtCj4+Pj4gc3BlY2lmaWNhbGx5Lgo+Pj4KPj4+IFByb2JsZW0g aXMgd2UgaGF2ZSB0d28gZGlyZWN0IGludm9jYXRpb25zLCBvbmx5IG9uZSBpcyBzcGVjaWFsLiBJ dAo+Pj4gcmVhbGx5IHdhbnRzIHRvIGJlIHNvbWV0aGluZyBsaWtlIEk5MTVfVEFTS0xFVF9FTkdJ TkVfSVNfTE9DS0VEIC0geW91IGNhbgo+Pj4gc2VlIHdoeSBJIGRpZG4ndCBwcm9wb3NlIHRoYXQu Cj4+Cj4+IFRCQy4uLgo+Pgo+Pj4+PiAtc3RhdGljIHZvaWQgX19zdWJtaXRfcXVldWUoc3RydWN0 IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLCBpbnQgcHJpbykKPj4+Pj4gK3N0YXRpYyB2b2lkIF9f d2FrZXVwX3F1ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgaW50IHByaW8pCj4+ Pj4+ICAgICB7Cj4+Pj4+ICAgICAgICAgZW5naW5lLT5leGVjbGlzdHMucXVldWVfcHJpb3JpdHkg PSBwcmlvOwo+Pj4+PiArfQo+Pj4+Cj4+Pj4gV2h5IGlzIHRoaXMgY2FsbGVkIHdha2V1cD8gUGxh bnMgdG8gYWRkIHNvbWV0aGluZyBpbiBpdCBsYXRlcj8KPj4+Cj4+PiBZZXMuIEl0J3MgY2FsbGVk IHdha2V1cCBiZWNhdXNlIGl0J3Mgc2V0dGluZyB0aGUgdmFsdWUgdGhhdCB0aGUgZGVxdWV1ZQo+ Pj4gd2FrZXMgdXAgYXQuIEZpcnN0IG5hbWUgd2FzIGtpY2tfcXVldWUsIGJ1dCBpdCBkb2Vzbid0 IGtpY2sgZWl0aGVyLgo+Pj4KPj4+IFRoZSBsYXRlciBzaWRlLWVmZmVjdCBpbnZvbHZlcyBjb250 cm9sbGluZyB0aW1lcnMuCj4+Pgo+Pj4gX19yZXN0YXJ0X3F1ZXVlKCk/Cj4+Cj4+IF9fdXBkYXRl X3F1ZXVlX3ByaW9yaXR5PyA6KQo+IAo+IEl0IGRvZXNuJ3QganVzdCB1cGRhdGUgdGhlIHByaW9y aXR5Li4uCj4gCj4gTm93IGEgY2hvaWNlIGJldHdlZW4gcmVzdGFydF9xdWV1ZSBhbmQgdXBkYXRl X3F1ZXVlLgoKVXBkYXRlIHNvdW5kcyBiZXR0ZXIgbWF0Y2ggdG8gbWUuCgo+IAo+Pj4+PiArc3Rh dGljIHZvaWQgX19zY2hlZHVsZV9xdWV1ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUp Cj4+Pj4+ICt7Cj4+Pj4+ICAgICAgICAgaTkxNV90YXNrbGV0X3NjaGVkdWxlKCZlbmdpbmUtPmV4 ZWNsaXN0cy50YXNrbGV0KTsKPj4+Pj4gICAgIH0KPj4+Pj4gICAgIAo+Pj4+PiArc3RhdGljIGJv b2wgX19kaXJlY3Rfc3VibWl0KHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICpjb25zdCBl eGVjbGlzdHMpCj4+Pj4+ICt7Cj4+Pj4+ICsgICAgIHN0cnVjdCBpOTE1X3Rhc2tsZXQgKiBjb25z dCB0ID0gJmV4ZWNsaXN0cy0+dGFza2xldDsKPj4+Pj4gKwo+Pj4+PiArICAgICBpZiAoIXRhc2ts ZXRfdHJ5bG9jaygmdC0+YmFzZSkpCj4+Pj4+ICsgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+ Pj4+PiArCj4+Pj4+ICsgICAgIHQtPmZsYWdzIHw9IEk5MTVfVEFTS0xFVF9ESVJFQ1RfU1VCTUlU Owo+Pj4+PiArICAgICBpOTE1X3Rhc2tsZXRfcnVuKHQpOwo+Pj4+PiArICAgICB0LT5mbGFncyAm PSB+STkxNV9UQVNLTEVUX0RJUkVDVF9TVUJNSVQ7Cj4+Pj4+ICsKPj4+Pj4gKyAgICAgdGFza2xl dF91bmxvY2soJnQtPmJhc2UpOwo+Pj4+Cj4+Pj4gRmVlbHMgbGlrZSB0aGlzIHdob2xlIHNlcXVl bmNlIGJlbG9uZ3MgdG8gaTkxNV90YXNrbGV0IHNpbmNlIGl0IHRvdWNoZXMKPj4+PiB0aGUgaW50 ZXJuYWxzLiBNYXliZSBpOTE1X3Rhc2tsZXRfdHJ5X3J1biwgb3IgaTkxNV90YXNrbGV0X3J1bl9v cl9zY2hlZHVsZT8KPj4+Cj4+PiBLZWVwIHJlYWRpbmcgdGhlIHNlcmllcyBhbmQgeW91J2xsIHNl ZSBqdXN0IHdoeSB0aGlzIGlzIHNvIHNwZWNpYWwgYW5kCj4+PiBjb25maW5lZCB0byBleGVjbGlz dHMuCj4+Cj4+IC4uLiBUQkMgaGVyZS4KPj4KPj4gSGF2aW5nIHBlZWtlZCBhaGVhZCwgaXQgZmVl bHMgYSBiaXQgbm90IGdlbmVyaWMgZW5vdWdoIGFzIGl0IGlzLCBhIGJpdAo+PiB0b28gaGFja3ku Cj4+Cj4+IFdvdWxkIGl0IHdvcmsgdG8gcGFzcyBjb250ZXh0IHRvZ2V0aGVyIHdpdGggdGhlIGlu dm9jYXRpb24uIExpa2U6Cj4+Cj4+IGk5MTVfdGFza2xldF90cnkoLi4uLCBJOTE1X1RBU0tMRVRf U1VCTUlUX0lETEUpOwo+PiBpOTE1X3Rhc2tsZXRfdHJ5KC4uLiwgSTkxNV9UQVNLTEVUX1NVQk1J VF9JUlEpOwo+Pgo+PiBpOTE1X3Rhc2tsZXQuZmxhZ3MgZmllbGQgbmFtZXNwYWNlIHdvdWxkIHRo ZW4gYmUgb3duZWQgYnkgdGhlIGNhbGxlcgo+PiBjb21wbGV0ZWx5LiBBbmQgdGhlIHRhc2tsZXQg ZnVuYyBpdHNlbGYgd291bGQgaGF2ZSBtb3JlIGNvbnRleHQgb24gd2hhdAo+PiB0byBkby4KPiAK PiBUaGF0IGRvZXNuJ3QgYXBwbHkgdmVyeSB3ZWxsIHRvIHRoZSB1c2UgY2FzZSBlaXRoZXIuIEl0 J3Mgbm90IHRoZQo+IHRhc2tsZXQgYmVpbmcgY2FsbGVkIGZyb20gaXJxL3Byb2Nlc3MgdGhhdCdz IHNpZ25pZmljYW50IGJ1dCB3aGV0aGVyIHdlCj4gYXJlIGNhbGxpbmcgaXQgd2l0aCB0aGUgZW5n aW5lL2RhdGEgbG9ja2VkLgoKVGhhdCdzIHdoeSBJIGFtIHByb3Bvc2luZyB0byBhbGxvdyBhIGdl bmVyaWMgbWVjaGFuaXNtIHRvIHBhc3MgaW4gYSAKInRva2VuIiB0byB0aGUgQVBJLCB3aGljaCBB UEkgd2lsbCBwYXNzIGRvd24gdG8gdGhlIHVzZXIgaWYgaW52b2tpbmcgdGhlIAp0YXNrbGV0IGRp cmVjdGx5LgoKVGhlIHVzZXIgdGhlbiBkZWNpZGVzIGhvdyB0byBpbnRlcnByZXQgdGhlIHRva2Vu LgoKSTkxNV9UQVNLTEVUX1NVQk1JVF9JRExFIHdvdWxkIG1lYW4gIkkga25vdyB0aGlzIGlzIHRo ZSBwYXRoIHdpdGggCnRpbWVsaW5lIGxvY2sgYWxyZWFkeSB0YWtlbiIuCgpJOTE1X1RBU0tMRVRf U1VCTUlUX0lSUSB0b2tlbiB3b3VsZCBtZWFuICJJIG5lZWQgdG8gdGFrZSB0aGUgbG9jayBhbmQg SSAKbmVlZCBhbiBlYXJseSBhYm9ydCBpZiB0YXNrbGV0IGlzIGRpc2FibGVkIi4KCj4gCj4gSSBr ZWVwIHdhbnRpbmcgdG8gdXNlIExPQ0tFRCwgYnV0IHRoYXQgaGFzIG5vIG1lYW5pbmcgdG8gdGhl IHRhc2tsZXQsCj4gYW5kIHRhc2tsZXRfdHJ5bG9jayBtZWFucyBzb21ldGhpbmcgZW50aXJlbHkg ZGlmZmVyZW50Lgo+ICAgCj4+IEZvbGxvd2luZyBmb3JtIHRoYXQsIGk5MTVfdGFza2xldF9ydW5f b3Jfc2NoZWR1bGUoLi4sIGZsYWdzKS4KPj4KPj4gYm9vbCBpOTE1X3Rhc2tsZV90cnkodGFza2xl dCwgZmxhZ3MpCj4+IHsKPj4gICAgICAgICAgaWYgKCF0cnlsb2NrKQo+PiAgICAgICAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKPj4KPj4gICAgICAgICAgdC0+ZmxhZ3MgfD0gZmxhZ3M7Cj4+ICAg ICAgICAgIGk5MTVfdGFza2xldF9ydW4oLi4uKTsKPj4gICAgICAgICAgdC0+ZmxhZ3MgJj0gfmZs YWdzOwo+Pgo+PiAgICAgICAgICB0YXNrbGV0X3VubG9jayguLi4pOwo+Pgo+PiAgICAgICAgICBy ZXR1cm4gdHJ1ZTsKPj4gfQo+Pgo+Pgo+PiB2b2lkIGk5MTVfdGFza2xldF9ydW5fb3Jfc2NoZWR1 bGUoLi4uLCBmbGFncykKPj4gewo+PiAgICAgICAgICBpZiAoIWk5MTVfdGFza2xldF90cnkoLi4u LCBmbGFncykpCj4+ICAgICAgICAgICAgICAgICAgaTkxNV90YXNrbGV0X3NjaGVkdWxlKC4uLik7 Cj4+IH0KPj4KPj4gPwo+Pgo+PiBMZWF2ZXMgYSBxdWVzdGlvbiBvZiBhIHRhc2tsZXRfaXNfZW5h YmxlZCBjaGVjayBpbiB5b3VyIHRhc2tsZXRfdHJ5LAo+PiB3aGljaCBJIGRvbid0IHF1aXRlIGdl dCBzaW5jZSB0aGF0IGNoZWNrIHdhc24ndCB0aGVyZSBiZWZvcmUuIFNvIHdoeSBpdAo+PiBpcyBu ZWVkZWQ/Cj4gCj4gQ29uY3VycmVudCByZXNldCBjYW4gaGFwcGVuIGF0IGlycSB0aW1lLCBidXQg d2Uga25vdyBjYW5ub3QgaGFwcGVuIGZyb20KPiB0aGUgc3VibWl0IHBhdGguCgpSaWdodCwgeWVz LCBpdCBpcyByZWxldmFudCBmb3IgZGlyZWN0IGludm9jYXRpb24gb25seS4KClJlZ2FyZHMsCgpU dnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==