diff for duplicates of <bb903722cf60d6efdfdc64598faf21e45f72e128.camel@mediatek.com> diff --git a/N1/2.bin b/N1/2.bin new file mode 100644 index 0000000..d47b719 --- /dev/null +++ b/N1/2.bin @@ -0,0 +1,75 @@ +<html><body><p> +<pre> +On Sun, 2025-01-12 at 14:47 +0100, Krzysztof Kozlowski wrote: +> External email : Please do not click links or open attachments until you have verified the sender or the content. +>  +>  +> Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over +> syscon_regmap_lookup_by_phandle() combined with getting the syscon +> argument.  Except simpler code this annotates within one line that given +> phandle has arguments, so grepping for code would be easier. +>  +> There is also no real benefit in printing errors on missing syscon +> argument, because this is done just too late: runtime check on +> static/build-time data.  Dtschema and Devicetree bindings offer the +> static/build-time check for this already. + +Reviewed-by: CK Hu <ck.hu@mediatek.com> + +I've not decided to apply this patch first or Angelo's patch first. +I'll fix conflict when I apply both patch. + +Regards, +CK + +>  +> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> +> --- +>  drivers/gpu/drm/mediatek/mtk_hdmi.c | 14 +++++--------- +>  1 file changed, 5 insertions(+), 9 deletions(-) +>  +> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c +> index ca82bc829cb9..4b0eb7dc25d8 100644 +> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c +> @@ -1458,15 +1458,11 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi, +>          * MMSYS_CONFIG device and the register offset of the HDMI_SYS_CFG +>          * registers it contains. +>          */ +> -       regmap = syscon_regmap_lookup_by_phandle(np, "mediatek,syscon-hdmi"); +> -       ret = of_property_read_u32_index(np, "mediatek,syscon-hdmi", 1, +> -                                        &hdmi->sys_offset); +> -       if (IS_ERR(regmap)) +> -               ret = PTR_ERR(regmap); +> -       if (ret) { +> -               dev_err(dev, +> -                       "Failed to get system configuration registers: %d\n", +> -                       ret); +> +       regmap = syscon_regmap_lookup_by_phandle_args(np, "mediatek,syscon-hdmi", +> +                                                     1, &hdmi->sys_offset); +> +       if (IS_ERR(regmap)) { +> +               ret = dev_err_probe(dev, PTR_ERR(regmap), +> +                                   "Failed to get system configuration registers\n"); +>                 goto put_device; +>         } +>         hdmi->sys_regmap = regmap; +> -- +> 2.43.0 +>  +>  + + +</pre> +</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ******************** +The information contained in this e-mail message (including any +attachments) may be confidential, proprietary, privileged, or otherwise +exempt from disclosure under applicable laws. It is intended to be +conveyed only to the designated recipient(s). Any use, dissemination, +distribution, printing, retaining or copying of this e-mail (including its +attachments) by unintended recipient(s) is strictly prohibited and may +be unlawful. If you are not an intended recipient of this e-mail, or believe +that you have received this e-mail in error, please notify the sender +immediately (by replying to this e-mail), delete any and all copies of +this e-mail (including any attachments) from your system, and do not +disclose the content of this e-mail to any other person. Thank you! +</pre><!--}--> diff --git a/N1/2.hdr b/N1/2.hdr new file mode 100644 index 0000000..da1f671 --- /dev/null +++ b/N1/2.hdr @@ -0,0 +1,3 @@ +Content-Type: text/html; + charset="utf-8" +Content-Transfer-Encoding: base64 diff --git a/a/content_digest b/N1/content_digest index b382be5..3be245b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -13,7 +13,7 @@ matthias.bgg@gmail.com <matthias.bgg@gmail.com> linux-mediatek@lists.infradead.org <linux-mediatek@lists.infradead.org> " linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>\0" - "\00:1\0" + "\01:1\0" "b\0" "On Sun, 2025-01-12 at 14:47 +0100, Krzysztof Kozlowski wrote:\n" "> External email : Please do not click links or open attachments until you have verified the sender or the content.\n" @@ -72,5 +72,82 @@ "> 2.43.0\n" "> \n" > + "\01:2\0" + "b\0" + "<html><body><p>\r\n" + "<pre>\r\n" + "On Sun, 2025-01-12 at 14:47 +0100, Krzysztof Kozlowski wrote:\r\n" + "> External email : Please do not click links or open attachments until you have verified the sender or the content.\r\n" + "> \r\n" + "> \r\n" + "> Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over\r\n" + "> syscon_regmap_lookup_by_phandle() combined with getting the syscon\r\n" + "> argument.  Except simpler code this annotates within one line that given\r\n" + "> phandle has arguments, so grepping for code would be easier.\r\n" + "> \r\n" + "> There is also no real benefit in printing errors on missing syscon\r\n" + "> argument, because this is done just too late: runtime check on\r\n" + "> static/build-time data.  Dtschema and Devicetree bindings offer the\r\n" + "> static/build-time check for this already.\r\n" + "\r\n" + "Reviewed-by: CK Hu <ck.hu@mediatek.com>\r\n" + "\r\n" + "I've not decided to apply this patch first or Angelo's patch first.\r\n" + "I'll fix conflict when I apply both patch.\r\n" + "\r\n" + "Regards,\r\n" + "CK\r\n" + "\r\n" + "> \r\n" + "> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>\r\n" + "> ---\r\n" + ">  drivers/gpu/drm/mediatek/mtk_hdmi.c | 14 +++++---------\r\n" + ">  1 file changed, 5 insertions(+), 9 deletions(-)\r\n" + "> \r\n" + "> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c\r\n" + "> index ca82bc829cb9..4b0eb7dc25d8 100644\r\n" + "> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c\r\n" + "> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c\r\n" + "> @@ -1458,15 +1458,11 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi,\r\n" + ">          * MMSYS_CONFIG device and the register offset of the HDMI_SYS_CFG\r\n" + ">          * registers it contains.\r\n" + ">          */\r\n" + "> -       regmap = syscon_regmap_lookup_by_phandle(np, "mediatek,syscon-hdmi");\r\n" + "> -       ret = of_property_read_u32_index(np, "mediatek,syscon-hdmi", 1,\r\n" + "> -                                        &hdmi->sys_offset);\r\n" + "> -       if (IS_ERR(regmap))\r\n" + "> -               ret = PTR_ERR(regmap);\r\n" + "> -       if (ret) {\r\n" + "> -               dev_err(dev,\r\n" + "> -                       "Failed to get system configuration registers: %d\n",\r\n" + "> -                       ret);\r\n" + "> +       regmap = syscon_regmap_lookup_by_phandle_args(np, "mediatek,syscon-hdmi",\r\n" + "> +                                                     1, &hdmi->sys_offset);\r\n" + "> +       if (IS_ERR(regmap)) {\r\n" + "> +               ret = dev_err_probe(dev, PTR_ERR(regmap),\r\n" + "> +                                   "Failed to get system configuration registers\n");\r\n" + ">                 goto put_device;\r\n" + ">         }\r\n" + ">         hdmi->sys_regmap = regmap;\r\n" + "> --\r\n" + "> 2.43.0\r\n" + "> \r\n" + "> \r\n" + "\r\n" + "\r\n" + "</pre>\r\n" + "</p></body></html><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice ********************\r\n" + "The information contained in this e-mail message (including any \r\n" + "attachments) may be confidential, proprietary, privileged, or otherwise\r\n" + "exempt from disclosure under applicable laws. It is intended to be \r\n" + "conveyed only to the designated recipient(s). Any use, dissemination, \r\n" + "distribution, printing, retaining or copying of this e-mail (including its \r\n" + "attachments) by unintended recipient(s) is strictly prohibited and may \r\n" + "be unlawful. If you are not an intended recipient of this e-mail, or believe \r\n" + "that you have received this e-mail in error, please notify the sender \r\n" + "immediately (by replying to this e-mail), delete any and all copies of \r\n" + "this e-mail (including any attachments) from your system, and do not\r\n" + "disclose the content of this e-mail to any other person. Thank you!\r\n" + </pre><!--}--> -2ffac9ad7b09ccdf785549e499b1753d3e352f9f91eacd112aa5e8114e6619f3 +68da748f2ee254a44a4556602bda80a709516d4e197a28c382ab08e0e366c9d2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.