From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C469C433F5 for ; Thu, 10 Mar 2022 19:37:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7CD0183AE8; Thu, 10 Mar 2022 20:37:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Jx/jApaw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3B7E783AF0; Thu, 10 Mar 2022 20:36:52 +0100 (CET) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BE8D383AFD for ; Thu, 10 Mar 2022 20:36:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ed1-x536.google.com with SMTP id s10so8391407edd.0 for ; Thu, 10 Mar 2022 11:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=FrORRr88udx7CxL4fAVnRIDtTXemmQUsCiHgkdwd7/8=; b=Jx/jApawsjNpsstbvOxpJUvR4V/DNrUam65dzx1UJEhPh1phYPpCwxINhGoZhsBY3g FqEbm9t6Rm/cYr8f6EXlyRgBdbat3A7LQvupW0VVn+mr/ALdDfQG8VRJeJIHQDufF5IL aAW6Er7Y2qKA3hjxNiq9Mpd14WkKXRrHl3C2j2Z2r4sv0kw+EG7N79Sr5ndeqpPCHSY7 8LbUMUYSaaG9FnS+qj7sq1Qg+ZHtpibndpKQcJRXvRoRNbfrFdbmPteVyLrVNv+M2RdD lU/tBWsJCo1rzZfAilETKpoWjQKrYDkt+ry4W1O1lcnh9JQkLo7bV3hEXfDY7hi0zveZ xCQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=FrORRr88udx7CxL4fAVnRIDtTXemmQUsCiHgkdwd7/8=; b=xij6JwNAvIi8RSdMQbLaQ8b4pDjkKLzmaNRpJOwtzRmt8o1BM3k11JCG9yTBIP04Po bOS5rgbtdtHnTLCEH4m6Z0LYmf26A6wtOKXwnQroJlHCeoRwyCv8Ez2hv8X+YHAnZ9BY H7Whic6KMDDOIdGDRDy3+fvhbjj5C4/SF8yaW3SGRiUQF6g4xuVNCEqHBvVUgtxrvJy+ 1tQS7zgd66hOEsdG8VLbANSK0ZLDLyNlD+R++IM61uyi3mQmwabhcVDlnyW77UvieECw 0s/ifKm49ankoF5VfrjeDrtn7SqKCKoHnXH7CcOq5VFZGTP+OJhuFZWIT/FwhR4z3t96 mVkg== X-Gm-Message-State: AOAM531SiscELLYFJVwDivSbZihnkv+kBjU1UPlJzeD79moxx8LzLHsy HAzPhq2LsifjbpQQH/3wZe0= X-Google-Smtp-Source: ABdhPJwFBl2KVwxXyKETiJoyIyZeFeEfQqlkXBcOX3alDd+mYNFMBcj5LENuK2KVnb5xDzp79I4YvQ== X-Received: by 2002:a05:6402:5192:b0:415:c6e6:23b with SMTP id q18-20020a056402519200b00415c6e6023bmr5932253edd.336.1646941003336; Thu, 10 Mar 2022 11:36:43 -0800 (PST) Received: from [192.168.0.74] ([178.233.26.119]) by smtp.gmail.com with ESMTPSA id c1-20020a170906762100b006d00ae72b0csm2018931ejn.221.2022.03.10.11.36.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Mar 2022 11:36:42 -0800 (PST) Message-ID: Date: Thu, 10 Mar 2022 22:30:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 From: Alper Nebi Yasak Subject: Re: [PATCH v3 21/26] binman: Support splitting an ELF file into multiple nodes To: Simon Glass Cc: Philippe Reynes , Ivan Mikhaylov , Peter Geis , huang lin , Jeffy Chen , Kever Yang , Tom Rini , U-Boot Mailing List References: <20220306031917.3005215-1-sjg@chromium.org> <20220306031917.3005215-22-sjg@chromium.org> Content-Language: en-US In-Reply-To: <20220306031917.3005215-22-sjg@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 06/03/2022 06:19, Simon Glass wrote: > Some boards need to load an ELF file using the 'loadables' property, but > the file has segments at different memory addresses. This means that it > cannot be supplied as a flat binary. > > Allow generating a separate node in the FIT for each segment in the ELF, > with a different load address for each. > > Also add checks that the fit,xxx directives are valid. > > Signed-off-by: Simon Glass > --- > > Changes in v3: > - Fix 'segmnet' typo > - Use seq == 0 instead of 'not seq' > > Changes in v2: > - Rewrite this to use the new FIT entry-type implementation > - Rename op-tee to tee-os > > tools/binman/entries.rst | 146 ++++++++++++ > tools/binman/etype/fit.py | 229 ++++++++++++++++++- > tools/binman/ftest.py | 147 ++++++++++++ > tools/binman/test/226_fit_split_elf.dts | 67 ++++++ > tools/binman/test/227_fit_bad_dir.dts | 9 + > tools/binman/test/228_fit_bad_dir_config.dts | 9 + > 6 files changed, 597 insertions(+), 10 deletions(-) > create mode 100644 tools/binman/test/226_fit_split_elf.dts > create mode 100644 tools/binman/test/227_fit_bad_dir.dts > create mode 100644 tools/binman/test/228_fit_bad_dir_config.dts I still can't like this enough to add a Reviewed-by, but I guess you'll apply the series up to and maybe including this, so: Acked-by: Alper Nebi Yasak