Re: [PATCH 1/1] RDMA/irdma: Make irdma_create_mg_ctx return a void

[Yanjun Zhu <yanjun.zhu@linux.dev>]

在 2022/2/18 2:19, yanjun.zhu@linux.dev 写道:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
> 
> The function irdma_create_mg_ctx always returns 0,
> so make it void and delete the return value check.
> 
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>

gentle ping

Zhu Yanjun

> ---
>   drivers/infiniband/hw/irdma/uda.c | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/uda.c b/drivers/infiniband/hw/irdma/uda.c
> index 7a9988ddbd01..5eeb76bc29fd 100644
> --- a/drivers/infiniband/hw/irdma/uda.c
> +++ b/drivers/infiniband/hw/irdma/uda.c
> @@ -86,8 +86,7 @@ enum irdma_status_code irdma_sc_access_ah(struct irdma_sc_cqp *cqp,
>    * irdma_create_mg_ctx() - create a mcg context
>    * @info: multicast group context info
>    */
> -static enum irdma_status_code
> -irdma_create_mg_ctx(struct irdma_mcast_grp_info *info)
> +static void irdma_create_mg_ctx(struct irdma_mcast_grp_info *info)
>   {
>   	struct irdma_mcast_grp_ctx_entry_info *entry_info = NULL;
>   	u8 idx = 0; /* index in the array */
> @@ -106,8 +105,6 @@ irdma_create_mg_ctx(struct irdma_mcast_grp_info *info)
>   			ctx_idx++;
>   		}
>   	}
> -
> -	return 0;
>   }
>   
>   /**
> @@ -135,9 +132,7 @@ enum irdma_status_code irdma_access_mcast_grp(struct irdma_sc_cqp *cqp,
>   		return IRDMA_ERR_RING_FULL;
>   	}
>   
> -	ret_code = irdma_create_mg_ctx(info);
> -	if (ret_code)
> -		return ret_code;
> +	irdma_create_mg_ctx(info);
>   
>   	set_64bit_val(wqe, 32, info->dma_mem_mc.pa);
>   	set_64bit_val(wqe, 16,