All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hui Zhu <hui.zhu@linux.dev>
To: Kurt Lin <lylin1023@gmail.com>, Hui Zhu <zhuhui@kylinos.cn>,
	Kumar Kartikeya Dwivedi <memxor@gmail.com>,
	bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	Jiri Olsa <jolsa@kernel.org>,
	Ihor Solodrai <ihor.solodrai@linux.dev>,
	Emil Tsalapatis <emil@etsalapatis.com>,
	Barry Song <baohua@kernel.org>, Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: Skip memcg_proactive_reclaim when data lands in shmem
Date: Mon, 16 Nov 2026 11:04:19 +0800	[thread overview]
Message-ID: <bbb07259-a2e8-40b5-9933-eb3d5d7a4bba@linux.dev> (raw)
In-Reply-To: <20261113180159.602033-1-lylin1023@gmail.com>

Hi Kurt,

I have two suggestions below.

2026/11/14 02:01, Kurt Lin:

> workload_dir() keeps the data file off tmpfs because shmem cannot be
> reclaimed without swap. But statfs() only sees the top of a stacking
> filesystem: with /tmp on overlayfs over tmpfs, as in virtme-ng guests,
> the check passes and all 32 MiB are still charged as shmem. Whether the
> test then passes depends on unrelated page cache in the cgroup; in a
> full test_progs run it fails with:
>
>    test_memcg_proactive_reclaim:FAIL:reclaimed unexpected reclaimed: actual 0 <= expected 0
>
> Check memory.stat after writing the file and skip when most of the
> data was charged as shmem.
>
> An AI coding assistant (Claude) was used to find and analyze the
> failure and to draft the fix and this changelog.
>
> Fixes: 0f9b1e9ef584 ("selftests/bpf: Add bpf_proactive_reclaim test")
> Signed-off-by: Kurt Lin <lylin1023@gmail.com>
> ---
>
> Notes:
>      Tested in a virtme-ng guest without swap: with /tmp on overlayfs over
>      tmpfs the test now skips; on a disk-backed directory it passes.
>      
>      After writing 32 MiB, memory.stat shows shmem 32.0 MiB on overlayfs
>      /tmp and on tmpfs, and 0.0 MiB on a disk-backed filesystem.
>
>   .../bpf/prog_tests/memcg_proactive_reclaim.c  | 28 +++++++++++++++++++
>   1 file changed, 28 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/memcg_proactive_reclaim.c b/tools/testing/selftests/bpf/prog_tests/memcg_proactive_reclaim.c
> index c22dcfabe856..c03550676041 100644
> --- a/tools/testing/selftests/bpf/prog_tests/memcg_proactive_reclaim.c
> +++ b/tools/testing/selftests/bpf/prog_tests/memcg_proactive_reclaim.c
> @@ -46,6 +46,28 @@ static const char *workload_dir(void)
>   	return NULL;
>   }
>   
> +/*
> + * statfs() only sees the top of a stacking filesystem. When /tmp is an
> + * overlayfs whose upper layer lives on tmpfs, as in virtme-ng guests, the
> + * check above passes but the written data still ends up as shmem. Ask the
> + * cgroup how the pages were actually charged.
> + */
> +static bool charged_as_shmem(void)
> +{
> +	static char buf[8192];
> +	unsigned long long shmem;
> +	char *p;
> +
> +	if (read_cgroup_file(CG_PATH, "memory.stat", buf, sizeof(buf)))
> +		return false;
Would it make sense to turn the silent "return false" into an explicit
assertion, e.g.:

     if (!ASSERT_OK(read_cgroup_file(CG_PATH, "memory.stat", buf,
                     sizeof(buf)), "read memory.stat"))
         return false;

My reasoning: memory.stat exists on every cgroup v2 hierarchy and the
"shmem" key is emitted unconditionally (not behind any CONFIG), and
cgroup_setup_and_join() has already succeeded by the time this runs.
So a read/parse failure here likely means something is genuinely
broken, rather than an environment limitation. With the silent
fallback, a shmem-backed dir falls through to the old confusing
"reclaimed: actual 0 <= expected 0" failure and the real cause is
never reported. The ASSERT_* macros are statement expressions, so this
works inside the bool helper: the failure is recorded with a clear
message first, and any subsequent "reclaimed" failure becomes
obviously secondary. (Skipping on the error path would be worse still
-- a genuine breakage would be counted as a pass, so I'd keep it as a
failure either way.)
> +
> +	p = strstr(buf, "\nshmem ");
> +	if (!p || sscanf(p, "\nshmem %llu", &shmem) != 1)
> +		return false;
> +
> +	return shmem >= FILE_SIZE / 2;


Small nit: a one-line comment on the threshold might help future
readers, something like "all-or-nothing: the data file is either fully
shmem (stacked tmpfs) or not shmem at all (disk-backed), so half of
FILE_SIZE is a safe midpoint". Also, printing the measured shmem value
in the SKIP message could be handy when debugging odd environments.

Best,
Hui


> +}
> +
>   void test_memcg_proactive_reclaim(void)
>   {
>   	struct memcg_proactive_reclaim *skel = NULL;
> @@ -99,6 +121,12 @@ void test_memcg_proactive_reclaim(void)
>   	if (!ASSERT_OK(fsync(data_fd), "fsync"))
>   		goto out;
>   
> +	if (charged_as_shmem()) {
> +		printf("%s:SKIP: %s is backed by shmem\n", __func__, dir);
> +		test__skip();
> +		goto out;
> +	}
> +
>   	args.cgroup_id = cgroup_id;
>   	args.size = FILE_SIZE;
>   	skel->bss->reclaimed = 0;
>
> base-commit: 0021f17128de5dc0b19f1a523f448df2440d8088

  parent reply	other threads:[~2026-11-16  3:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 18:01 [PATCH bpf-next] selftests/bpf: Skip memcg_proactive_reclaim when data lands in shmem Kurt Lin
2026-11-13 18:24 ` sashiko-bot
2026-11-16  3:04 ` Hui Zhu [this message]
2026-11-16 17:14   ` Kurt Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbb07259-a2e8-40b5-9933-eb3d5d7a4bba@linux.dev \
    --to=hui.zhu@linux.dev \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=baohua@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lylin1023@gmail.com \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    --cc=zhuhui@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.