From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16F5DC4708D for ; Tue, 13 Dec 2022 17:30:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9093417F7; Tue, 13 Dec 2022 18:29:52 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9093417F7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1670952642; bh=wIH5vLNvx7EU6z3Tt6F7dmxTQln02BgS/AT0+Rxa/4w=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=iVIeX8cXe4U8Ph/AxmA9xnQod4AWFbFMAVwNpsla6wCbngog8eM48CW3Id7Ymz/JH ALNlo7ANIPcBRMSNMvLXhPhJ/yiAWyBoDIEPoFJvqXe2bKxZQCp0VqDWooTyLwx8s3 O+Qr2gsrrBLyFhER5fDOZ1k43DjWw6wIfAmvU9GE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3A566F804D6; Tue, 13 Dec 2022 18:29:52 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 035AEF804E2; Tue, 13 Dec 2022 18:29:51 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AD8BEF80073 for ; Tue, 13 Dec 2022 18:29:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AD8BEF80073 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=h3wylBnG DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670952588; x=1702488588; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wIH5vLNvx7EU6z3Tt6F7dmxTQln02BgS/AT0+Rxa/4w=; b=h3wylBnG2AZ+pqTxFkWGGKK/dY+M4eWs8Zjw0+nvLLM+DpURjrr67YG5 FIU/Dsq2phHHfonYfCs7IWcAfUQTM8DBy+s19BmNBHOPVX7g5bU/cOOg4 4d8S25L98LUWbUfZ1TM3OBJddA0czM66869kiXBIeb7rhcH+/F8xQwI+A 3OyP9h7Zm0RRIdXe368SmhTy9xzS6kHnZSWpzjZAEd2Ksh9Ha8kQz+nel j2hvn4Pm3r4Naa0rOA8cXJvFFGA3TRRomXt+bkEpYzX7JMVZy8wZTw8Ph oiWaVxGDqbnmhxAT4kv0YjvtwxC9CR6ZiR2fJQwPagRFaF665+Ep1nUfz w==; X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="316893256" X-IronPort-AV: E=Sophos;i="5.96,242,1665471600"; d="scan'208";a="316893256" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2022 09:29:44 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="717301300" X-IronPort-AV: E=Sophos;i="5.96,242,1665471600"; d="scan'208";a="717301300" Received: from lvalluri-mobl.amr.corp.intel.com (HELO [10.212.67.174]) ([10.212.67.174]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2022 09:29:44 -0800 Message-ID: Date: Tue, 13 Dec 2022 09:42:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for the Advantech MICA-071 tablet To: Hans de Goede , Cezary Rojewski , Liam Girdwood , Mark Brown References: <20221213123246.11226-1-hdegoede@redhat.com> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: <20221213123246.11226-1-hdegoede@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Bard Liao Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 12/13/22 06:32, Hans de Goede wrote: > The Advantech MICA-071 tablet deviates from the defaults for > a non CR Bay Trail based tablet in several ways: > > 1. It uses an analog MIC on IN3 rather then using DMIC1 > 2. It only has 1 speaker > 3. It needs the OVCD current threshold to be set to 1500uA instead of > the default 2000uA to reliable differentiate between headphones vs > headsets > > Add a quirk with these settings for this tablet. > > Signed-off-by: Hans de Goede Acked-by: Pierre-Louis Bossart > --- > sound/soc/intel/boards/bytcr_rt5640.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c > index fb9d9e271845..ddd2625bed90 100644 > --- a/sound/soc/intel/boards/bytcr_rt5640.c > +++ b/sound/soc/intel/boards/bytcr_rt5640.c > @@ -570,6 +570,21 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { > BYT_RT5640_SSP0_AIF1 | > BYT_RT5640_MCLK_EN), > }, > + { > + /* Advantech MICA-071 */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Advantech"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MICA-071"), > + }, > + /* OVCD Th = 1500uA to reliable detect head-phones vs -set */ > + .driver_data = (void *)(BYT_RT5640_IN3_MAP | > + BYT_RT5640_JD_SRC_JD2_IN4N | > + BYT_RT5640_OVCD_TH_1500UA | > + BYT_RT5640_OVCD_SF_0P75 | > + BYT_RT5640_MONO_SPEAKER | > + BYT_RT5640_DIFF_MIC | > + BYT_RT5640_MCLK_EN), > + }, > { > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ARCHOS"),