Re: [PATCH net-next] net/mlx5: use do_aux_work for PHC overflow checks

[Vadim Fedorenko <vadim.fedorenko@linux.dev>]

On 18/12/2024 03:52, Richard Cochran wrote:
> On Tue, Dec 17, 2024 at 11:57:38AM -0800, Vadim Fedorenko wrote:
>> The overflow_work is using system wq to do overflow checks and updates
>> for PHC device timecounter, which might be overhelmed by other tasks.
>> But there is dedicated kthread in PTP subsystem designed for such
>> things. This patch changes the work queue to proper align with PTP
>> subsystem and to avoid overloading system work queue.
> 
> Yes, and you can configure that thread with chrt to ensure timely
> invocation of the callback.
> 
>> @@ -1188,7 +1192,6 @@ void mlx5_cleanup_clock(struct mlx5_core_dev *mdev)
>>   	}
>>   
>>   	cancel_work_sync(&clock->pps_info.out_work);
>> -	cancel_delayed_work_sync(&clock->timer.overflow_work);
> 
> Do you need ptp_cancel_worker_sync() ?

ptp_clock_unregister() calls kthread_cancel_delayed_work_sync() if
ptp->kworker exists, no need to call ptp_cancel_worker_sync() on cleanup.

> 
> Thanks,
> Richard