All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Doucha <mdoucha@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] save_restore: Introduce new struct field for flags
Date: Wed, 16 Nov 2022 16:51:15 +0100	[thread overview]
Message-ID: <bbf6dd3f-f736-88dc-96bb-575dfd2110cb@suse.cz> (raw)
In-Reply-To: <Y3UF2Jgkf0Svj7lm@yuki>

On 16. 11. 22 16:46, Cyril Hrubis wrote:
>> +static void print_error(int info_only, const char *err, const char *path)
>> +{
>> +	if (info_only)
>> +		tst_res(TINFO | TERRNO, err, path);
>> +	else
>> +		tst_brk(TBROK | TERRNO, err, path);
>> +}
> 
> If I remmeber correctly I did ask for this to become a macro or pass
> __LINE__ so that we have a correct lines in the error output and you
> haven't commented on that.
> 
> Otherwise the rest looks good to me.

Right, sorry, I forgot about the line numbers. I'll send v5 shortly.

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2022-11-16 15:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 14:54 [LTP] [PATCH v4] save_restore: Introduce new struct field for flags Martin Doucha
2022-11-16 15:46 ` Cyril Hrubis
2022-11-16 15:51   ` Martin Doucha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbf6dd3f-f736-88dc-96bb-575dfd2110cb@suse.cz \
    --to=mdoucha@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.