From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 13 Nov 2018 12:02:20 +0100 Subject: [U-Boot] [ANN] U-Boot v2018.11 delayed a day In-Reply-To: <20181113115459.5dce801c@bbrezillon> References: <20181112214016.GS11247@bill-the-cat> <8668e5b6-00a7-0ebb-8910-b9dd8dabf81b@gmail.com> <20181112222515.GU11247@bill-the-cat> <64cad1b6-99d6-f692-4b9f-aced8fd86fb5@gmail.com> <20181113011247.GV11247@bill-the-cat> <1f09ec2c-d2e6-0e83-541b-5e43fc736f41@gmail.com> <20181113113326.1a328b0b@xps13> <08bc9e78-1b67-1100-db62-dac7d6a89802@gmail.com> <20181113115459.5dce801c@bbrezillon> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/13/2018 11:54 AM, Boris Brezillon wrote: > On Tue, 13 Nov 2018 11:41:48 +0100 > Marek Vasut wrote: > >> On 11/13/2018 11:33 AM, Miquel Raynal wrote: >>> Hi Marek, >>> >>> +Jagan >>> >>> Marek Vasut wrote on Tue, 13 Nov 2018 03:12:49 >>> +0100: >>> >>>> On 11/13/2018 02:12 AM, Tom Rini wrote: >>>>> On Tue, Nov 13, 2018 at 01:03:41AM +0100, Marek Vasut wrote: >>>>>> On 11/12/2018 11:25 PM, Tom Rini wrote: >>>>>>> On Mon, Nov 12, 2018 at 11:13:29PM +0100, Marek Vasut wrote: >>>>>>>> On 11/12/2018 10:40 PM, Tom Rini wrote: >>>>>>>>> Hey all, >>>>>>>>> >>>>>>>>> Since Jagan promise a v2 SPI PR for some build fixes that we should have >>>>>>>>> in the release and I believe didn't get them out before the end of his >>>>>>>>> day, I'm letting everyone know now to expect the release tomorrow >>>>>>>>> instead, thanks! >>>>>>>> >>>>>>>> Will anyone have any chance to test those fixes to verify they didn't >>>>>>>> break anything ? >>>>>>> >>>>>>> Since they're obvious enough by inspection, I'm not worried about it. >>>>>> >>>>>> Which patches are those ? >>>>> >>>>> The ones in question? >>>> >>>> Yes, is there a list ? >>> >>> I think this is the branch: >>> https://github.com/openedev/u-boot-amarula/commits/v2-WIP5 >> >> Ugh, patchwork links would be nice. > > See here [1]. > >> >> But for example >> https://github.com/openedev/u-boot-amarula/commit/91d8f9979420827942ca1f336df36504bd2c1943 >> >> is quite inobvious, and I think buggy ... >> >> else if (env_get_f("mtdparts", tmp_parts, sizeof(tmp_parts) != -1)) >> >> sizeof(tmp_parts) != -1 will always be true. > > Indeed, I misplaced the closing parens, should be > > else if (env_get_f("mtdparts", tmp_parts, sizeof(tmp_parts)) != -1) And the -1 too, even if you move the parenthesis, according to include/common.h . -- Best regards, Marek Vasut