Re: [yocto-patches] [pseudo][PATCH 12/23] pseudo_util: Add default log severity values

[Paul Barker <paul@pbarker.dev>]

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

On Thu, 2026-07-02 at 19:46 -0500, Mark Hatle wrote:
> From: Dmitry Sakhonchik <frezidok1@gmail.com>
> 
> Default values are "show everything". If the user wants to see
> only certain categories, they should explicitely set
> PSEUDO_SEVERITY env var or use -k option.
> 
> Signed-off-by: Dmitry Sakhonchik <frezidok1@gmail.com>
> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
> ---
>  pseudo.h      | 2 ++
>  pseudo_util.c | 7 ++++---
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/pseudo.h b/pseudo.h
> index 92ae71e..66aa70e 100644
> --- a/pseudo.h
> +++ b/pseudo.h
> @@ -130,6 +130,8 @@ extern char *pseudo_version;
>  #define PSEUDO_PIDFILE "pseudo.pid"
>  #define PSEUDO_SOCKET "pseudo.socket"
>  
> +#define PSEUDO_SEVERITY_DEFAULT "info,warn,error"

This default is confusing. pseudo_error() doesn't check
pseudo_util_severity_flags, so errors are always printed.

This also isn't "show everything" as pseudo_debug() messages are not
shown with this default severity level. They are instead controlled by
pseudo_util_debug_flags, and having two separate sets of flags is
another level of confusion to me.

If we're overhauling the logging for v2.0, I think it would be much
better to merge the log/debug handling into one ordered list of severity
levels and control what is printed by specifying the minimum severity
level to output.

Best regards,

-- 
Paul Barker


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 252 bytes --]