Re: [PATCH v3 12/13] drm/xe/pmu: Fail probe if xe_pmu_register() fails

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 08-02-2025 03:49, Lucas De Marchi wrote:
> Now that previous callers in xe_device_probe() are handling the errors,
> that can be done for xe_pmu_register() as well.
> 
> Cc: Riana Tauro <riana.tauro@intel.com>
> Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_device.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 6f90d74330524..002e066f5f288 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -883,7 +883,9 @@ int xe_device_probe(struct xe_device *xe)
>   	if (err)
>   		goto err_unregister_display;
>   
> -	xe_pmu_register(&xe->pmu);
> +	err = xe_pmu_register(&xe->pmu);
> +	if (err)
> +		goto err_unregister_display;

LGTM
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

>   
>   	xe_debugfs_register(xe);
>