From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B4CEC433EF for ; Tue, 10 May 2022 11:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZZ0ZNNVEhhb+Wmgoer9wV8M1dLBLKo6biFXDyf//EuI=; b=PokoqtCyKUdgYM 0wQG1JI01+5+7EWPzp4AyWPu9T9cR5PkrnTXIAqm8oe2tCw2eZ9mOlgrqlVPyrLoFI4JelaS2B6Y/ xrf5JR+4fMFZcbbx1VdIPKVICJvyvtgjv9AT3sWwYpG82BzqhGTTjqnYyr5kpIv0J5BqkmNVtork6 DJDD0YZPp6xk6nhKp3aShlHW0TP9UdnII4yifEqhL2vKdPU8az7mXYqw7U9uRF9Da7ETeaBU5zUq8 GrNAix30sSrvU36ANftGMBXU8Hh+ztAe50haeSRkUx8DKf06ahmIsG6mwD+Yo8niJDQK4wUC4pf+y dgRYEE7RLDnC6OVdiqqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noNy8-001WiD-KF; Tue, 10 May 2022 11:23:56 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noNxx-001WcZ-Kq for linux-arm-kernel@lists.infradead.org; Tue, 10 May 2022 11:23:47 +0000 Received: by mail-ed1-x535.google.com with SMTP id t5so19565396edw.11 for ; Tue, 10 May 2022 04:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=LctLxw6WJgRnNRfVYjXR7qnVGoqfoOtpSvD0+ebnLhE=; b=RIz6tvyYGEz0K9vamq4/wwycNP/liF7QX/Z9HdwDgI5dUlz7Cbb4ZSh4cNdQ30NHYW g9CLZq6b4CTTxObQIfLBGIszm9KrxVisfOV8iHosRpUmBar4igC6mTznUVX9pZfDEU93 /DGLoowijKW/LABhcbEPyHE6QhwnURkNuGr8ltIteK+1seVYbLQU6QCryseLVIQhObYH 2QByimVv6/9QYX37sDPKysqJK2l1ssVq7oX4HcpUDUE1O0BJHgx/eUP+pCPo3N2sGHnQ f9CSJfFClBUf+lGIzgSaw1RW2zuguTXrBvpkZa0j4YI6AytU5S3ystD1DTZNdKkaGaOz ilaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=LctLxw6WJgRnNRfVYjXR7qnVGoqfoOtpSvD0+ebnLhE=; b=Bktr4WrAtfdwfi6TVTtMOuKSA9Lj8q/EXFdeb1HV13fRu0o9o/wS3GcgzC+XRfLQ+E v8/u554T/oToY9Asg89CW6HwnJrQzheO3nRp0MtUYcuOR5otUWMNYnFBb81Q/2pvxmuR o0b5PLkxgGmRLJZSvm/2jvomS1oDAPbvjKyTDazMm3/du8AlY3puDc7+/U0z8LCRnUYK S3spquBO9LRG3nQ/w/BY1+bZJXCm22MIu5uBmbdJi5Z076XXIyruHR2HlkvQZycmSh6c 8CyqWxAv0PNz8/ryA8cKuiGqzLaSgBosdO5TzDUAKQezspctndELQ/MInoYwXbI79RLi lLog== X-Gm-Message-State: AOAM533zZENJnL1cdDmXkI7HRPHArtIioAxqHj+EML7e06NgB1qd/GGM rscoE4ru0KH43sSME5eM6DY= X-Google-Smtp-Source: ABdhPJx6UaT/4WcJPNkyHKS8PFV8NwNi6CQ1w7jE7XdU0y7DVeuGveGz5acydbQS1rzlPg9qfPzVJg== X-Received: by 2002:aa7:c70f:0:b0:425:f70d:b34 with SMTP id i15-20020aa7c70f000000b00425f70d0b34mr23171384edq.306.1652181820868; Tue, 10 May 2022 04:23:40 -0700 (PDT) Received: from [192.168.26.149] (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.googlemail.com with ESMTPSA id n12-20020a1709065e0c00b006f3ef214e0bsm6107300eju.113.2022.05.10.04.23.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 May 2022 04:23:40 -0700 (PDT) Message-ID: Date: Tue, 10 May 2022 13:23:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Subject: Re: Optimizing kernel compilation / alignments for network performance To: Arnd Bergmann Cc: Andrew Lunn , Alexander Lobakin , Network Development , linux-arm-kernel , Russell King , Felix Fietkau , "openwrt-devel@lists.openwrt.org" , Florian Fainelli References: <84f25f73-1fab-fe43-70eb-45d25b614b4c@gmail.com> <20220427125658.3127816-1-alexandr.lobakin@intel.com> <066fc320-dc04-11a4-476e-b0d11f3b17e6@gmail.com> <510bd08b-3d46-2fc8-3974-9d99fd53430e@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_042345_765479_22C67875 X-CRM114-Status: GOOD ( 32.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gNi4wNS4yMDIyIDEwOjQ1LCBBcm5kIEJlcmdtYW5uIHdyb3RlOgo+IE9uIEZyaSwgTWF5IDYs IDIwMjIgYXQgOTo0NCBBTSBSYWZhxYIgTWnFgmVja2kgPHphamVjNUBnbWFpbC5jb20+IHdyb3Rl Ogo+Pgo+PiBPbiA1LjA1LjIwMjIgMTg6MDQsIEFuZHJldyBMdW5uIHdyb3RlOgo+Pj4+IHlvdSds bCBzZWUgdGhhdCBtb3N0IHVzZWQgZnVuY3Rpb25zIGFyZToKPj4+PiB2N19kbWFfaW52X3Jhbmdl Cj4+Pj4gX19pcnFlbnRyeV90ZXh0X2VuZAo+Pj4+IGwyYzIxMF9pbnZfcmFuZ2UKPj4+PiB2N19k bWFfY2xlYW5fcmFuZ2UKPj4+PiBiY21hX2hvc3Rfc29jX3JlYWQzMgo+Pj4+IF9fbmV0aWZfcmVj ZWl2ZV9za2JfY29yZQo+Pj4+IGFyY2hfY3B1X2lkbGUKPj4+PiBsMmMyMTBfY2xlYW5fcmFuZ2UK Pj4+PiBmaWJfdGFibGVfbG9va3VwCj4+Pgo+Pj4gVGhlcmUgaXMgYSBsb3Qgb2YgY2FjaGUgbWFu YWdlbWVudCBmdW5jdGlvbnMgaGVyZS4KPiAKPiBJbmRlZWQsIHNvIG9wdGltaXppbmcgdGhlIGNv aGVyZW5jeSBtYW5hZ2VtZW50IChzZWUgRmVsaXgnIHJlcGx5KQo+IGlzIGxpa2VseSB0byBoZWxw IG1vc3QgaW4gbWFraW5nIHRoZSBkcml2ZXIgZmFzdGVyLCBidXQgdGhhdCBkb2VzIG5vdAo+IGV4 cGxhaW4gd2h5IHRoZSBhbGlnbm1lbnQgb2YgdGhlIG9iamVjdCBjb2RlIGhhcyBzdWNoIGEgYmln IGltcGFjdAo+IG9uIHBlcmZvcm1hbmNlLgo+IAo+IFRvIGludmVzdGlnYXRlIHRoZSBhbGlnbm1l bnQgZnVydGhlciwgd2hhdCBJIHdhcyBhY3R1YWxseSBsb29raW5nIGZvcgo+IGlzIGEgY29tcGFy aXNvbiBvZiB0aGUgcHJvZmlsZSBvZiB0aGUgc2xvdyBhbmQgZmFzdCBjYXNlLiBIZXJlIEkgd291 bGQKPiBleHBlY3QgdGhhdCB0aGUgc2xvdyBjYXNlIHNwZW5kcyBtb3JlIHRpbWUgaW4gb25lIG9m IHRoZSBmdW5jdGlvbnMKPiB0aGF0IGRvbid0IGRlYWwgd2l0aCBjYWNoZSBtYW5hZ2VtZW50ICht YXliZSBmaWJfdGFibGVfbG9va3VwIG9yCj4gX19uZXRpZl9yZWNlaXZlX3NrYl9jb3JlKS4KPiAK PiBBIGZldyBvdGhlciB0aG91Z2h0czoKPiAKPiAtIGJjbWFfaG9zdF9zb2NfcmVhZDMyKCkgaXMg YSBmdW5kYW1lbnRhbGx5IHNsb3cgb3BlcmF0aW9uLCBtYXliZQo+ICAgIHNvbWUgb2YgdGhlIGNh bGxzIGNhbiB0dXJuZWQgaW50byBhIHJlbGF4ZWQgcmVhZCwgbGlrZSB0aGUgcmVhZGJhY2sKPiAg ICBpbiBiZ21hY19jaGlwX2ludHJzX29mZigpIG9yIHRoZSAncG9sbCBhZ2FpbicgYXQgdGhlIGVu ZCBiZ21hY19wb2xsKCksCj4gICAgdGhvdWdoIG9idmlvdXNseSBub3QgdGhlIG9uZSBpbiBiZ21h Y19kbWFfcnhfcmVhZCgpLgo+ICAgIEl0IG1heSBiZSBwb3NzaWJsZSB0byBldmVuIGF2b2lkIHNv bWUgb2YgdGhlIHJlYWRzIGVudGlyZWx5LCBjaGVja2luZwo+ICAgIGZvciBtb3JlIGRhdGEgaW4g YmdtYWNfcG9sbCgpIG1heSBhY3R1YWxseSBiZSBjb3VudGVycHJvZHVjdGl2ZQo+ICAgIGRlcGVu ZGluZyBvbiB0aGUgd29ya2xvYWQuCgpJJ2xsIGV4cGVyaW1lbnQgd2l0aCB0aGF0LCBob3BlZnVs bHkgSSBjYW4gb3B0aW1pemUgaXQgYSBiaXQuCgoKPiAtIFRoZSBoaWdoZXItZW5kIG5ldHdvcmtp bmcgU29DcyBhcmUgdXN1YWxseSBjYWNoZS1jb2hlcmVudCBhbmQKPiAgICBjYW4gYXZvaWQgdGhl IGNhY2hlIG1hbmFnZW1lbnQgZW50aXJlbHkuIFRoZXJlIGlzIGEgc2xpbSBjaGFuY2UKPiAgICB0 aGF0IHRoaXMgY2hpcCBpcyBkZXNpZ25lZCB0aGF0IHdheSBhbmQgaXQganVzdCBuZWVkcyB0byBi ZSBlbmFibGVkCj4gICAgcHJvcGVybHkuIE1vc3QgbG93LWVuZCBjaGlwcyBkb24ndCBpbXBsZW1l bnQgdGhlIGNvaGVyZW50Cj4gICAgaW50ZXJjb25uZWN0IHRob3VnaCwgYW5kIEkgc3VwcG9zZSB5 b3UgaGF2ZSBjaGVja2VkIHRoaXMgYWxyZWFkeS4KClRvIG15IGJlc3Qga25vd2xlZGdlIE5vcnRo c3RhciBwbGF0Zm9ybSBkb2Vzbid0IHN1cHBvcnQgaHcgY29oZXJlbmN5LgoKSSBqdXN0IHRvb2sg YW4gZXh0cmEgbG9vayBhdCBCcm9hZGNvbSdzIFNESyBhbmQgdGhlbSBzZWVtIHRvIGhhdmUgc29t ZQpkcml2ZXIgZm9yIHNlbGVjdGVkIGNoaXBzZXRzIGJ1dCBCQ003MDggaXNuJ3QgdGhlcmUuCgpj b25maWcgQkNNX0dMQl9DT0hFUkVOQ1kKCWJvb2wgIkdsb2JhbCBIYXJkd2FyZSBDYWNoZSBDb2hl cmVuY3kiCglkZWZhdWx0IG4KCWRlcGVuZHMgb24gQkNNOTYzMTU4IHx8IEJDTTk2ODQ2IHx8IEJD TTk2ODU4IHx8IEJDTTk2ODU2IHx8IEJDTTk2MzE3OCB8fCBCQ005NDc2MjIgfHwgQkNNOTYzMTQ2 ICB8fCBCQ005NDkxMiB8fCBCQ005NjgxMyB8fCBCQ005Njc1NiB8fCBCQ005Njg1NQoKCj4gLSBi Z21hY19kbWFfcnhfdXBkYXRlX2luZGV4KCkgYW5kIGJnbWFjX2RtYV90eF9hZGQoKSBhcHBlYXIK PiAgICB0byBoYXZlIGFuIGV4dHJhbmVvdXMgZG1hX3dtYigpLCB3aGljaCBzaG91bGQgYmUgaW1w bGllZCBieSB0aGUKPiAgICBub24tcmVsYXhlZCB3cml0ZWwoKSBpbiBiZ21hY193cml0ZSgpLgoK SSB0cmllZCBkcm9wcGluZyB3bWIoKSBjYWxscy4KV2l0aCB3bWIoKTogNDIxIE1iL3MKV2l0aG91 dDogNDE4IE1iL3MKCgpJIGFsc28gdHJpZWQgZHJvcHBpbmcgYmdtYWNfcmVhZCgpIGZyb20gYmdt YWNfY2hpcF9pbnRyc19vZmYoKSB3aGljaApzZWVtcyB0byBiZSBhIGZsdXNoaW5nIHJlYWRiYWNr LgoKV2l0aCBiZ21hY19yZWFkKCk6IDQyMSBNYi9zCldpdGhvdXQ6IDQxMyBNYi9zCgoKPiAtIGFj Y2Vzc2VzIHRvIHRoZSBETUEgZGVzY3JpcHRvciBkb24ndCBzaG93IHVwIGluIHRoZSBwcm9maWxl IGhlcmUsCj4gICAgYnV0IGxvb2sgbGlrZSB0aGV5IGNhbiBnZXQgbWlzb3B0aW1pemVkIGJ5IHRo ZSBjb21waWxlci4gSSB3b3VsZAo+ICAgIGdlbmVyYWxseSB1c2UgUkVBRF9PTkNFKCkgYW5kIFdS SVRFX09OQ0UoKSBmb3IgdGhlc2UgdG8KPiAgICBlbnN1cmUgdGhhdCB5b3UgZG9uJ3QgZW5kIHVw IHdpdGggZXh0cmEgb3Igb3V0LW9mLW9yZGVyIGFjY2Vzc2VzLgo+ICAgIFRoaXMgYWxzbyBtYWtl cyBpdCBjbGVhcmVyIHRvIHRoZSByZWFkZXIgdGhhdCBzb21ldGhpbmcgc3BlY2lhbAo+ICAgIGhh cHBlbnMgaGVyZS4KClNob3VsZCBJIHVzZSBzb21ldGhpbmcgYXMgYmVsb3c/CgpGV0lXIGl0IGRv ZXNuJ3Qgc2VlbSB0byBjaGFuZ2UgTkFUIHBlcmZvcm1hbmNlLgpXaXRob3V0IFdSSVRFX09OQ0U6 IDQyMSBNYi9zCldpdGg6IDQxOSBNYi9zCgoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L2V0aGVy bmV0L2Jyb2FkY29tL2JnbWFjLmMgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9icm9hZGNvbS9iZ21h Yy5jCmluZGV4IDg3NzAwMDcyLi5jZTk4ZjJhOSAxMDA2NDQKLS0tIGEvZHJpdmVycy9uZXQvZXRo ZXJuZXQvYnJvYWRjb20vYmdtYWMuYworKysgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9icm9hZGNv bS9iZ21hYy5jCkBAIC0xMTksMTAgKzExOSwxMCBAQCBiZ21hY19kbWFfdHhfYWRkX2J1ZihzdHJ1 Y3QgYmdtYWMgKmJnbWFjLCBzdHJ1Y3QgYmdtYWNfZG1hX3JpbmcgKnJpbmcsCgogIAlzbG90ID0g JnJpbmctPnNsb3RzW2ldOwogIAlkbWFfZGVzYyA9ICZyaW5nLT5jcHVfYmFzZVtpXTsKLQlkbWFf ZGVzYy0+YWRkcl9sb3cgPSBjcHVfdG9fbGUzMihsb3dlcl8zMl9iaXRzKHNsb3QtPmRtYV9hZGRy KSk7Ci0JZG1hX2Rlc2MtPmFkZHJfaGlnaCA9IGNwdV90b19sZTMyKHVwcGVyXzMyX2JpdHMoc2xv dC0+ZG1hX2FkZHIpKTsKLQlkbWFfZGVzYy0+Y3RsMCA9IGNwdV90b19sZTMyKGN0bDApOwotCWRt YV9kZXNjLT5jdGwxID0gY3B1X3RvX2xlMzIoY3RsMSk7CisJV1JJVEVfT05DRShkbWFfZGVzYy0+ YWRkcl9sb3csIGNwdV90b19sZTMyKGxvd2VyXzMyX2JpdHMoc2xvdC0+ZG1hX2FkZHIpKSk7CisJ V1JJVEVfT05DRShkbWFfZGVzYy0+YWRkcl9oaWdoLCBjcHVfdG9fbGUzMih1cHBlcl8zMl9iaXRz KHNsb3QtPmRtYV9hZGRyKSkpOworCVdSSVRFX09OQ0UoZG1hX2Rlc2MtPmN0bDAsIGNwdV90b19s ZTMyKGN0bDApKTsKKwlXUklURV9PTkNFKGRtYV9kZXNjLT5jdGwxLCBjcHVfdG9fbGUzMihjdGwx KSk7CiAgfQoKICBzdGF0aWMgbmV0ZGV2X3R4X3QgYmdtYWNfZG1hX3R4X2FkZChzdHJ1Y3QgYmdt YWMgKmJnbWFjLApAQCAtMzg3LDEwICszODcsMTAgQEAgc3RhdGljIHZvaWQgYmdtYWNfZG1hX3J4 X3NldHVwX2Rlc2Moc3RydWN0IGJnbWFjICpiZ21hYywKICAJICogQjQzX0RNQTY0X0RDVEwxX0FE RFJFWFRfTUFTSzsKICAJICovCgotCWRtYV9kZXNjLT5hZGRyX2xvdyA9IGNwdV90b19sZTMyKGxv d2VyXzMyX2JpdHMocmluZy0+c2xvdHNbZGVzY19pZHhdLmRtYV9hZGRyKSk7Ci0JZG1hX2Rlc2Mt PmFkZHJfaGlnaCA9IGNwdV90b19sZTMyKHVwcGVyXzMyX2JpdHMocmluZy0+c2xvdHNbZGVzY19p ZHhdLmRtYV9hZGRyKSk7Ci0JZG1hX2Rlc2MtPmN0bDAgPSBjcHVfdG9fbGUzMihjdGwwKTsKLQlk bWFfZGVzYy0+Y3RsMSA9IGNwdV90b19sZTMyKGN0bDEpOworCVdSSVRFX09OQ0UoZG1hX2Rlc2Mt PmFkZHJfbG93LCBjcHVfdG9fbGUzMihsb3dlcl8zMl9iaXRzKHJpbmctPnNsb3RzW2Rlc2NfaWR4 XS5kbWFfYWRkcikpKTsKKwlXUklURV9PTkNFKGRtYV9kZXNjLT5hZGRyX2hpZ2gsIGNwdV90b19s ZTMyKHVwcGVyXzMyX2JpdHMocmluZy0+c2xvdHNbZGVzY19pZHhdLmRtYV9hZGRyKSkpOworCVdS SVRFX09OQ0UoZG1hX2Rlc2MtPmN0bDAsIGNwdV90b19sZTMyKGN0bDApKTsKKwlXUklURV9PTkNF KGRtYV9kZXNjLT5jdGwxLCBjcHVfdG9fbGUzMihjdGwxKSk7CgogIAlyaW5nLT5lbmQgPSBkZXNj X2lkeDsKICB9CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00F82C433F5 for ; Tue, 10 May 2022 11:23:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240989AbiEJL1r (ORCPT ); Tue, 10 May 2022 07:27:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240988AbiEJL1l (ORCPT ); Tue, 10 May 2022 07:27:41 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 698282ABBF4 for ; Tue, 10 May 2022 04:23:42 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id y21so19604414edo.2 for ; Tue, 10 May 2022 04:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=LctLxw6WJgRnNRfVYjXR7qnVGoqfoOtpSvD0+ebnLhE=; b=RIz6tvyYGEz0K9vamq4/wwycNP/liF7QX/Z9HdwDgI5dUlz7Cbb4ZSh4cNdQ30NHYW g9CLZq6b4CTTxObQIfLBGIszm9KrxVisfOV8iHosRpUmBar4igC6mTznUVX9pZfDEU93 /DGLoowijKW/LABhcbEPyHE6QhwnURkNuGr8ltIteK+1seVYbLQU6QCryseLVIQhObYH 2QByimVv6/9QYX37sDPKysqJK2l1ssVq7oX4HcpUDUE1O0BJHgx/eUP+pCPo3N2sGHnQ f9CSJfFClBUf+lGIzgSaw1RW2zuguTXrBvpkZa0j4YI6AytU5S3ystD1DTZNdKkaGaOz ilaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=LctLxw6WJgRnNRfVYjXR7qnVGoqfoOtpSvD0+ebnLhE=; b=5KNgENUuoh0byvSQHYt2oKZh2yUnYYLAG9sycwWWcVx1uoEd5OyGFqSHF5Oha4mRFW 2ASgJ9p9vHHbaTn9vHoVHHonhhT0MCJracfnEq54DSPRxal8zUbnMOvd1MTnNItxrI8k gcloB1MVhRdr7Z0P0OU61o6zkbNDWgLs0TtvN9pOxmyFsI69Xo4tfqgrBr+mSBTIdUNV jUmjrLWum3VmAwOc+Ss497AQzcjYwOFaryTgYW0292jX1m9ULG9zriwgSkH3lbMlL99u ELsFTpfrttd3Iu2Ji3gjnlgbbC/udp2sM1N92A3Ax09vOqFK+L1N8nfwsMwtYPdZnUBZ TlMw== X-Gm-Message-State: AOAM531Y0etyxYBgFUaehQPPdflhp2ExCbdSeh5Mps1WbkdRQMwU6LDO peCl1O11y4LDOn4el8hYjhc= X-Google-Smtp-Source: ABdhPJx6UaT/4WcJPNkyHKS8PFV8NwNi6CQ1w7jE7XdU0y7DVeuGveGz5acydbQS1rzlPg9qfPzVJg== X-Received: by 2002:aa7:c70f:0:b0:425:f70d:b34 with SMTP id i15-20020aa7c70f000000b00425f70d0b34mr23171384edq.306.1652181820868; Tue, 10 May 2022 04:23:40 -0700 (PDT) Received: from [192.168.26.149] (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.googlemail.com with ESMTPSA id n12-20020a1709065e0c00b006f3ef214e0bsm6107300eju.113.2022.05.10.04.23.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 May 2022 04:23:40 -0700 (PDT) Message-ID: Date: Tue, 10 May 2022 13:23:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Subject: Re: Optimizing kernel compilation / alignments for network performance To: Arnd Bergmann Cc: Andrew Lunn , Alexander Lobakin , Network Development , linux-arm-kernel , Russell King , Felix Fietkau , "openwrt-devel@lists.openwrt.org" , Florian Fainelli References: <84f25f73-1fab-fe43-70eb-45d25b614b4c@gmail.com> <20220427125658.3127816-1-alexandr.lobakin@intel.com> <066fc320-dc04-11a4-476e-b0d11f3b17e6@gmail.com> <510bd08b-3d46-2fc8-3974-9d99fd53430e@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 6.05.2022 10:45, Arnd Bergmann wrote: > On Fri, May 6, 2022 at 9:44 AM Rafał Miłecki wrote: >> >> On 5.05.2022 18:04, Andrew Lunn wrote: >>>> you'll see that most used functions are: >>>> v7_dma_inv_range >>>> __irqentry_text_end >>>> l2c210_inv_range >>>> v7_dma_clean_range >>>> bcma_host_soc_read32 >>>> __netif_receive_skb_core >>>> arch_cpu_idle >>>> l2c210_clean_range >>>> fib_table_lookup >>> >>> There is a lot of cache management functions here. > > Indeed, so optimizing the coherency management (see Felix' reply) > is likely to help most in making the driver faster, but that does not > explain why the alignment of the object code has such a big impact > on performance. > > To investigate the alignment further, what I was actually looking for > is a comparison of the profile of the slow and fast case. Here I would > expect that the slow case spends more time in one of the functions > that don't deal with cache management (maybe fib_table_lookup or > __netif_receive_skb_core). > > A few other thoughts: > > - bcma_host_soc_read32() is a fundamentally slow operation, maybe > some of the calls can turned into a relaxed read, like the readback > in bgmac_chip_intrs_off() or the 'poll again' at the end bgmac_poll(), > though obviously not the one in bgmac_dma_rx_read(). > It may be possible to even avoid some of the reads entirely, checking > for more data in bgmac_poll() may actually be counterproductive > depending on the workload. I'll experiment with that, hopefully I can optimize it a bit. > - The higher-end networking SoCs are usually cache-coherent and > can avoid the cache management entirely. There is a slim chance > that this chip is designed that way and it just needs to be enabled > properly. Most low-end chips don't implement the coherent > interconnect though, and I suppose you have checked this already. To my best knowledge Northstar platform doesn't support hw coherency. I just took an extra look at Broadcom's SDK and them seem to have some driver for selected chipsets but BCM708 isn't there. config BCM_GLB_COHERENCY bool "Global Hardware Cache Coherency" default n depends on BCM963158 || BCM96846 || BCM96858 || BCM96856 || BCM963178 || BCM947622 || BCM963146 || BCM94912 || BCM96813 || BCM96756 || BCM96855 > - bgmac_dma_rx_update_index() and bgmac_dma_tx_add() appear > to have an extraneous dma_wmb(), which should be implied by the > non-relaxed writel() in bgmac_write(). I tried dropping wmb() calls. With wmb(): 421 Mb/s Without: 418 Mb/s I also tried dropping bgmac_read() from bgmac_chip_intrs_off() which seems to be a flushing readback. With bgmac_read(): 421 Mb/s Without: 413 Mb/s > - accesses to the DMA descriptor don't show up in the profile here, > but look like they can get misoptimized by the compiler. I would > generally use READ_ONCE() and WRITE_ONCE() for these to > ensure that you don't end up with extra or out-of-order accesses. > This also makes it clearer to the reader that something special > happens here. Should I use something as below? FWIW it doesn't seem to change NAT performance. Without WRITE_ONCE: 421 Mb/s With: 419 Mb/s diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c index 87700072..ce98f2a9 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c @@ -119,10 +119,10 @@ bgmac_dma_tx_add_buf(struct bgmac *bgmac, struct bgmac_dma_ring *ring, slot = &ring->slots[i]; dma_desc = &ring->cpu_base[i]; - dma_desc->addr_low = cpu_to_le32(lower_32_bits(slot->dma_addr)); - dma_desc->addr_high = cpu_to_le32(upper_32_bits(slot->dma_addr)); - dma_desc->ctl0 = cpu_to_le32(ctl0); - dma_desc->ctl1 = cpu_to_le32(ctl1); + WRITE_ONCE(dma_desc->addr_low, cpu_to_le32(lower_32_bits(slot->dma_addr))); + WRITE_ONCE(dma_desc->addr_high, cpu_to_le32(upper_32_bits(slot->dma_addr))); + WRITE_ONCE(dma_desc->ctl0, cpu_to_le32(ctl0)); + WRITE_ONCE(dma_desc->ctl1, cpu_to_le32(ctl1)); } static netdev_tx_t bgmac_dma_tx_add(struct bgmac *bgmac, @@ -387,10 +387,10 @@ static void bgmac_dma_rx_setup_desc(struct bgmac *bgmac, * B43_DMA64_DCTL1_ADDREXT_MASK; */ - dma_desc->addr_low = cpu_to_le32(lower_32_bits(ring->slots[desc_idx].dma_addr)); - dma_desc->addr_high = cpu_to_le32(upper_32_bits(ring->slots[desc_idx].dma_addr)); - dma_desc->ctl0 = cpu_to_le32(ctl0); - dma_desc->ctl1 = cpu_to_le32(ctl1); + WRITE_ONCE(dma_desc->addr_low, cpu_to_le32(lower_32_bits(ring->slots[desc_idx].dma_addr))); + WRITE_ONCE(dma_desc->addr_high, cpu_to_le32(upper_32_bits(ring->slots[desc_idx].dma_addr))); + WRITE_ONCE(dma_desc->ctl0, cpu_to_le32(ctl0)); + WRITE_ONCE(dma_desc->ctl1, cpu_to_le32(ctl1)); ring->end = desc_idx; }