All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Atharva Tiwari <atharvatiwarilinuxdev@gmail.com>
Cc: airlied@gmail.com, atharvatiwarilinuxdev@gmail.com,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org, joonas.lahtinen@linux.intel.com,
	linux-kernel@vger.kernel.org, rodrigo.vivi@intel.com,
	simona@ffwll.ch, tursulin@ursulin.net,
	ville.syrjala@linux.intel.com
Subject: Re: [PATCH 2/2] drm/i915/display: Disable display for iMac's
Date: Tue, 27 Jan 2026 16:57:25 +0200	[thread overview]
Message-ID: <bc778f93d4e2a18848bc93a51aed9b627bcbb2cf@intel.com> (raw)
In-Reply-To: <20260126204915.1324-1-atharvatiwarilinuxdev@gmail.com>

On Mon, 26 Jan 2026, Atharva Tiwari <atharvatiwarilinuxdev@gmail.com> wrote:
>> Rendering and display are quite separate in the hardware and in the
>> driver. Perhaps you do not mean "rendering" here? Perhaps it can be used
>> for rendering but not display?
>
> Yeah, it can be used for rendering but not display, sorry for the wording.
>
>> Okay, so perhaps there's no eDP connected. But what about the other
>> connectors on the iGPU? What about everything else in the display
>> hardware?
>
> You cant use the iGPU to drive the display on any hardware (including external displays).
>
>> If you can figure out that it's specifically link training that fails (a
>> dmesg would be useful to show this) there clearly is display hardware,
>> right?
>
> As said the iGPU cant drive the display on all monitors (even on macOS), but still heres the dmesg before this patch:
>
> [    5.095489] i915 0000:00:02.0: [drm] Found cometlake (device ID 9bc8) integrated display version 9.00 stepping N/A
> [    5.096061] i915 0000:00:02.0: [drm] VT-d active for gfx access
> [    5.096102] i915 0000:00:02.0: [drm] Using Transparent Hugepages
> [    5.099214] i915 0000:00:02.0: Invalid PCI ROM header signature: expecting 0xaa55, got 0xffff
> [    5.099217] i915 0000:00:02.0: [drm] Failed to find VBIOS tables (VBT)
> [    5.099324] i915 0000:00:02.0: vgaarb: VGA decodes changed: olddecodes=io+mem,decodes=none:owns=io+mem
> [    5.100960] i915 0000:00:02.0: [drm] Finished loading DMC firmware i915/kbl_dmc_ver1_04.bin (v1.4)
> [    5.832214] i915 0000:00:02.0: [drm] [ENCODER:105:DDI A/PHY A] failed to retrieve link info, disabling eDP
> [    5.835756] i915 0000:00:02.0: [drm] Registered 3 planes with drm panic
> [    6.428455] i915 0000:00:02.0: [drm] Cannot find any crtc or sizes
> [    6.722404] i915 0000:00:02.0: [drm] Cannot find any crtc or sizes
>
>> There's at least three levels where this could be handled, depending on
>> details:
>> 
>> - Display probe (the patch at hand). Assumes there's no display
>>   hardware, at all. The driver doesn't touch the hardware, which
>>   continues to consume power, it's not put in low power states. Not
>>   optimal if there actually is display hardware.
>> 
>> - Display disable. See intel_display_device_enabled(). The driver takes
>>   over the hardware, puts it to sleep, but prevents all connectors from
>>   being connected.

At a glance, this seems like the appropriate level.

What if you drop patch 2 and supply i915.disable_display=1 module
parameter? Or return false from intel_display_device_enabled().


BR,
Jani.

>> 
>> - eDP disable. Add a quirk somewhere to enforce eDP is disconnected, but
>>   other connectors can be used.
>
> The main reason I sent this patch is that after i915 trys to probe the display,
> the dGPU (amdgpu) is no longer able to detect the internal display,
> resulting in a black screen.
>
>> It would be quite useful to indicate the PCI ID of the device in
>> question.
>
> 00:02.0 VGA compatible controller [0300]: Intel Corporation CometLake-S GT2 [UHD Graphics 630] [8086:9bc8] (rev 03) (prog-if 00 [VGA controller])
> 	Subsystem: Apple Inc. CometLake-S GT2 [UHD Graphics 630] [106b:ffff]

-- 
Jani Nikula, Intel

  reply	other threads:[~2026-01-27 14:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-25  0:10 [PATCH 0/2] Add support for eGPUs on Apple Products Atharva Tiwari
2026-01-25  0:11 ` [PATCH 1/2] efi/libstub: Enable apple-set-os for all Apple Devices Atharva Tiwari
2026-01-25  0:11 ` [PATCH 2/2] drm/i915/display: Disable display for iMac's Atharva Tiwari
2026-01-26  9:41   ` Jani Nikula
2026-01-26 20:49     ` Atharva Tiwari
2026-01-27 14:57       ` Jani Nikula [this message]
2026-01-27 18:39         ` Atharva Tiwari
2026-01-28 11:41           ` Jani Nikula
2026-01-26 14:38 ` ✗ LGCI.VerificationFailed: failure for Add support for eGPUs on Apple Products Patchwork
2026-01-26 16:26 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc778f93d4e2a18848bc93a51aed9b627bcbb2cf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=atharvatiwarilinuxdev@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=tursulin@ursulin.net \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.