From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E3CEC3600B for ; Mon, 31 Mar 2025 14:08:30 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.932573.1334677 (Exim 4.92) (envelope-from ) id 1tzFoA-0002yH-AM; Mon, 31 Mar 2025 14:08:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 932573.1334677; Mon, 31 Mar 2025 14:08:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tzFoA-0002yA-7F; Mon, 31 Mar 2025 14:08:10 +0000 Received: by outflank-mailman (input) for mailman id 932573; Mon, 31 Mar 2025 14:08:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tzFo9-0002y4-3b for xen-devel@lists.xenproject.org; Mon, 31 Mar 2025 14:08:09 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 91fb51d2-0e39-11f0-9ea7-5ba50f476ded; Mon, 31 Mar 2025 16:08:07 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-43cfebc343dso33786205e9.2 for ; Mon, 31 Mar 2025 07:08:07 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d82e6adf6sm164469255e9.15.2025.03.31.07.08.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Mar 2025 07:08:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91fb51d2-0e39-11f0-9ea7-5ba50f476ded DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1743430087; x=1744034887; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=/OCOcG6P9mAeJAunhReJkrJSdX+Xzr8EMW/S5KpwgEE=; b=XwGm3rJjYFZ95yqjvkZUbqXRUJUSsXammZv6GwLskA49jR+/9grS3q9HzGWaT8c8f1 m14YYTywpn+N70/nQ7+CRcVMVnCPq4j9/47v/zw6AKQQxp2yE9rHSFlapzXLENKsUcwq A+c2EsoE1Q7FKePG6aen9hIxAqrfRZhfPr8GUtjVDELVzmt8d4Tgmj4mTn831RzWLhQ0 um3H76bAqNY5Nq9jSLEVdYoHkXlK1puT1vMJbKYETRWUouilB9lMt92qfyUGNJ2NeJOt NdY+RkZ/l9G/sHCUmwa0wljI4MTiZxsSenUingEOdyvI0CU8k2NRqUB7NYeIOGsLnVX5 s3IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743430087; x=1744034887; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/OCOcG6P9mAeJAunhReJkrJSdX+Xzr8EMW/S5KpwgEE=; b=kscWU6LYP/0vaq3Z3vNua6gziNV6LIqNzn3jACyTIdeO1rqSJQ03ZLDxdtq6a4Ywl2 g9QVSHv0olO99jmcWCwismC97pbxrwZsWKDtbx/wb8KF2ns9NeUy+COSzpKb4GrtQWao 80nerhidFQjXIgC4g5sYNG9tX2Ra35hhtcdtZ+iLINpSzmPlS+In6PKAQjo0utjKN3ai CJ+kYoJvzjkifI8U1NQZS3ypAGElvuWBjFmxEIlsA1yy0B4sp89Sv1VEvGzzyQBUIKM+ mz/3l0BQKARzgfkmbiHTO7ftg4qy94gMZ5YQL7a0nxUs3Ryw+wb4qpLjbj8RBMCdtR+k wCCQ== X-Forwarded-Encrypted: i=1; AJvYcCVqbb4rDsJZPUwXULjn85iv50d0OadPklho65GFnZaFpgJx0nqXvW/esUUoT2yyGSzLNzcz7BcWi6U=@lists.xenproject.org X-Gm-Message-State: AOJu0YwFk9B7DhQqEWbQNcgZsaA9WVt/zytHHbnZVABoD3gPwuQGWHxu trJ/zYEAwpAtyTJI0G2K4hvW+lpA9Bwulnpg76rPjxNAmH0HG+Rpaq/jXBabRA== X-Gm-Gg: ASbGncsgYo/KXse6zEPx2ZQnvz71ZV4JZyDbi9HLzu6IrQ3B4+dJCVuGXmIadJXcF1m PnHims+XXAnHgXUVEemBRB9yWlk4ZhQpe0bErFlhrnYGUUrBm6oVQzHPXFGjJUS/MQ714DYj/68 QtPoDe30K9dHbhx1Vu6pOQND9yCyosWNFf6/jCS7LFqKl3XgapOc0ARqscfLAzlPe/4uyiwBGHz yR4GDSknEE9z2PpsHt6P6WCXowN7W3wMw7E7BJO7hhRrJ5dR2OBVIvSC6xZ3JYuGU8eKoa/J5Ko dcBiJhoVzUlJPynFi2HsIHkW8+D6qsXI/E5bgS3farUIfg45C+v8nJbH1eo8wW7fmdRKI1nEJWQ sHIaPMyc/ATLmdQ/aG1r1INzcuIUI0MfloMQYXisc X-Google-Smtp-Source: AGHT+IEATkPppot9ETklh5xd0lZWl7gxTRrffJFyHDM0jBgIMzldRQINLO0hslXwzgxpLtssjBZRlw== X-Received: by 2002:a5d:5f52:0:b0:391:22a9:4408 with SMTP id ffacd0b85a97d-39c120dd71dmr7836683f8f.16.1743430086655; Mon, 31 Mar 2025 07:08:06 -0700 (PDT) Message-ID: Date: Mon, 31 Mar 2025 16:08:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 03/16] xen: Implement common byte{order,swap}.h To: Andrew Cooper Cc: Lin Liu , Anthony PERARD , Michal Orzel , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Shawn Anastasio , Oleksii Kurochko , "Daniel P . Smith" , Xen-devel References: <20250328134427.874848-1-andrew.cooper3@citrix.com> <20250328134427.874848-4-andrew.cooper3@citrix.com> <0fafaf3f-ded6-4444-a635-bf32a47b209b@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <0fafaf3f-ded6-4444-a635-bf32a47b209b@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 31.03.2025 15:59, Andrew Cooper wrote: > On 31/03/2025 9:32 am, Jan Beulich wrote: >> On 28.03.2025 14:44, Andrew Cooper wrote: >>> +#if defined(__LITTLE_ENDIAN) >>> + >>> +# define cpu_to_le64(x) (uint64_t)(x) >>> +# define le64_to_cpu(x) (uint64_t)(x) >>> +# define cpu_to_le32(x) (uint32_t)(x) >>> +# define le32_to_cpu(x) (uint32_t)(x) >>> +# define cpu_to_le16(x) (uint16_t)(x) >>> +# define le16_to_cpu(x) (uint16_t)(x) >> (Not just) for Misra these all need another pair of parentheses around the >> entire expressions. > > Why?  For both points?  Eclair is happy, with this at least. As was explained to us, Eclair looks at the final, expanded code. Hence it may well be that right now, in the code Eclair checks, we have no violations. Ones may start to appear elsewhere or later, though. The fix then would still be to get these macros into fully parenthesized shape. That said, I can't think of any "good" code needing these parentheses here. I can think of bad code though, which would properly fail to compile if the parentheses were added, e.g. le32_to_cpu(a)++; I fear I can't answer the 2nd question - what do you mean by "For both points?"? Jan