All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: "Kernel.org Tools" <tools@kernel.org>
Subject: b4 review: reply to a patch note + misc.
Date: Tue, 30 Jun 2026 12:17:43 +0200	[thread overview]
Message-ID: <bc88076e-2629-45bf-ab20-242f823dde4e@kernel.org> (raw)

Hi Konstantin,

When a patch has a note under 3 dashes, the note is dropped when the
patch is applied during a review, as expected. Except that it also means
the note is no longer there when replying to a patch from b4 review tui.

Do you think the "Reply" view could use the email from lore instead?

While at it, some small ideas:

- I find it "too easy" to quit the "Review" view: I'm on a patch,
  checking follow-up comments, etc. then if I hit an extra 'q', I'm
  back on the "Tracked" list, switching back to another commit in git,
  etc. Maybe a "confirmation" question could help? Or a different short
  key?

- When I press the 'review' button, I need to specify the commit/branch
  for the new base. I usually prefer to apply it on top of the current
  HEAD, but I'm not sure how to force b4 to suggest that by default. I
  tried using "git config b4.review-target-branch", but it still guesses
  something else.

- Could we eventually have a template for the replies? It would be good
  to automatically add a header (Hi <first name>,) and a trailer (like
  here at the bottom).

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


                 reply	other threads:[~2026-06-30 10:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc88076e-2629-45bf-ab20-242f823dde4e@kernel.org \
    --to=matttbe@kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=tools@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.