All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: webgeek1234@gmail.com, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: Add Retroid Pocket 6
Date: Mon, 17 Aug 2026 18:11:38 +0200	[thread overview]
Message-ID: <bcb5ff23-cbcf-48ec-85c8-613a7d2dc515@oss.qualcomm.com> (raw)
In-Reply-To: <20260808-rp-qcs8550-v1-3-a5a365ba3dc5@gmail.com>

On 8/8/26 7:37 PM, Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@gmail.com>
> 
> The Retroid Pocket 6 is a high-performance Android-based handheld gaming
> console powered by the Qualcomm Snapdragon 8 Gen 2 processor featuring a
> 5.5-inch AMOLED touchscreen.

[...]

> +&{/} {
> +	model = "Retroid Pocket 6";
> +	compatible = "retroidpocket,rp6", "qcom,qcs8550", "qcom,sm8550";
> +
> +	backlight: backlight {
> +		compatible = "pwm-backlight";
> +		pwms = <&pmk8550_pwm 0 860000>;
> +		brightness-levels = <1023 0>;
> +		num-interpolated-steps = <1023>;
> +		default-brightness-level = <600>;
> +		power-supply = <&vph_pwr>;
> +		enable-gpios = <&pmk8550_gpios 5 GPIO_ACTIVE_HIGH>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pwm_backlight_default>;

property-n
property-names

in this order please


> +&i2c_hub_3 {
> +	clock-frequency = <100000>;
> +
> +	status = "okay";
> +
> +	touchscreen@38 {
> +		compatible = "focaltech,ft5426";
> +		reg = <0x38>;
> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
> +		reset-gpios = <&tlmm 14 GPIO_ACTIVE_LOW>;
> +
> +		vcc-supply = <&ts_avdd_3v0>;
> +		iovcc-supply = <&ts_vddio_1v8>;
> +
> +		pinctrl-0 = <&ts_p_rst_default &ts_p_int_default>;

<&foo>, <&bar> preferably (dtc treats it all the same unforunately..)

otherwise largely lgtm

Konrad

  parent reply	other threads:[~2026-08-17 16:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-08 17:37 [PATCH 0/4] arm64: dts: qcom: Support Retroid Pocket QCS8550 Devices Aaron Kling via B4 Relay
2026-08-08 17:37 ` Aaron Kling
2026-08-08 17:37 ` [PATCH 1/4] dt-bindings: vendor-prefixes: Add Retroid Pocket Aaron Kling via B4 Relay
2026-08-08 17:37   ` Aaron Kling
2026-08-13  9:20   ` Krzysztof Kozlowski
2026-08-08 17:37 ` [PATCH 2/4] dt-bindings: arm: qcom: Add Retroid Pocket QCS8550 Devices Aaron Kling via B4 Relay
2026-08-08 17:37   ` Aaron Kling
2026-08-13  9:23   ` Krzysztof Kozlowski
2026-08-14 18:40     ` Aaron Kling
2026-08-08 17:37 ` [PATCH 3/4] arm64: dts: qcom: Add Retroid Pocket 6 Aaron Kling via B4 Relay
2026-08-08 17:37   ` Aaron Kling
2026-08-13 19:05   ` Dmitry Baryshkov
2026-08-14 18:59     ` Aaron Kling
2026-08-15 14:44       ` Dmitry Baryshkov
2026-08-17 16:11   ` Konrad Dybcio [this message]
2026-08-08 17:37 ` [PATCH 4/4] arm64: dts: qcom: Add Retroid Pocket Nova Aaron Kling via B4 Relay
2026-08-08 17:37   ` Aaron Kling
2026-08-13  9:24   ` Krzysztof Kozlowski
2026-08-14 19:03     ` Aaron Kling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bcb5ff23-cbcf-48ec-85c8-613a7d2dc515@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=webgeek1234@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.