Re: [PATCH] selftests: settings: tests can be in subsubdirs

[shuah <shuah@kernel.org>]

On 1/27/20 9:05 AM, Matthieu Baerts wrote:
> Hi Shuah, Kees,
> 
> On 21/11/2019 19:52, Kees Cook wrote:
>> On Thu, Nov 21, 2019 at 05:32:42PM +0100, Matthieu Baerts wrote:
>>> Hi Shuah,
>>>
>>> First, thank you for maintaining the Kernel Selftest framework!
>>>
>>> On 22/10/2019 19:12, Matthieu Baerts wrote:
>>>> Commit 852c8cbf34d3 (selftests/kselftest/runner.sh: Add 45 second
>>>> timeout per test) adds support for a new per-test-directory "settings"
>>>> file. But this only works for tests not in a sub-subdirectories, e.g.
>>>>
>>>>    - tools/testing/selftests/rtc (rtc) is OK,
>>>>    - tools/testing/selftests/net/mptcp (net/mptcp) is not.
>>>>
>>>> We have to increase the timeout for net/mptcp tests which are not
>>>> upstreamed yet but this fix is valid for other tests if they need to 
>>>> add
>>>> a "settings" file, see the full list with:
>>>>
>>>>     tools/testing/selftests/*/*/**/Makefile
>>>>
>>>> Note that this patch changes the text header message printed at the end
>>>> of the execution but this text is modified only for the tests that are
>>>> in sub-subdirectories, e.g.
>>>>
>>>>     ok 1 selftests: net/mptcp: mptcp_connect.sh
>>>>
>>>> Before we had:
>>>>
>>>>     ok 1 selftests: mptcp: mptcp_connect.sh
>>>>
>>>> But showing the full target name is probably better, just in case a
>>>> subsubdir has the same name as another one in another subdirectory.
>>>>
>>>> Fixes: 852c8cbf34d3 (selftests/kselftest/runner.sh: Add 45 second 
>>>> timeout per test)
>>>> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
>>> Sorry to bother you again with this but by chance, did you have a 
>>> look at
>>> the patch below? :)
>>>
>>> It doesn't only fix an issue with MPTCP, not in the kernel yet. But 
>>> it also
>>> fixes the issue of taking the right "settings" file (if available) 
>>> for any
>>> other tests in a sub-directory, e.g.:
>>>
>>>    drivers/dma-buf
>>>    filesystems/binderfs
>>>    net/forwarding
>>>    networking/timestamping
>>>
>>> But I guess all tests in powerpc/* dirs and others.
>>
>> Thanks for the ping! I missed this patch when you originally sent it.
>> Yes, this make sense to me:
>>
>> Reviewed-by: Kees Cook <keescook@chromium.org>
> 
> Kees, Thank you for this review!
> 
> Shuah, I am sorry to send you this new request. It is just to inform you 
> that the first selftests for MPTCP are now in "net-next" repo, ready for 
> the future Linux 5.6.
> We would then be very happy to see this patch here below for the 
> kselftest framework accepted to avoid timeouts. Locally we apply this 
> patch before running the selftests but we cannot ask everybody running 
> MPTCP' selftests to do the same :)
> 
>

I am sorry for the delay. My bad. Looks like I just missed it. I will
make sure it gets into 5.6-rc1

Thanks for your patience and ping.

thanks,
-- Shuah