From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Subject: [PATCH 2 of 7] tools/check: call all check_* scripts with shell
Date: Tue, 04 Oct 2011 16:21:51 +0200 [thread overview]
Message-ID: <bcd7b8ee7e99dc6348c3.1317738111@probook.site> (raw)
In-Reply-To: <patchbomb.1317738109@probook.site>
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1317738016 -7200
# Node ID bcd7b8ee7e99dc6348c3132a7248db5829bc53f9
# Parent c2daf20cf860d942d1105ce2f5fa7e171c536466
tools/check: call all check_* scripts with shell
Adding new check_* scripts via patch should be possible.
Expect that every script is a shell script and call it with sh.
This removes the need for executable permissions of the individual scripts.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r c2daf20cf860 -r bcd7b8ee7e99 install.sh
--- a/install.sh
+++ b/install.sh
@@ -51,7 +51,7 @@ echo "All done."
echo "Checking to see whether prerequisite tools are installed..."
cd $src/../check
-./chk install
+sh chk install
echo "All done."
exit 0
diff -r c2daf20cf860 -r bcd7b8ee7e99 tools/check/Makefile
--- a/tools/check/Makefile
+++ b/tools/check/Makefile
@@ -7,13 +7,13 @@ all install: check-build
# Check this machine is OK for building on.
.PHONY: check-build
check-build:
- PYTHON=$(PYTHON) LIBXENAPI_BINDINGS=$(LIBXENAPI_BINDINGS) ./chk build
+ PYTHON=$(PYTHON) LIBXENAPI_BINDINGS=$(LIBXENAPI_BINDINGS) $(SHELL) chk build
# Check this machine is OK for installing on.
.PHONY: check-install
check-install:
- PYTHON=$(PYTHON) LIBXENAPI_BINDINGS=$(LIBXENAPI_BINDINGS) ./chk install
+ PYTHON=$(PYTHON) LIBXENAPI_BINDINGS=$(LIBXENAPI_BINDINGS) $(SHELL) chk install
.PHONY: clean
clean:
- ./chk clean
+ $(SHELL) chk clean
diff -r c2daf20cf860 -r bcd7b8ee7e99 tools/check/README
--- a/tools/check/README
+++ b/tools/check/README
@@ -1,11 +1,11 @@
Checks for the suitability of a machine for Xen build or install.
To check for build suitability use
- ./chk build
+ sh chk build
To check for install suitability use
- ./chk install
+ sh chk install
The chk script will run checks in this directory and print
the ones that failed. It prints nothing if checks succeed.
@@ -17,4 +17,4 @@ are run for the build check, and files c
are run for the install check.
Detailed output from the check scripts is in .chkbuild for build
-and .chkinstall for install.
\ No newline at end of file
+and .chkinstall for install.
diff -r c2daf20cf860 -r bcd7b8ee7e99 tools/check/chk
--- a/tools/check/chk
+++ b/tools/check/chk
@@ -53,7 +53,7 @@ for f in check_* ; do
continue
fi
echo -n "Checking $f: "
- if ./$f 2>&1 ; then
+ if sh $f 2>&1 ; then
echo OK
else
failed=1
next prev parent reply other threads:[~2011-10-04 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 14:21 [PATCH 0 of 7] tools/check fixes for xen-unstable Olaf Hering
2011-10-04 14:21 ` [PATCH 1 of 7] tools/check: remove check_logging Olaf Hering
2011-10-04 14:21 ` Olaf Hering [this message]
2011-10-04 14:21 ` [PATCH 3 of 7] tools/check: update python version check Olaf Hering
2011-10-07 13:34 ` [PATCH 1 of 7] tools/check: remove check_logging [and 1 more messages] Ian Jackson
2011-10-04 14:21 ` [PATCH 4 of 7] tools: call xen-setup with shell Olaf Hering
2011-10-04 14:21 ` [PATCH 5 of 7] tools: call cross-install " Olaf Hering
2011-10-04 14:21 ` [PATCH 6 of 7] tools: call install-wrap " Olaf Hering
2011-10-04 14:21 ` [PATCH 7 of 7] tools: call etherboot/mkhex " Olaf Hering
2011-10-07 13:48 ` [PATCH 0 of 7] tools/check fixes for xen-unstable Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcd7b8ee7e99dc6348c3.1317738111@probook.site \
--to=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.