From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:907:76f8:b0:9a1:fa4e:495e with SMTP id kg24csp3660066ejc; Tue, 29 Aug 2023 06:22:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+rrmOQCRomk9rrR/K6uUMPK6bm1cJWTGn114ae5W1BZyjLE2ryQ7d5m9pri3tnJbtgBek X-Received: by 2002:a05:622a:1a97:b0:410:acd5:a000 with SMTP id s23-20020a05622a1a9700b00410acd5a000mr25118833qtc.21.1693315336099; Tue, 29 Aug 2023 06:22:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693315336; cv=none; d=google.com; s=arc-20160816; b=g85t0uHwPvEbuCXIYuYxyWPnrhtx8+7ZLw9H/swYvE2/uA6UZ9CNny1BufcdtHIGDd ihTTD+SUB2Oms+AAv3UYKAtAdnIZ1TlEiAe4v9u6wiwPBCXJRJfFOQSW2iWMhaTalfs4 /T1T41wn66tf1nai+s1NHuoG2FgYrP+3dX1Sy/Y/fF+OT2CKJvLlVDs20LM6SKdjQPOV etVrM5vjD3i2yTKWRMkJWc3+k92oaAIidP4TuHQ7h4PgPoHderGat4z2F+6IJWxrqLtE 0A/n7eY3tWpho+yU3vCLtaTXYh6jj/TvEAagkzDG1W9WQphA7GBlucc/fQoa4wmOoZio rUZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=if/UmBRbHks8AhQkajFRWvHYh/7FmeO9jsi7m060SvI=; fh=HXFIYFUTPsIGoWOOaxJIIObVrQwOW75f30cUG330MvM=; b=LCibYzMJepYoxUd/GNGmr8hylEtfhfuGUKV8r/ToICG1VylU834x1cp25n9u1Nhh9n BwmUqYWo27js10QIsTMvzC1M2xbm/wiivyjzbHloEgXfsafUuJ/yf7v6z08MsnrWXGTj HVCioYkMjIrkEqGKoVeACDS08NAhvxdnlSa14YR8S6sl1I7Ge1KpUyvXRbt1/ZfjqB0R Zc87lcdHSI5hDOg4YumBAp8U+U9I8BtETDaR//Ra6j+7LV0BozV7SaJzg2+9VzEA3BDn B0Gu07f3vFYywP++0NKVEKITuXInlsssQbNOy66lrfT6yiT+cVOMT9Iz9XR7GYL7wSKJ 3xmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="fFdpa3+/"; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z9-20020a05622a060900b0040fddae7b20si6295153qta.663.2023.08.29.06.22.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Aug 2023 06:22:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="fFdpa3+/"; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qayfR-0004Iv-A4; Tue, 29 Aug 2023 09:22:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qayfO-0004H8-An; Tue, 29 Aug 2023 09:21:58 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qayfL-0003KX-F5; Tue, 29 Aug 2023 09:21:57 -0400 Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37TD6wQZ024159; Tue, 29 Aug 2023 13:21:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=if/UmBRbHks8AhQkajFRWvHYh/7FmeO9jsi7m060SvI=; b=fFdpa3+/OdaWJaYU4ScPrdtMqV/htABG9ii9564kIRj++Q5jeSzC+nlUFOwvp9/6+59l 29aYdHZrZ+6vMgmdZDjHGQ/f6yJ+wakn4p1d07YSmO9AkeyGr6xhrQiccPKaWTZOS4Dh FADjAB/gMxKOR5YHqdbq50gLH5J0pnluJGm53pToPckxa7PbYrnbCXQafb6TkBSZFA24 GjEHif3sv+KegHb9jy7HXvFd8RxfamBTQcpYAvY3OICkXBrvjGdJ1r9nHZMDeZWinbhY 8NaSwYdLz/ZMuc7h8eWujCeqH4vuf0yl2RTjXO7bkJtwm2aW7tlsM8MEf1AS/rfjHtss kw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sr7vywgy3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Aug 2023 13:21:36 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 37TDFjwN008005; Tue, 29 Aug 2023 13:21:36 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sr7vywgxh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Aug 2023 13:21:36 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 37TBwIge020514; Tue, 29 Aug 2023 13:21:34 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3sqv3ybu3y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Aug 2023 13:21:34 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 37TDLYAv4850210 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Aug 2023 13:21:34 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 01BA65805C; Tue, 29 Aug 2023 13:21:34 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8E59C58051; Tue, 29 Aug 2023 13:21:33 +0000 (GMT) Received: from [9.61.30.201] (unknown [9.61.30.201]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 29 Aug 2023 13:21:33 +0000 (GMT) Message-ID: Date: Tue, 29 Aug 2023 08:21:33 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/7] hw/fsi: Introduce IBM's scratchpad Content-Language: en-US To: Thomas Huth , qemu-devel@nongnu.org, clg@kaod.org, peter.maydell@linaro.org, andrew@aj.id.au, joel@jms.id.au, pbonzini@redhat.com, marcandre.lureau@redhat.com, berrange@redhat.com, philmd@linaro.org Cc: qemu-arm@nongnu.org References: <20230825203046.3692467-1-ninad@linux.ibm.com> <20230825203046.3692467-3-ninad@linux.ibm.com> <6d153709-8099-7737-8fbd-3988a35af71a@redhat.com> From: Ninad Palsule In-Reply-To: <6d153709-8099-7737-8fbd-3988a35af71a@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: C1adgvMOD0_mAp78b_n-0d65gA-G7bTJ X-Proofpoint-GUID: b0adT_c0eyEuzCrzSqPoUbSX-j8mIvDn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-29_10,2023-08-29_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=576 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2308290113 Received-SPF: pass client-ip=148.163.156.1; envelope-from=ninad@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: EyqzYQ67PKoK Hello Thomas, On 8/28/23 20:52, Thomas Huth wrote: > On 25/08/2023 22.30, Ninad Palsule wrote: >> This is a part of patchset where IBM's Flexible Service Interface is >> introduced. >> >> The LBUS device is embeded inside the scratchpad. The scratchpad >> provides a non-functional registers. There is a 1-1 relation between >> scratchpad and LBUS devices. Each LBUS device has 1K memory mapped in >> the LBUS. >> >> Signed-off-by: Andrew Jeffery >> Signed-off-by: Cédric Le Goater >> Signed-off-by: Ninad Palsule >> --- >>   hw/fsi/Kconfig                     |   4 ++ >>   hw/fsi/engine-scratchpad.c         | 100 +++++++++++++++++++++++++++++ >>   hw/fsi/meson.build                 |   1 + >>   include/hw/fsi/engine-scratchpad.h |  32 +++++++++ >>   4 files changed, 137 insertions(+) >>   create mode 100644 hw/fsi/engine-scratchpad.c >>   create mode 100644 include/hw/fsi/engine-scratchpad.h >> >> diff --git a/hw/fsi/Kconfig b/hw/fsi/Kconfig >> index 687449e14e..2a9c49f2c9 100644 >> --- a/hw/fsi/Kconfig >> +++ b/hw/fsi/Kconfig >> @@ -1,2 +1,6 @@ >> +config SCRATCHPAD >> +    bool >> +    select LBUS >> + >>   config LBUS >>       bool > > The config names sound pretty generic ... could you maybe name them > FSI_SCRATCHPAD and FSI_LBUS instead? OK, I fixed it by adding the FSI prefix. Thank you for the review. Ninad > >  Thomas > >