All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>, Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Madalin Bucur <madalin.bucur@nxp.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Timur Tabi <timur@kernel.org>,
	Networking <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] net: freescale: select CONFIG_FIXED_PHY where needed
Date: Sat, 9 May 2020 15:04:04 -0700	[thread overview]
Message-ID: <bce24dff-5287-76e2-ba85-8d31d7e673f8@gmail.com> (raw)
In-Reply-To: <CAK8P3a0figw8FHGp2KqW6XdfbWLu_ZXp3hyuPVoPwpum6XeJ_Q@mail.gmail.com>



On 5/9/2020 2:48 PM, Arnd Bergmann wrote:
> On Sat, May 9, 2020 at 10:24 PM Jakub Kicinski <kuba@kernel.org> wrote:
>>
>> On Sat,  9 May 2020 14:04:52 +0200 Arnd Bergmann wrote:
>>> I ran into a randconfig build failure with CONFIG_FIXED_PHY=m
>>> and CONFIG_GIANFAR=y:
>>>
>>> x86_64-linux-ld: drivers/net/ethernet/freescale/gianfar.o:(.rodata+0x418): undefined reference to `fixed_phy_change_carrier'
>>>
>>> It seems the same thing can happen with dpaa and ucc_geth, so change
>>> all three to do an explicit 'select FIXED_PHY'.
>>>
>>> The fixed-phy driver actually has an alternative stub function that
>>> theoretically allows building network drivers when fixed-phy is
>>> disabled, but I don't see how that would help here, as the drivers
>>> presumably would not work then.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>>> +     select FIXED_PHY
>>
>> I think FIXED_PHY needs to be optional, depends on what the board has
>> connected to the MAC it may not be needed, right PHY folks? We probably
>> need the
>>
>>     depends on FIXED_PHY || !FIXED_PHY
> 
> Unfortunately that does not work because it causes a circular dependency:
> 
> drivers/net/phy/Kconfig:415:error: recursive dependency detected!
> drivers/net/phy/Kconfig:415: symbol FIXED_PHY depends on PHYLIB
> drivers/net/phy/Kconfig:250: symbol PHYLIB is selected by FSL_PQ_MDIO
> drivers/net/ethernet/freescale/Kconfig:60: symbol FSL_PQ_MDIO is
> selected by UCC_GETH
> drivers/net/ethernet/freescale/Kconfig:75: symbol UCC_GETH depends on FIXED_PHY
> 
> I now checked what other drivers use the fixed-phy interface, and found
> that all others do select FIXED_PHY except for these three, and they
> are also the only ones using fixed_phy_change_carrier().
> 
> The fixed-phy driver is fairly small, so it probably won't harm too much
> to use the select, but maybe I missed another option.

select FIXED_PHY appears the correct choice here we could think about
providing stubs if that is deemed useful, but in general these drivers
do tend to have a functional dependency on the fixed PHY and MDIO bus
subsystems.

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

  reply	other threads:[~2020-05-09 22:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 12:04 [PATCH] net: freescale: select CONFIG_FIXED_PHY where needed Arnd Bergmann
2020-05-09 20:24 ` Jakub Kicinski
2020-05-09 21:48   ` Arnd Bergmann
2020-05-09 22:04     ` Florian Fainelli [this message]
2020-05-09 22:52       ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bce24dff-5287-76e2-ba85-8d31d7e673f8@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=madalin.bucur@nxp.com \
    --cc=netdev@vger.kernel.org \
    --cc=timur@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.