From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19AF23AE6F7;
	Mon, 15 Jun 2026 20:38:56 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1781555936; cv=none; b=MP5kcUGUKOg2rNreeFHVapU/nSxy8AoEpLD8Y8h4RGALmnzgKT1iWuBCMsaAPYh4NYYsdUwXEYvQo3lw8gsfL5huUrDJrJwgZA4CpEvvxeXAa25Ypr3x9C17RecWQe9dwVJzunUy5FLFuu/Cz/evkzFccfWOYbbKleUMFp0sX9w=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1781555936; c=relaxed/simple;
	bh=9efHCy9u9lkxqey6rm+NLvlIWq9xOAh4xTRHJ8RpoGw=;
	h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References:
	 MIME-Version:Content-Type; b=EA4Mks5g0LcJlj9Yd3L9b2m+/FE3CwTjToxvrdulxG1rXKzFOzAaNow22rx3659QDWo91rrTTH0f9wgC1S0/VIwzsxmwxbnTI8U3Oo6wiPIxHqW1SGvG0qdITBXepI1+26CEudSiTTlET6YehWZ3gcDJKvWB74VUeUnOf/PvUgU=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ihGdw57i; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ihGdw57i"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7D701F00A3A;
	Mon, 15 Jun 2026 20:38:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1781555935;
	bh=G0Zxb6wcybl1wg/ZQjQgD0PpsW9ICU1qTTRzoJ2k1NI=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References;
	b=ihGdw57iqm+UWZ7hnU6AagPDSjuDFkvEUBj5ROsHKHTCGEb787VhKzODodoJNqFhh
	 W88sTaSed9EnNwOY5REupPsqPaXJCwOU0nOE1PnUyr3GgBgJJJe/PIzcAWzdr8aFMT
	 9bfqaRfT61FAJ8ZQtpaiLteM+eSXfMA4/MAEYEyvZNQmA77B/LwRi3DofGWMxkI9vu
	 Z8yO9tX6qwpgR2yoZHp8GL/FUo6upYSYfJnSCczO2rVkF53X6YZTjAdIvMix6+uoda
	 XuBIsQ/xS7h3hF7gFYiyQnEPl724TH+phSJ34fOvsYHJhyVBgft/EgXV3WKo7vToPa
	 H6ZS5nb1Fgeyw==
Date: Mon, 15 Jun 2026 10:38:54 -1000
Message-ID: <bcedd13fc22cb7ba590791a4c1387ecc@kernel.org>
From: Tejun Heo <tj@kernel.org>
To: Yuri Andriaccio <yurand2000@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>,
	Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	=?UTF-8?q?Michal=20Koutn=C3=BD?= <mkoutny@suse.com>
Cc: cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Luca Abeni <luca.abeni@santannapisa.it>,
	Yuri Andriaccio <yuri.andriaccio@santannapisa.it>
Subject: Re: [RFC PATCH v6 00/25] Hierarchical Constant Bandwidth Server
In-Reply-To: <20260608121546.69910-1-yurand2000@gmail.com>
References: <20260608121546.69910-1-yurand2000@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Hello,

Looks great. Two things:

1. cpu.rt.internal doesn't follow the naming convention. The file is the
   cgroup's own budget (cpu.rt.max minus its children), so
   cpu.rt.max.effective.local fits better: .effective like
   cpuset.cpus.effective, .local like memory.events.local.

2. root's cpu.rt.max: sched_rt_runtime_us already caps total DL/RT
   bandwidth and rt-cgroups admit against the same pool, so what does
   reserving the cgroup share separately at root add? It's also a writable
   control on root, which we otherwise keep off root.

Thanks.

--
tejun