From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 609F7431E4E for ; Wed, 1 Jul 2026 22:00:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782943258; cv=none; b=o+hSz2JRFS3hetwIkmeCti2PxJpfzwMDYGLECxDbhjGDh12kAn00kz53iblxt1/83tGd95uWMz1lyFY8lySBMx5vzKz2MIae978gY9cJHzsrDEDgKKwmHd7Vx8zbpyM+NlPp7/DT0VnFTomgnie1sG0Xf91InHs1WETNK5y7lnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782943258; c=relaxed/simple; bh=sG4mtD8QL8va/jrw7afOHbjZkvlJMm2jyGZSXaLD7Mo=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=SE4KoI+Pd2LRMz6flzqlquyLvl2O7vRHOpgUkYQEDyHhqxgd+k6itGg3e/l0x/pdK7TmUpcGgZT1cq0nzu1jPZ8YkyG8XStjTdKl2H2Dw+oOes7/ZAwCI/mBXZgRt1AGREZij5spPo1Wg88vu1RCYjjvFpa+diIP2CO/qChRy9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=clzouy0B; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="clzouy0B" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:Message-ID:References: In-Reply-To:Subject:Cc:To:From:Date:MIME-Version:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yaM2/r0nQ+KZa9DjbHwZn8AL8mGnTAI+bvsmHq0U8OI=; b=clzouy0BybVRLPyaWMiEL3ApQu zHIDnxBF5w2LC4HvrX+1geUmrI7pjYHSvksAIMFK2Mpy7+KcLOOlGutwh9F1oYiZNK9LqLopJFSUs gA6bjZoG4CsxeUYgSDVjPc7kwjqOekrEOt2PdmRHsaxjkUBZC32DTzWWxqX1scQ0XFceBVbioCZOq ycJ6ulD9ANZoBAP2Y5mhqopisw2s9RCV3DpH125RteFJV/HPHI7QAY/CP4sZ8Ci2tRuPWkywuY2NM gzkHc3Z6J+o+5cLkay+hqY9n0PhinyfJXycC2Eey4hBM7iBzFWit2DsHrHs1z9lQ7Bgucaa+qRk2f lYDUhF3w==; Received: from maestria.local.igalia.com ([192.168.10.14] helo=mail.igalia.com) by fanzine2.igalia.com with esmtps (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wf2yt-007ljZ-Ns; Thu, 02 Jul 2026 00:00:31 +0200 Received: from webmail.service.igalia.com ([192.168.21.45]) by mail.igalia.com with esmtp (Exim) id 1wf2yr-008Wju-Lr; Thu, 02 Jul 2026 00:00:31 +0200 Received: from localhost ([127.0.0.1] helo=webmail.igalia.com) by webmail.service.igalia.com with esmtp (Exim 4.98.2) (envelope-from ) id 1wf2yr-0000000DsjJ-1ury; Thu, 02 Jul 2026 00:00:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 01 Jul 2026 19:00:29 -0300 From: Mauricio Faria de Oliveira To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Alexey Dobriyan , Boris Ostrovsky , kernel-dev@igalia.com, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH RESEND v5 1/3] x86/asm, x86/boot: expose inline memcmp In-Reply-To: <20260701204640.GDakV8sOK1cu-0P4Bc@fat_crate.local> References: <20260630-pvh-kasan-inline-v5-0-52afc979be81@igalia.com> <20260630-pvh-kasan-inline-v5-1-52afc979be81@igalia.com> <20260701184014.GDakVfDhIgaIKurzTb@fat_crate.local> <20260701204640.GDakV8sOK1cu-0P4Bc@fat_crate.local> Message-ID: X-Sender: mfo@igalia.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Report: NO, Score=-4.7, Tests=ALL_TRUSTED=-3,AWL=-2.549,BAYES_50=0.8 X-Spam-Score: -46 X-Spam-Bar: ---- On 2026-07-01 17:46, Borislav Petkov wrote: > On Wed, Jul 01, 2026 at 04:57:57PM -0300, Mauricio Faria de Oliveira wrote: >> I'm not sure, as Reported-by and Suggested-by mean something different. >> >> Maybe a simpler statement would do? e.g., '(Thanks to David Laight for >> noticing the return value difference between inline and regular >> memcmp())'. That gives credit while avoiding confusion with tags. > > The Link tag already points to the review thread where we document who > suggested what. We don't document who gave what review comments and > suggestions for the simple reason that that would be intractable and the other > simple reason is that they don't belong in the commit message. > > Changelog comments belong *exactly* under the "---" line. Ok, I'll send v6 addressing your feedback. Thanks. -- Mauricio