All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Richard Zak <richard.j.zak@gmail.com>,
	Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable
Date: Mon, 5 Jul 2021 18:58:16 +0200	[thread overview]
Message-ID: <bd20ba33-796c-e541-8c9b-2fc6e45b2cfe@redhat.com> (raw)
In-Reply-To: <20210705082542.936856-1-thuth@redhat.com>

On 05/07/21 10:25, Thomas Huth wrote:
> The wrapper should not be needed here (it's not the shebang line of
> a shell script), and it is causing trouble on Haiku where "env"
> resides in a different directory.
> 
> Reported-by: Richard Zak <richard.j.zak@gmail.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 30f19d33bb..6c36330eef 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -14,7 +14,7 @@ SRC_PATH=.
>   # we have explicit rules for everything
>   MAKEFLAGS += -rR
>   
> -SHELL = /usr/bin/env bash -o pipefail
> +SHELL = bash -o pipefail
>   
>   # Usage: $(call quiet-command,command and args,"NAME","args to print")
>   # This will run "command and args", and either:
> 

Queued, thanks.

Paolo



      parent reply	other threads:[~2021-07-05 16:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05  8:25 [PATCH] Makefile: Remove /usr/bin/env wrapper from the SHELL variable Thomas Huth
2021-07-05  8:35 ` Daniel P. Berrangé
2021-07-05  8:35   ` Daniel P. Berrangé
2021-07-05  8:46 ` Philippe Mathieu-Daudé
2021-07-05 16:58 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd20ba33-796c-e541-8c9b-2fc6e45b2cfe@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.j.zak@gmail.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.