RE: [PATCH V3 0/3] cmd: env: select: Add output for available environment targets

[Christoph Niedermaier <cniedermaier@dh-electronics.com>]

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Sent: Monday, May 12, 2025 10:38 AM
> On Mon, May 12, 2025 at 08:22:19AM +0000, Christoph Niedermaier wrote:
>> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Sent: Monday, May 12, 2025 9:38 AM
>>> On Fri, May 09, 2025 at 09:00:40PM +0200, Christoph Niedermaier wrote:
>>>> Add the "-l" parameter to the "env select" command to print the available
>>>> environment targets, convert all argument parsing in the file nvedit.c to
>>>> getopt() and check that with unit tests.
>>>>
>>>> The first patch converts the parsing of arguments to getopt() for all env
>>>> commands. The second one adds unit tests for checking the env command.
>>>> These were used to check the env commands before and after the conversion.
>>>> The third patch adds the actual new parameter "-l" for the "env select"
>>>> command.
>>>
>>> What is the binary size increase with this change, please?
>>
>> I don't know exactly which binary size I should look at?
>> I have looked at the object file of nvedit.c:
>>
>> I built it with the config dh_imx6_defconfig.
>>
>> Before my patches:
>> $ ls -la cmd/nvedit.o
>> -rw-r--r-- 1 developer developer 57644 May 12 10:03 cmd/nvedit.o
>>
>> After my patches:
>> $ ls -la cmd/nvedit.o
>> -rw-r--r-- 1 developer developer 59292 May 12 10:06 cmd/nvedit.o
>>
>> So the increase is 1648 Bytes (+2.86%).
> 
> U-Boot binary. And better to use bloat-o-meter script for that, it shows the
> breakdown in more precise terms.

With bloat-o-meter it looks like this (before and after my patches):

./bloat-o-meter -p arm-linux-gnueabihf- u-boot_before u-boot_after
add/remove: 5/1 grow/shrink: 4/2 up/down: 1152/-652 (500)
Function                                     old     new   delta
bdinfo_print_all                               -     404    +404
__getopt.constprop                             -     292    +292
substitute                                     -     156    +156
print_eth                                      -     124    +124
print_bi_dram                                  -      72     +72
do_env_default                               116     152     +36
do_env_import                                424     456     +32
do_env_print                                 740     764     +24
do_env_delete                                 92     104     +12
do_env_export                                336     328      -8
substitute.lto_priv                          156       -    -156
do_bdinfo                                    580      92    -488
Total: Before=501681, After=502181, chg +0.10%


Regards
Christoph