From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915/execlists: Skip forcewake for ELSP submission Date: Mon, 22 Jan 2018 16:59:21 +0000 Message-ID: References: <01f1b08d-4cab-d611-6b68-50e1bf4ea45a@linux.intel.com> <20180122100714.15137-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 84F706E254 for ; Mon, 22 Jan 2018 16:59:23 +0000 (UTC) In-Reply-To: <20180122100714.15137-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIyLzAxLzIwMTggMTA6MDcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBOb3cgdGhhdCB3ZSBj YW4gcmVhZCB0aGUgQ1NCIGZyb20gdGhlIEhXU1AsIHdlIG1heSBhdm9pZCBoYXZpbmcgdG8KPiBw ZXJmb3JtIG1taW8gcmVhZHMgZW50aXJlbHkgYW5kIHNvIGZvcmdvIHRoZSByaWdtYXJvbGUgb2Yg dGhlIGZvcmNld2FrZQo+IGRhbmNlLgo+IAo+IHYyOiBJbmNsdWRlIGZvcmNld2FrZSBoaW50IGZv ciBHRU1fVFJBQ0UgcmVhZGJhY2sgb2YgbW1pby4gSWYgd2UgZG9uJ3QKPiBob2xkIGZ3IG91cnNl bHZlcywgdGhlIHJlYWRzIG1heSByZXR1cm4gZ2FyYmFnZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3Vs aW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2xyYy5jIHwgMTggKysrKysrKysrKysrLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdl ZCwgMTIgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9scmMuYwo+IGluZGV4IGZmMjVmMjA5ZDBhNS4uMDc1ZTdmNTZlOWJhIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtNzc4LDYgKzc3OCw3IEBAIHN0YXRpYyB2b2lkIGV4ZWNs aXN0c19zdWJtaXNzaW9uX3Rhc2tsZXQodW5zaWduZWQgbG9uZyBkYXRhKQo+ICAgCXN0cnVjdCBp bnRlbF9lbmdpbmVfZXhlY2xpc3RzICogY29uc3QgZXhlY2xpc3RzID0gJmVuZ2luZS0+ZXhlY2xp c3RzOwo+ICAgCXN0cnVjdCBleGVjbGlzdF9wb3J0ICogY29uc3QgcG9ydCA9IGV4ZWNsaXN0cy0+ cG9ydDsKPiAgIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBlbmdpbmUtPmk5 MTU7Cj4gKwlib29sIGZ3ID0gZmFsc2U7Cj4gICAKPiAgIAkvKiBXZSBjYW4gc2tpcCBhY3F1aXJp bmcgaW50ZWxfcnVudGltZV9wbV9nZXQoKSBoZXJlIGFzIGl0IHdhcyB0YWtlbgo+ICAgCSAqIG9u IG91ciBiZWhhbGYgYnkgdGhlIHJlcXVlc3QgKHNlZSBpOTE1X2dlbV9tYXJrX2J1c3koKSkgYW5k IGl0IHdpbGwKPiBAQCAtNzg4LDggKzc4OSw2IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19zdWJt aXNzaW9uX3Rhc2tsZXQodW5zaWduZWQgbG9uZyBkYXRhKQo+ICAgCSAqLwo+ICAgCUdFTV9CVUdf T04oIWRldl9wcml2LT5ndC5hd2FrZSk7Cj4gICAKPiAtCWludGVsX3VuY29yZV9mb3JjZXdha2Vf Z2V0KGRldl9wcml2LCBleGVjbGlzdHMtPmZ3X2RvbWFpbnMpOwo+IC0KPiAgIAkvKiBQcmVmZXIg ZG9pbmcgdGVzdF9hbmRfY2xlYXJfYml0KCkgYXMgYSB0d28gc3RhZ2Ugb3BlcmF0aW9uIHRvIGF2 b2lkCj4gICAJICogaW1wb3NpbmcgdGhlIGNvc3Qgb2YgYSBsb2NrZWQgYXRvbWljIHRyYW5zYWN0 aW9uIHdoZW4gc3VibWl0dGluZyBhCj4gICAJICogbmV3IHJlcXVlc3QgKG91dHNpZGUgb2YgdGhl IGNvbnRleHQtc3dpdGNoIGludGVycnVwdCkuCj4gQEAgLTgxOCw2ICs4MTcsMTIgQEAgc3RhdGlj IHZvaWQgZXhlY2xpc3RzX3N1Ym1pc3Npb25fdGFza2xldCh1bnNpZ25lZCBsb25nIGRhdGEpCj4g ICAJCSAqLwo+ICAgCQlfX2NsZWFyX2JpdChFTkdJTkVfSVJRX0VYRUNMSVNULCAmZW5naW5lLT5p cnFfcG9zdGVkKTsKPiAgIAkJaWYgKHVubGlrZWx5KGV4ZWNsaXN0cy0+Y3NiX2hlYWQgPT0gLTEp KSB7IC8qIGZvbGxvd2luZyBhIHJlc2V0ICovCj4gKwkJCWlmICghZncpIHsKPiArCQkJCWludGVs X3VuY29yZV9mb3JjZXdha2VfZ2V0KGRldl9wcml2LAo+ICsJCQkJCQkJICAgZXhlY2xpc3RzLT5m d19kb21haW5zKTsKPiArCQkJCWZ3ID0gdHJ1ZTsKPiArCQkJfQo+ICsKPiAgIAkJCWhlYWQgPSBy ZWFkbChkZXZfcHJpdi0+cmVncyArIGk5MTVfbW1pb19yZWdfb2Zmc2V0KFJJTkdfQ09OVEVYVF9T VEFUVVNfUFRSKGVuZ2luZSkpKTsKPiAgIAkJCXRhaWwgPSBHRU44X0NTQl9XUklURV9QVFIoaGVh ZCk7Cj4gICAJCQloZWFkID0gR0VOOF9DU0JfUkVBRF9QVFIoaGVhZCk7Cj4gQEAgLTgzMCwxMCAr ODM1LDEwIEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19zdWJtaXNzaW9uX3Rhc2tsZXQodW5zaWdu ZWQgbG9uZyBkYXRhKQo+ICAgCQkJaGVhZCA9IGV4ZWNsaXN0cy0+Y3NiX2hlYWQ7Cj4gICAJCQl0 YWlsID0gUkVBRF9PTkNFKGJ1Zlt3cml0ZV9pZHhdKTsKPiAgIAkJfQo+IC0JCUdFTV9UUkFDRSgi JXMgY3MtaXJxIGhlYWQ9JWQgWyVkXSwgdGFpbD0lZCBbJWRdXG4iLAo+ICsJCUdFTV9UUkFDRSgi JXMgY3MtaXJxIGhlYWQ9JWQgWyVkJXNdLCB0YWlsPSVkIFslZCVzXVxuIiwKPiAgIAkJCSAgZW5n aW5lLT5uYW1lLAo+IC0JCQkgIGhlYWQsIEdFTjhfQ1NCX1JFQURfUFRSKHJlYWRsKGRldl9wcml2 LT5yZWdzICsgaTkxNV9tbWlvX3JlZ19vZmZzZXQoUklOR19DT05URVhUX1NUQVRVU19QVFIoZW5n aW5lKSkpKSwKPiAtCQkJICB0YWlsLCBHRU44X0NTQl9XUklURV9QVFIocmVhZGwoZGV2X3ByaXYt PnJlZ3MgKyBpOTE1X21taW9fcmVnX29mZnNldChSSU5HX0NPTlRFWFRfU1RBVFVTX1BUUihlbmdp bmUpKSkpKTsKPiArCQkJICBoZWFkLCBHRU44X0NTQl9SRUFEX1BUUihyZWFkbChkZXZfcHJpdi0+ cmVncyArIGk5MTVfbW1pb19yZWdfb2Zmc2V0KFJJTkdfQ09OVEVYVF9TVEFUVVNfUFRSKGVuZ2lu ZSkpKSksIGZ3ID8gIiIgOiAiPyIsCj4gKwkJCSAgdGFpbCwgR0VOOF9DU0JfV1JJVEVfUFRSKHJl YWRsKGRldl9wcml2LT5yZWdzICsgaTkxNV9tbWlvX3JlZ19vZmZzZXQoUklOR19DT05URVhUX1NU QVRVU19QVFIoZW5naW5lKSkpKSwgZncgPyAiIiA6ICI/Iik7CgpOb3QgdXNlZnVsIHRvIGxvZyB0 aGUgY29ycmVjdCB2YWx1ZSBpbiBhbnkgY2FzZT8gT3IgaW4gb3RoZXIgd29yZHMsIHRoaXMgCnRy YWNlIGlzIG5vdCB1c2VmdWwgZm9yIGRlYnVnZ2luZyBwb3RlbnRpYWwgcHJvYmxlbXMgd2l0aCB0 aGUgSFdTUCBDU0IgCmNvcHksIHdoaWxlIHdpdGggdGhpcyBjaGFuZ2UgaXQgc3RvcHMgYmVpbmcg c28/Cgo+ICAgCj4gICAJCXdoaWxlIChoZWFkICE9IHRhaWwpIHsKPiAgIAkJCXN0cnVjdCBkcm1f aTkxNV9nZW1fcmVxdWVzdCAqcnE7Cj4gQEAgLTk0Myw3ICs5NDgsOCBAQCBzdGF0aWMgdm9pZCBl eGVjbGlzdHNfc3VibWlzc2lvbl90YXNrbGV0KHVuc2lnbmVkIGxvbmcgZGF0YSkKClRoZXJlIGlz IGEgd3JpdGVsIGEgYml0IGFib3ZlIHdoaWNoIG5vdyBoYXMgbm8gZncgaW4gSFdTUCBtb2RlLgoK PiAgIAlpZiAoIWV4ZWNsaXN0c19pc19hY3RpdmUoZXhlY2xpc3RzLCBFWEVDTElTVFNfQUNUSVZF X1BSRUVNUFQpKQo+ICAgCQlleGVjbGlzdHNfZGVxdWV1ZShlbmdpbmUpOyA+IC0JaW50ZWxfdW5j b3JlX2ZvcmNld2FrZV9wdXQoZGV2X3ByaXYsIGV4ZWNsaXN0cy0+ZndfZG9tYWlucyk7Cj4gKwlp ZiAoZncpCj4gKwkJaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9wdXQoZGV2X3ByaXYsIGV4ZWNsaXN0 cy0+ZndfZG9tYWlucyk7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyB2b2lkIGluc2VydF9yZXF1ZXN0 KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==