Re: [Qemu-devel] [Qemu-block] [PATCH] block/vvfat: Disable debug message by default

[John Snow <jsnow@redhat.com>]

On 07/18/2018 11:08 AM, Thomas Huth wrote:
> It's annoying to see this debug message every time you use vvfat.
> Disable it with the DLOG() macro by default, as it is done with the
> other debug messages in this file.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  block/vvfat.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/vvfat.c b/block/vvfat.c
> index c7d2ed2..fc41841 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -1245,8 +1245,8 @@ static int vvfat_open(BlockDriverState *bs, QDict *options, int flags,
>      s->fat2 = NULL;
>      s->downcase_short_names = 1;
>  
> -    fprintf(stderr, "vvfat %s chs %d,%d,%d\n",
> -            dirname, cyls, heads, secs);
> +    DLOG(fprintf(stderr, "vvfat %s chs %d,%d,%d\n",
> +                 dirname, cyls, heads, secs));
>  
>      s->sector_count = cyls * heads * secs - s->offset_to_bootsector;
>  
> 

Makes sense as a minimal change without doing more... real work here.

Reviewed-by: John Snow <jsnow@redhat.com>