From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA36AC4360F for ; Wed, 27 Mar 2019 18:45:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB42A21734 for ; Wed, 27 Mar 2019 18:45:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IffZWPPR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391726AbfC0Spa (ORCPT ); Wed, 27 Mar 2019 14:45:30 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35350 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391207AbfC0Sp3 (ORCPT ); Wed, 27 Mar 2019 14:45:29 -0400 Received: by mail-wr1-f66.google.com with SMTP id w1so19879020wrp.2 for ; Wed, 27 Mar 2019 11:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=c24Ualj41tFR9AFscacOSNt/rRt/QNb0k/lBLxdzb+U=; b=IffZWPPR7v1h2yY48N4VBgXgbkwpa4F00eW31q+5u802uBqfuUiTukNBqi0B7nYLL4 KLp4qAK7Jl1SNVVVVDwPeUVPtmDTKfxx3k/oc43504txBcoonjYLMwatBLBQmTANNtLa dM5ZrZ+ZJaFzZbuIjdoompnobIF+j9Upn5PMbXKFn3pdKcvRaHtsV/2MRa1mtWCzxGOc 88Og7Xa36pVzsprm7EVw1fxJrzKIzVZfjLIRN4kvJtwjRucpNMOrNP868Y2TBcq2Uz+y E5Nc5JvfZSnUlsSG5+GXXxlMW4juY2/IR6NawPdYwjRKZG3LogD5DdygMdVp/+mc4KNy 1MRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=c24Ualj41tFR9AFscacOSNt/rRt/QNb0k/lBLxdzb+U=; b=OaRRVamgFCVO/Vvt0PGzj5ZnyOoewarVOmC5ObXRDDnmwVqvZ8wcv+y9Mq+srrW1ep AmP8sp9Lo8mPwLH6XCN0/NDfASspWRzBV4jIHLxgGTlVhuR4ZuOXRyf46Dbu6//AUO80 iAd86TzhJn/wlLzkIix4aRz0pDw9OaulWW64V/TAcT/V4AD8B8ipbUgwWjZSD+N1JiwB a0Sp/k1zWPzx6j6gzvp8zlAZBVwm3WaEAvKQrOF8k7Qp7vF8239g+vhKLruOinLo9BdD bdspDErIL1oJ7yLe1XBi6qhoRLEWQtH60Vj7FSzBzkWu5xPzHmH+izMQGefFa83mPuVT QACg== X-Gm-Message-State: APjAAAWf9flqfeD4M7V9AdcUpshkZFJW6yLbMvFXJyEB8nqPne4l0EEa oAENDLN9Xx31+n7UNCzYoY7Mcu4g X-Google-Smtp-Source: APXvYqxc6g8QSHQ3tck2dzq5qr9+w1aUPNfG4BSSga/OeBxV0rY/TEnzJjPpyW61UU0gKmZnMdacdA== X-Received: by 2002:a5d:48ca:: with SMTP id p10mr8201939wrs.141.1553712328185; Wed, 27 Mar 2019 11:45:28 -0700 (PDT) Received: from [192.168.43.227] (94.197.120.206.threembb.co.uk. [94.197.120.206]) by smtp.gmail.com with ESMTPSA id 84sm1152933wme.43.2019.03.27.11.45.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 11:45:27 -0700 (PDT) To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, stable@vger.kernel.org From: Malcolm Priestley Subject: [PATCH] staging: vt6655: Remove vif check from vnt_interrupt Message-ID: Date: Wed, 27 Mar 2019 18:45:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org A check for vif is made in vnt_interrupt_work. There is a small chance of leaving interrupt disabled while vif is NULL and the work hasn't been scheduled. Signed-off-by: Malcolm Priestley CC: stable@vger.kernel.org # v4.2+ --- drivers/staging/vt6655/device_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index 83f1a1cf9182..c6bb4aaf9bd0 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -1137,8 +1137,7 @@ static irqreturn_t vnt_interrupt(int irq, void *arg) { struct vnt_private *priv = arg; - if (priv->vif) - schedule_work(&priv->interrupt_work); + schedule_work(&priv->interrupt_work); MACvIntDisable(priv->PortOffset); -- 2.20.1