From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50B353EDE70 for ; Tue, 30 Jun 2026 12:21:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782822105; cv=none; b=I/oEVaSQnapOHxaH8B7QCeMUDtvkUHlkuINnSqS2uK+7eQf7JmQ9LmKQvoUjqgB+WoJRDc2tqfvleDPMKLpIYK5QjLvbNs8rJuDr/GovLYsIZoHwWat/IdvGW2QgLiFvvfHaRosig0azTkV3WDp7XLjqWcYrYndBqxoCLdYoclk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782822105; c=relaxed/simple; bh=ZBhs34ZISK9bRi/rf/JPGKWEECowkqkQOjuTBR4fNCA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Go2L1MUGGYNmVvB7EXIJ2cGgJC0ua+Qu8G8du/bL9uTfIqZy6VX4iZ6JwB7G4RJjdCILFwrxnBeRA4GY2VGgrjjSTg1HAXhXNHWHM3z0osZF+NC8NJ8xlK3Nb0/ZnZdX5cPLXJzZKAR3NkOzS+ocJlXLMXHB/WpgRROgz+LNkoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IQK1lL4o; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ODmWO7k5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IQK1lL4o"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ODmWO7k5" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U9n2XT1602961 for ; Tue, 30 Jun 2026 12:21:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OKA9ni/VKYiyOGZbetdw2GUFM0Wy/xcP3QxXwwJdhrk=; b=IQK1lL4oceipm8Q4 wpDe0abCYCvbADeNXWX3gj3hyHy7jURTho8WgTcNP0wxHt9iM42a5wd1u/4ra8hi slQfbSxApQbzQkn8/8rw/U5Aie8gnKbUeQo73GyfSHmrz/dWJU0L41C2pCOKK+Ux eQKjyqY08FHK7bPN2E46E1JCFGqBqISg00TgsLFx+NiEjiPYYH01FCuafv6/DTcr zI2JXzR4UsSaslUZH89nqjJ+CIcWpYI258CT3uYhXgutcWX1OsKtcX3nMdwRsr1c 6alJGvFylNA96g1H5P+qcJH/bFmFX/4BL4uCgiQv9zSHsVRPKJgbUp3dwNymm30A 1zcuIQ== Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f4avprufd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 12:21:42 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-9692c7b2054so92194241.0 for ; Tue, 30 Jun 2026 05:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782822102; x=1783426902; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OKA9ni/VKYiyOGZbetdw2GUFM0Wy/xcP3QxXwwJdhrk=; b=ODmWO7k5d35aQmY+TNpaXyJPMoIQtPsOLkR4UQCAidVsK+plGEyVZEn7yz2Je7nDcj GNVuaQ7hMovEktvOXFO+twpb/yMkfkBWeRNs4iNSxKv4oyUkQZhTQ9HSJji1Xt7LrfxF ZQvVbitc55+tKdVEPOuoxG+9D7VtcHn+fgtIjFG4qh12fDJA/DUAyWMC0YpngDFIQ7yi ohKaeJNu4qhum9fsXvMiWTG294u9ziGQSUderrF3uiU5AArUWMb4wEvhb4Bnq46jEPLc TLdIMK8xDY3dYPblrYf0TdeMvsNGWSl9RhizjpvY1Y6qylvJFhw7+Y2Uk7PEa/5jj1ZK qk7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782822102; x=1783426902; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OKA9ni/VKYiyOGZbetdw2GUFM0Wy/xcP3QxXwwJdhrk=; b=slpdEGXk6tYoK4NhohPpoYrtB1B3GvEQkOnwtmdKQa3Z0Y0ynG+GTbwQI0gxA/NZ6J kUuD6lldZGgbOtjHHlmo30EIRJPsEKb+13rQRitjU9FdX3C0guoFrr9dn7oTItH3Qx22 aEFviTbV0iKEBl2qwVhcQnwrq5Bv9knUtNcq3bwqxsOVRkc25lK4AlTHuaKMdgZMukZO ISG+ih6lksqXdoUqSO1KA4NaHXFWPntHQLbaS3X0dGEeHNKCGoC8XlEqZAq+9CMKnetz 12ihLBSiO6EZhq811CT4OhKZmC/TIJ2tu0QXB5dYn1FEn0C4a+RPRsw2f2G3/7CBdsMU nEHw== X-Forwarded-Encrypted: i=1; AHgh+Rp065Z/yZIY8KWq3bPPZVWuOvFaa1LQuRbao5ZpqPi2Yr3f8ml1OeINOeEJGpqMd9wA4IPPMMQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwhMn+HsouyXcmNL0l9pJIA/MrrqGvAr5Lz+gIZ/W5UvdJuiepp D4ETf7VHageYCwMfG2UuZfrO72zHTzCe/ahV2v4ASG3E0urhCHq25dSJf+zdiX84ldF5/ThAQ0Z h7z1LuNMoN7zQxWmw9VKBuXu4FRXbXttm5XJvlvlEXvFa2HDqMAvw54TgHTs= X-Gm-Gg: AfdE7ck4oc4wDxRmLSJvAGi93xP7vmHaUt7t1wK8nHB00KguQEwPHHnzE7a96cnG/KU wfKJ+hftOskq8I/oh3YA7Vmmnv+9o+TZKHMZJb/CcuNSmw0EzvnGMbYQEUYEbRySDdUeTAiYiXC g+cLFL5wrCC5Jq2w/yZFRFtkLhVQupoNe6XZFdBUTsFOvDc4WSadxPgKZYS9Y3CJjmMUOvACWbn LMeHO+/nD4yxKERhaEp+1uogXG+dVdFRzc5pZA5HKuPCkMA2GLKXmJ0k/2T8ZccXDrZwDpw3GGP ZYbTWwrC+aR9mlDWNzUTJsPcL25SUycSi59G6c4W//pwQNDRyFFdc4kFHcOGv0iS0LeO9haUsZL 44YQ3zJIpJsKfaXGtqgXr1J/BrLUNqyOi1yU= X-Received: by 2002:a05:6102:5986:b0:739:b7cc:3ce7 with SMTP id ada2fe7eead31-73a3934de72mr535070137.7.1782822101835; Tue, 30 Jun 2026 05:21:41 -0700 (PDT) X-Received: by 2002:a05:6102:5986:b0:739:b7cc:3ce7 with SMTP id ada2fe7eead31-73a3934de72mr535050137.7.1782822101431; Tue, 30 Jun 2026 05:21:41 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6987c9503f5sm1104309a12.20.2026.06.30.05.21.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 05:21:40 -0700 (PDT) Message-ID: Date: Tue, 30 Jun 2026 14:21:36 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 01/14] firmware: qcom: Add a generic PAS service To: Sumit Garg , andersson@kernel.org Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg , Harshal Dev References: <20260626133440.692849-1-sumit.garg@kernel.org> <20260626133440.692849-2-sumit.garg@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260626133440.692849-2-sumit.garg@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: yR73L6ngn54LFnqbGw342ylRhm4tDUzG X-Authority-Analysis: v=2.4 cv=KqJ9H2WN c=1 sm=1 tr=0 ts=6a43b4d6 cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=DWWpLck2SfFL7czMIZ0A:9 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDExNCBTYWx0ZWRfX0GjQArw242Mo Rq9mpTig4B5PfA07QyUbadSxEzTAo0oxe/QbpozjN1IhQ9CoKPkmD7JqZoXMSUwLc2ZXirgQUj5 EmfhL/onREVlUTaxP4RhG7E3Dz91f3Cfkrhrt/lxo1Yyr3oyhobPkJesED91C3MJlJYhIUqldih wCn/4URhCML+KX7mw4arwqCg8hxYi/KYtKlQtPnx71SubIh7fD8PPFxAqOl/1kMHPBjK34OcPx7 9ZnoBGHag517zkt4qY6SbivEmpOi5UMAeyRSwvni9wqsedD9m9EUKGUzcOavUT0TCL/v3O6NIAJ APrlwYGnQex6auAZeFuzitE59M2J6bT8cqIeqsr0tWoqjupUrAuJAFTSZnlQk88CFucGlLXneIT hD8DpSzf3deafKfpuT3MCqmiCA8z6mGhK/rqZDM9VDW1SshR8PlXKhQDjpp9ogfNbahqWpAXF5Y W+mFwPb2Q6FsiimxtMA== X-Proofpoint-ORIG-GUID: yR73L6ngn54LFnqbGw342ylRhm4tDUzG X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDExNCBTYWx0ZWRfX84A/bmmlNEPj pcsrcA0OfV9jxBkRQiaM4tpUq3nAEDpIxNT7Clx/xdbKOw8TPwtm3ztB17ow2jxWETzEfoKcqq6 tPmrK1c1uKQco5gDIkPjaUxeqJH1XSM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300114 On 6/26/26 3:34 PM, Sumit Garg wrote: > From: Sumit Garg > > Qcom platforms has the legacy of using non-standard SCM calls > splintered over the various kernel drivers. These SCM calls aren't > compliant with the standard SMC calling conventions which is a > prerequisite to enable migration to the FF-A specifications from Arm. > > OP-TEE as an alternative trusted OS to Qualcomm TEE (QTEE) can't > support these non-standard SCM calls. And even for newer architectures > using S-EL2 with Hafnium support, QTEE won't be able to support SCM > calls either with FF-A requirements coming in. And with both OP-TEE > and QTEE drivers well integrated in the TEE subsystem, it makes further > sense to reuse the TEE bus client drivers infrastructure. > > The added benefit of TEE bus infrastructure is that there is support > for discoverable/enumerable services. With that client drivers don't > have to manually invoke a special SCM call to know the service status. > > So enable the generic Peripheral Authentication Service (PAS) provided > by the firmware. It acts as the common layer with different TZ > backends plugged in whether it's an SCM implementation or a proper > TEE bus based PAS service implementation. > > Reviewed-by: Mukesh Ojha > Tested-by: Mukesh Ojha # Lemans > Reviewed-by: Harshal Dev > Tested-by: Vignesh Viswanathan # IPQ9650 > Signed-off-by: Sumit Garg > --- [...] > +struct qcom_pas_context { > + struct device *dev; > + u32 pas_id; > + phys_addr_t mem_phys; > + size_t mem_size; > + void *ptr; > + dma_addr_t phys; > + ssize_t size; > + bool use_tzmem; > +}; Redefining this instead of moving the definition (this is a cross- subsystem merge anyway) makes things more difficult, as there are patches from another team touching this struct.. hopefully no kaboom.. Konrad From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.trustedfirmware.org (lists.trustedfirmware.org [18.214.241.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF76BC43458 for ; Tue, 30 Jun 2026 12:21:50 +0000 (UTC) Received: from lists.trustedfirmware.org (localhost [127.0.0.1]) by lists.trustedfirmware.org (Postfix) with ESMTP id 24ABB44E68 for ; Tue, 30 Jun 2026 12:21:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.trustedfirmware.org; s=2024; t=1782822110; bh=ZBhs34ZISK9bRi/rf/JPGKWEECowkqkQOjuTBR4fNCA=; h=Date:Subject:To:References:In-Reply-To:CC:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Reply-To:From; b=QYVBcRjHZNuqOvabLFJOjW9XJSeoXtOE6uasSZj6GNfhgSPFTRtKeX2ixif8/pqCq IwULRIr3bnIHm775dpu0zvEslK5OrPov8AUUvWjjPX2/7Xs94MRjZLbmcvfD+2Isly eJsa2OUWPB4ZMcyZyEk91axj4TAMMu05fl/CcK8js/0T5OQ2QnwzE4s8TjZwBQJWjT gJosmAlAhWlmXg7GRcbKVlBCsyrhbrq5kzEJ+K0ykzVkwz2yj53h6SKCVtTN1Kj1/d 40PYaIzLt6FZo/9odWCuylI7mW+jNUQcbFffzCREvcby5LK+iUySxXXaup9rStrunx 6A0jkZLVIP/Zg== Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lists.trustedfirmware.org (Postfix) with ESMTPS id 5D61143EAC for ; Tue, 30 Jun 2026 12:21:43 +0000 (UTC) Authentication-Results: lists.trustedfirmware.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=IQK1lL4o; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=fssL6ULK; dkim-atps=neutral Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U9n2b81573524 for ; Tue, 30 Jun 2026 12:21:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OKA9ni/VKYiyOGZbetdw2GUFM0Wy/xcP3QxXwwJdhrk=; b=IQK1lL4oceipm8Q4 wpDe0abCYCvbADeNXWX3gj3hyHy7jURTho8WgTcNP0wxHt9iM42a5wd1u/4ra8hi slQfbSxApQbzQkn8/8rw/U5Aie8gnKbUeQo73GyfSHmrz/dWJU0L41C2pCOKK+Ux eQKjyqY08FHK7bPN2E46E1JCFGqBqISg00TgsLFx+NiEjiPYYH01FCuafv6/DTcr zI2JXzR4UsSaslUZH89nqjJ+CIcWpYI258CT3uYhXgutcWX1OsKtcX3nMdwRsr1c 6alJGvFylNA96g1H5P+qcJH/bFmFX/4BL4uCgiQv9zSHsVRPKJgbUp3dwNymm30A 1zcuIQ== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f46862523-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 12:21:42 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-9691f63552fso154506241.2 for ; Tue, 30 Jun 2026 05:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782822102; x=1783426902; darn=lists.trustedfirmware.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OKA9ni/VKYiyOGZbetdw2GUFM0Wy/xcP3QxXwwJdhrk=; b=fssL6ULKf05T/BUHksN/PaxrWSwkE4zCEg3qcT49wj7A6DLwKC+uOQdty62prfYoSS yBKCuQR8mOR+inpdG2uMZEt7J+czs3KOIIbZst0BEKe4QFH6HlTfpkWDBgkkvVvqYk1Z HVU3lMMjOIicFfV0LHacMllQGHl1mITGRfvGsdDvID4TF2d2mWpU6V12mL34TL8KCz4s 1HtKn/AwZ+gJb6R/c8TLZRhBll1Qs9bC1ApC1wdh+Du0A6bO+R+qeACrUmUQe+4o6+nw joo/9lONC/W+805UxbqzvcvbdPjK/jwYm5gHWdMZzShcRtKl0zw0/77UMrhX2aEGKj0M 89Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782822102; x=1783426902; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OKA9ni/VKYiyOGZbetdw2GUFM0Wy/xcP3QxXwwJdhrk=; b=jX6jEXFm1CFjFKS36obCbSO2z6fQ+UcURJv5D29OGhR9zM63E3TB9iONcLOC7uIYVC GOfah0NlAIzvfc0r6YJx5vKhaBarYIKurfQs6KHmmwl6TEYd4JcPnIsUQts4zVdm4skL 3DYjq+Ng6H6P5AC/6NnNE9JROV3cLlLSVgw2shzQw7nhA1IbTY4oLGhNOM4ifq1Q0n6d hjyERAubn6vEeHYfNUDYPjgpc+cfvQDjhWEtQ8vq9U9J/ZX7G1+SoOJKQ/Fc2sGVuCkl KhCz42YhQkK8vCVQs9U05C5J8SFx418tAQyrlwenIRTTvF62sLVqAqwKd57YM41edX67 0W8Q== X-Forwarded-Encrypted: i=1; AHgh+Rq8dD8NUpF2Hj3FhVgycFDHRxFfh8jR+ro9YBBoJbabbQEX7ab0Ib4CcA41s8GmntDaCQ6ESH0=@lists.trustedfirmware.org X-Gm-Message-State: AOJu0Yzv5/Klqb05kBA2DXYm/3igkq5iXlC/2GUNkZ7aVwqLvlwGd1yI CSPpTesz2PPa//auiRGmGZS+XlPr37kBtwMdFvoPNRa3pbVW4DPfdamW1tMElzzXRLyWURpncb3 ncCwKyqPGJ8+sINvYeY1v0TmUC0ryYtIGDhD1TxSjcN+Z2q62ExTqk4BFpNWL1QopQQCotiyg X-Gm-Gg: AfdE7ckkOSpvHFjRhaf6vHEzfL1cLF38QOPQJoesnuJCTdjqPrtmUlr+NU01WhgAcLz bAbhETWbsfYY6d9lbmqUJ0Gm+kQo/fBIeG2RsVZHtT9TX7Oh2PWONBKICBOOamh3p53uvjBW6EF F7AsCJWVTi6JmELIkWLFtlO+jiLPUnDpZtVuXWDROp/Fcawdtr9rQ+yjpj9DDinb3kYHhpBnRhu amXDR9erOHqTxLys6EJP7ah3KeINjfiuQG1P9iq+6zGRe+jJNeHD2/MFCstdTthpqynsP2iJxts UJx9LNpYRyLd458gtrI/CZGoxxvyAZrEk7u7nVCeSrisQJillfYGmcaPT0n8V6yjHyq5TTQf72J /yBSQTHM51twK+JKY3V7sBzTyxeeJKmExmjQ= X-Received: by 2002:a05:6102:5986:b0:739:b7cc:3ce7 with SMTP id ada2fe7eead31-73a3934de72mr535073137.7.1782822101835; Tue, 30 Jun 2026 05:21:41 -0700 (PDT) X-Received: by 2002:a05:6102:5986:b0:739:b7cc:3ce7 with SMTP id ada2fe7eead31-73a3934de72mr535050137.7.1782822101431; Tue, 30 Jun 2026 05:21:41 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6987c9503f5sm1104309a12.20.2026.06.30.05.21.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 05:21:40 -0700 (PDT) Message-ID: Date: Tue, 30 Jun 2026 14:21:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 01/14] firmware: qcom: Add a generic PAS service To: Sumit Garg , andersson@kernel.org References: <20260626133440.692849-1-sumit.garg@kernel.org> <20260626133440.692849-2-sumit.garg@kernel.org> Content-Language: en-US In-Reply-To: <20260626133440.692849-2-sumit.garg@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Kj1ykoFWMug_Fo5FB41Ysf1NxExEWs2C X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDExNCBTYWx0ZWRfXxD2/Dsbjs808 bMMUCgAokCEPVGZ/yFu4FWEzKTVHg4cmNGMx0MGgoiTt/k/ndQ4whWKQHvmXkykNJyhDL4Z0NBK dVNABU/mjR5VU+onhiJQIpYm4YRcosluqCxebranTIVCx0mV5eg7yj+121qLkRLKTLN51nz6TgQ MXZHgNDyQKiUvvkKvtmakepe3DCMLkvvxJ9dTE70+s1sUI6gv2J3uW7q2UqYmeQ+/TjtQ0YnWik MBcBPrB7/2Kms9wbyFYeRhOx9qPyhC6PzZ37UPZzjQPeUOKgdLo3Bkx3ErlWr+oSZPVxbw9GrTo +DV5tj/luuddul9vk+40t/keHPxoxeyiDjJqQTH1dqixT/p3jRYrG4AC2EOWL4fDwzUPEhxXrVJ Ohwp3uUrPNSQIJbccUSQpyFlNOtD9F51OH0rZTaqZ8KmVxOTek5CND2oDQkI/GJBDDeVagoaQ53 Zp7nkboR2YEgGqNtHbA== X-Proofpoint-GUID: Kj1ykoFWMug_Fo5FB41Ysf1NxExEWs2C X-Authority-Analysis: v=2.4 cv=FbcHAp+6 c=1 sm=1 tr=0 ts=6a43b4d6 cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=DWWpLck2SfFL7czMIZ0A:9 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDExNCBTYWx0ZWRfX16d998QjHh48 4oVzrdGX4kqFWZcprWtWJ90A8HLEONbo79oQrZEYPqTgo2Bs+sXEFSnh1xKHs4KKwzOubErEHD+ 55AKMfXK2OIpohyQ5dseLcuqYsqKGHo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300114 X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.60 / 15.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; DWL_DNSWL_LOW(-1.00)[qualcomm.com:dkim]; DMARC_POLICY_ALLOW(-0.50)[qualcomm.com,reject]; R_SPF_ALLOW(-0.20)[+ip4:205.220.180.131]; R_DKIM_ALLOW(-0.20)[qualcomm.com:s=qcppdkim1,oss.qualcomm.com:s=google]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[205.220.180.131:from]; FREEMAIL_CC(0.00)[vger.kernel.org,lists.freedesktop.org,lists.infradead.org,kernel.org,oss.qualcomm.com,poorly.run,linux.dev,gmail.com,somainline.org,ffwll.ch,lunn.ch,davemloft.net,google.com,redhat.com,linaro.org,qti.qualcomm.com,lists.trustedfirmware.org]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; RCPT_COUNT_TWELVE(0.00)[49]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[qualcomm.com:+,oss.qualcomm.com:+]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:22843, ipnet:205.220.180.0/24, country:US]; PREVIOUSLY_DELIVERED(0.00)[op-tee@lists.trustedfirmware.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; ALIAS_RESOLVED(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM(-0.00)[-1.000]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[dt,netdev]; RCVD_IN_DNSWL_NONE(0.00)[209.85.222.69:received] X-Rspamd-Server: lists.trustedfirmware.org X-Rspamd-Queue-Id: 5D61143EAC X-Spamd-Bar: --- Message-ID-Hash: HKHHVI7LGOKKLMXYRHJRDYCNSIG37JLV X-Message-ID-Hash: HKHHVI7LGOKKLMXYRHJRDYCNSIG37JLV X-MailFrom: konrad.dybcio@oss.qualcomm.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-op-tee.lists.trustedfirmware.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm. com, amirreza.zarrabi@oss.qualcomm.com, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg , Harshal Dev X-Mailman-Version: 3.3.5 Precedence: list List-Id: Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Konrad Dybcio via OP-TEE Reply-To: Konrad Dybcio On 6/26/26 3:34 PM, Sumit Garg wrote: > From: Sumit Garg > > Qcom platforms has the legacy of using non-standard SCM calls > splintered over the various kernel drivers. These SCM calls aren't > compliant with the standard SMC calling conventions which is a > prerequisite to enable migration to the FF-A specifications from Arm. > > OP-TEE as an alternative trusted OS to Qualcomm TEE (QTEE) can't > support these non-standard SCM calls. And even for newer architectures > using S-EL2 with Hafnium support, QTEE won't be able to support SCM > calls either with FF-A requirements coming in. And with both OP-TEE > and QTEE drivers well integrated in the TEE subsystem, it makes further > sense to reuse the TEE bus client drivers infrastructure. > > The added benefit of TEE bus infrastructure is that there is support > for discoverable/enumerable services. With that client drivers don't > have to manually invoke a special SCM call to know the service status. > > So enable the generic Peripheral Authentication Service (PAS) provided > by the firmware. It acts as the common layer with different TZ > backends plugged in whether it's an SCM implementation or a proper > TEE bus based PAS service implementation. > > Reviewed-by: Mukesh Ojha > Tested-by: Mukesh Ojha # Lemans > Reviewed-by: Harshal Dev > Tested-by: Vignesh Viswanathan # IPQ9650 > Signed-off-by: Sumit Garg > --- [...] > +struct qcom_pas_context { > + struct device *dev; > + u32 pas_id; > + phys_addr_t mem_phys; > + size_t mem_size; > + void *ptr; > + dma_addr_t phys; > + ssize_t size; > + bool use_tzmem; > +}; Redefining this instead of moving the definition (this is a cross- subsystem merge anyway) makes things more difficult, as there are patches from another team touching this struct.. hopefully no kaboom.. Konrad