From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Depeng Shao <quic_depengs@quicinc.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: quic_eberman@quicinc.com, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com,
Yongsheng Li <quic_yon@quicinc.com>
Subject: Re: [PATCH 09/13] media: qcom: camss: Add CSID Gen3 support for SM8550
Date: Wed, 31 Jul 2024 17:12:49 +0100 [thread overview]
Message-ID: <bd6f3613-5a96-438a-a2df-cb2728e30c29@linaro.org> (raw)
In-Reply-To: <3011c561-d39e-4ce5-a544-33f24ca7a67c@quicinc.com>
On 31/07/2024 16:26, Depeng Shao wrote:
> I'm preparing the next version patches, then I find it is hard to avoid
> such warning if only apply current patch, since this will be used in the
> below patch, it will be in structures csid_res_8550 -> sm8550_resources
> -> camss_dt_match, so I need to add all csid_res_8550, sm8550_resources,
> camss_dt_match into this patch if I want to avoid the compile warning,
> then I also need to add compatible info for it to avoid sm8550_resources
> has unused variable warning, but the sm8550_resources structure also
> need to add other items to make it complete, then the driver will be
> incomplete but can be probed with this patch.
>
> { .compatible = "qcom,sm8550-camss", .data = &sm8550_resources },
>
> https://lore.kernel.org/all/20240709160656.31146-14-quic_depengs@quicinc.com/
Couldn't you just add the public structures at the same time they are
referenced in &sm8550_resources ?
That way your patchset would progressively apply with no warnings.
---
bod
next prev parent reply other threads:[~2024-07-31 16:12 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 16:06 [PATCH V3 00/13] media: qcom: camss: Add sm8550 support Depeng Shao
2024-07-09 16:06 ` [PATCH 01/13] media: qcom: camss: csiphy-3ph: Fix trivial indentation fault in defines Depeng Shao
2024-07-31 23:16 ` Vladimir Zapolskiy
2024-07-09 16:06 ` [PATCH 02/13] media: qcom: camss: csiphy-3ph: Remove redundant PHY init sequence control loop Depeng Shao
2024-07-31 23:27 ` Vladimir Zapolskiy
2024-07-09 16:06 ` [PATCH 03/13] media: qcom: camss: csiphy-3ph: Rename struct Depeng Shao
2024-07-31 23:28 ` Vladimir Zapolskiy
2024-07-09 16:06 ` [PATCH 04/13] media: qcom: camss: csiphy: Add an init callback to CSI PHY devices Depeng Shao
2024-07-31 23:43 ` Vladimir Zapolskiy
2024-08-01 8:16 ` Bryan O'Donoghue
2024-08-04 21:26 ` Vladimir Zapolskiy
2024-08-07 13:08 ` Depeng Shao
2024-08-07 14:04 ` Bryan O'Donoghue
2024-08-07 15:03 ` Depeng Shao
2024-08-07 15:37 ` Bryan O'Donoghue
2024-08-08 14:02 ` Depeng Shao
2024-08-12 11:32 ` Bryan O'Donoghue
2024-08-12 12:20 ` Depeng Shao
2024-07-09 16:06 ` [PATCH 05/13] media: qcom: camss: csiphy-3ph: Move CSIPHY variables to data field inside csiphy struct Depeng Shao
2024-07-31 23:55 ` Vladimir Zapolskiy
2024-07-09 16:06 ` [PATCH 06/13] media: qcom: camss: csiphy-3ph: Use an offset variable to find common control regs Depeng Shao
2024-07-09 16:06 ` [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding Depeng Shao
2024-07-09 20:21 ` Rob Herring (Arm)
2024-07-10 9:37 ` Bryan O'Donoghue
2024-07-10 10:59 ` Depeng Shao
2024-07-10 11:07 ` Krzysztof Kozlowski
2024-07-11 10:43 ` Depeng Shao
2024-08-01 0:05 ` Vladimir Zapolskiy
2024-08-01 2:02 ` Depeng Shao
2024-07-09 16:06 ` [PATCH 08/13] media: qcom: camss: csiphy-3ph: Add Gen2 v1.2 two-phase MIPI CSI-2 DPHY init Depeng Shao
2024-07-10 11:09 ` Krzysztof Kozlowski
2024-07-10 13:14 ` Depeng Shao
2024-07-10 11:13 ` Bryan O'Donoghue
2024-07-10 13:33 ` Depeng Shao
2024-07-09 16:06 ` [PATCH 09/13] media: qcom: camss: Add CSID Gen3 support for SM8550 Depeng Shao
2024-07-10 11:20 ` Krzysztof Kozlowski
2024-07-11 11:08 ` Depeng Shao
2024-07-11 11:12 ` Krzysztof Kozlowski
2024-07-11 11:41 ` Depeng Shao
2024-07-11 12:00 ` Bryan O'Donoghue
2024-07-11 12:14 ` Depeng Shao
2024-07-11 12:17 ` Krzysztof Kozlowski
2024-07-31 15:26 ` Depeng Shao
2024-07-31 16:12 ` Bryan O'Donoghue [this message]
2024-08-01 1:53 ` Depeng Shao
2024-08-01 10:59 ` Bryan O'Donoghue
2024-08-01 11:14 ` Bryan O'Donoghue
2024-08-01 13:49 ` Depeng Shao
2024-07-10 11:28 ` Bryan O'Donoghue
2024-07-11 15:33 ` Depeng Shao
2024-08-07 15:10 ` Depeng Shao
2024-07-09 16:06 ` [PATCH 10/13] media: qcom: camss: Add support for VFE hardware version Titan 780 Depeng Shao
2024-07-10 11:22 ` Krzysztof Kozlowski
2024-07-10 11:47 ` Bryan O'Donoghue
2024-07-11 13:29 ` Depeng Shao
2024-07-09 16:06 ` [PATCH 11/13] media: qcom: camss: Add notify interface in camss driver Depeng Shao
2024-07-10 11:54 ` Bryan O'Donoghue
2024-07-11 11:54 ` Depeng Shao
2024-07-09 16:06 ` [PATCH 12/13] media: qcom: camss: Add sm8550 support Depeng Shao
2024-07-10 12:02 ` Bryan O'Donoghue
2024-07-11 14:36 ` Depeng Shao
2024-07-09 16:06 ` [PATCH 13/13] media: qcom: camss: Add sm8550 resources Depeng Shao
2024-07-10 11:08 ` [PATCH V3 00/13] media: qcom: camss: Add sm8550 support Krzysztof Kozlowski
2024-07-10 11:27 ` Depeng Shao
2024-07-10 12:30 ` Krzysztof Kozlowski
2024-07-11 11:14 ` Depeng Shao
2024-08-24 17:05 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd6f3613-5a96-438a-a2df-cb2728e30c29@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_depengs@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_yon@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.