From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jarkko Nikula" Subject: Re: [PATCH] asoc tlv320aic3x: set power bits correctly Date: Wed, 30 Apr 2008 14:50:43 +0300 Message-ID: References: <20080430093719.GA13740@buzzloop.caiaq.de> <20080430095747.GA28593@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from qb-out-0506.google.com (qb-out-0506.google.com [72.14.204.224]) by alsa0.perex.cz (Postfix) with ESMTP id 80E1A103929 for ; Wed, 30 Apr 2008 13:50:45 +0200 (CEST) Received: by qb-out-0506.google.com with SMTP id q12so657700qba.12 for ; Wed, 30 Apr 2008 04:50:43 -0700 (PDT) In-Reply-To: <20080430095747.GA28593@sirena.org.uk> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Daniel Mack , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Wed, Apr 30, 2008 at 12:57 PM, Mark Brown < broonie@opensource.wolfsonmicro.com> wrote: > > If what you're trying to do is avoid powering on amplifiers when they > are muted then this is best avoided since it often creates problems with > pops and clicks due to things getting powered on and off out of the > sequence generated by DAPM. If the amplifier is powered on before its > inputs then it will amplify any noise generaetd by the inputs when they > change power state. This is why ASoC mute controls for amplifiers are > normally independent of their power controls. > I was looking do we have possible driver bug here and answer is no. Driver keeps output state powered during playback if associated endpoint is enabled with snd_soc_dapm_set_endpoint and unpowered otherwise. So as with Mark's comment, the patch is unnecessary. Jarkko