From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH 2/6] block/nvme: Map doorbells pages write-only
Date: Tue, 22 Sep 2020 11:04:52 +0200 [thread overview]
Message-ID: <bd7e17f6-95cb-e697-731b-e61ac3a64d30@redhat.com> (raw)
In-Reply-To: <22dab788-06f1-3686-51f3-24ee7ce77fda@redhat.com>
On 22/09/20 10:41, Philippe Mathieu-Daudé wrote:
>> Besides looking more correct in access mode, is there any side effect
>> of WO mapping?
> TBH I don't have enough knowledge to answer this question.
> I tested successfully on X86. I'm writing more tests.
No problem with doing this, but PROT_WRITE does not work at all on x86.
:) PROT_EXEC works if you have a machine with PKRU, but PROT_WRITE
silently becomes PROT_READ|PROT_WRITE because the processor does not
support it.
Paolo
next prev parent reply other threads:[~2020-09-22 9:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 16:29 [PATCH 0/6] block/nvme: Map doorbells pages write-only, remove magic from nvme_init Philippe Mathieu-Daudé
2020-09-21 16:29 ` [PATCH 1/6] util/vfio-helpers: Pass page protections to qemu_vfio_pci_map_bar() Philippe Mathieu-Daudé
2020-09-21 16:29 ` [PATCH 2/6] block/nvme: Map doorbells pages write-only Philippe Mathieu-Daudé
2020-09-22 8:18 ` Fam Zheng
2020-09-22 8:41 ` Philippe Mathieu-Daudé
2020-09-22 9:04 ` Paolo Bonzini [this message]
2020-09-22 9:36 ` Philippe Mathieu-Daudé
2020-09-22 9:33 ` Fam Zheng
2020-09-21 16:29 ` [PATCH 3/6] block/nvme: Reduce I/O registers scope Philippe Mathieu-Daudé
2020-09-21 16:29 ` [PATCH 4/6] block/nvme: Drop NVMeRegs structure, directly use NvmeBar Philippe Mathieu-Daudé
2020-09-21 16:29 ` [PATCH 5/6] block/nvme: Use register definitions from 'block/nvme.h' Philippe Mathieu-Daudé
2020-09-21 16:29 ` [PATCH 6/6] block/nvme: Replace magic value by SCALE_MS definition Philippe Mathieu-Daudé
2020-09-21 21:38 ` [PATCH 0/6] block/nvme: Map doorbells pages write-only, remove magic from nvme_init no-reply
2020-09-21 21:56 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd7e17f6-95cb-e697-731b-e61ac3a64d30@redhat.com \
--to=pbonzini@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.