From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
io-uring <io-uring@vger.kernel.org>
Subject: Re: [PATCH] io_uring: kill io_cqring_ev_posted() and __io_cq_unlock_post()
Date: Thu, 24 Nov 2022 11:46:26 -0700 [thread overview]
Message-ID: <bd80da09-a433-1ea6-6a0c-bbb335b5187d@kernel.dk> (raw)
In-Reply-To: <c03977b8-85a1-5984-ebda-8a0c7d0087d2@gmail.com>
On 11/24/22 9:16?AM, Pavel Begunkov wrote:
> On 11/21/22 14:52, Jens Axboe wrote:
>> __io_cq_unlock_post() is identical to io_cq_unlock_post(), and
>> io_cqring_ev_posted() has a single caller so migth as well just inline
>> it there.
>
> It was there for one purpose, to inline it in the hottest path,
> i.e. __io_submit_flush_completions(). I'll be reverting it back
The compiler is most certainly already doing that, in fact even
__io_submit_flush_completions() is inlined in
io_submit_flush_completions() for me here.
--
Jens Axboe
next prev parent reply other threads:[~2022-11-24 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 14:52 [PATCH] io_uring: kill io_cqring_ev_posted() and __io_cq_unlock_post() Jens Axboe
2022-11-24 16:16 ` Pavel Begunkov
2022-11-24 18:46 ` Jens Axboe [this message]
2022-11-24 19:17 ` Pavel Begunkov
2022-11-24 19:19 ` Pavel Begunkov
2022-11-24 19:29 ` Jens Axboe
2022-11-24 19:51 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd80da09-a433-1ea6-6a0c-bbb335b5187d@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.