From: Krzysztof Kozlowski <krzk@kernel.org>
To: Crystal Guo <crystal.guo@mediatek.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [v2,2/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface
Date: Sun, 9 Feb 2025 11:48:50 +0100 [thread overview]
Message-ID: <bdae5678-ff79-4c04-8d77-c6bdfe613c68@kernel.org> (raw)
In-Reply-To: <20250206121629.12186-3-crystal.guo@mediatek.com>
On 06/02/2025 13:16, Crystal Guo wrote:
> A MediaTek DRAM controller interface to provide the current DDR data rate.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
> ---
> .../mediatek,common-dramc.yaml | 129 ------------------
Why is there removal here if you add? Commit msg explains nothing here.
Why this patch was sent twice?
Please use standard email subjects, so with the PATCH keyword in the
title. `git format-patch -vX` helps here to create proper versioned
patches. Another useful tool is b4. Skipping the PATCH keyword makes
filtering of emails more difficult thus making the review process less
convenient.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-09 10:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 12:16 [v2,0/2] Add an interface to get current DDR data rate Crystal Guo
2025-02-06 12:16 ` [v2,1/2] memory/mediatek: " Crystal Guo
2025-02-06 12:31 ` AngeloGioacchino Del Regno
2025-02-07 1:30 ` Crystal Guo (郭晶)
2025-02-09 10:51 ` Krzysztof Kozlowski
2025-02-06 12:16 ` [v2,2/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface Crystal Guo
2025-02-09 10:48 ` Krzysztof Kozlowski [this message]
2025-02-11 11:25 ` Crystal Guo (郭晶)
-- strict thread matches above, loose matches on Subject: below --
2025-02-07 1:42 [v2,0/2] Add an interface to get current DDR data rate Crystal Guo
2025-02-07 1:42 ` [v2,2/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface Crystal Guo
2025-02-09 10:51 ` Krzysztof Kozlowski
2025-02-12 3:50 ` Crystal Guo (郭晶)
2025-02-12 5:34 ` Krzysztof Kozlowski
2025-02-12 10:07 ` Crystal Guo (郭晶)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdae5678-ff79-4c04-8d77-c6bdfe613c68@kernel.org \
--to=krzk@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=crystal.guo@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.