From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Miao.Zhu" <Miao.Zhu@synopsys.com>, robh@kernel.org
Cc: James.Li1@synopsys.com, Jianheng.Zhang@synopsys.com,
Martin.McKenny@synopsys.com, andre.draszik@linaro.org,
conor+dt@kernel.org, dan.carpenter@linaro.org,
devicetree@vger.kernel.org, emanuele.ghidoli@toradex.com,
gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
jun.li@nxp.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, m.felsch@pengutronix.de,
rdbabiera@google.com, u.kleine-koenig@baylibre.com,
xu.yang_2@nxp.com
Subject: Re: [PATCH v3 2/2] dt-bindings: usb: ptn5110: add TCPC properties
Date: Wed, 18 Dec 2024 10:04:31 +0100 [thread overview]
Message-ID: <bdbff25d-fe9d-4602-add5-aa2f9d4806d1@kernel.org> (raw)
In-Reply-To: <fbad3631-1efe-4d9b-b163-e635452b0b73@kernel.org>
On 18/12/2024 09:04, Krzysztof Kozlowski wrote:
>> interrupts:
>> maxItems: 1
>>
>> + TX_BUF_BYTE_x_hidden:
>
> Follow DTS coding style.
>
>> + description:
>> + When set, TX_BUF_BYTE_x can only be accessed through
>> + I2C_WRITE_BYTE_COUNT.
> You described the desired Linux feature or behavior, not the actual
> hardware. The bindings are about the latter, so instead you need to
> rephrase the property and its description to match actual hardware
> capabilities/features/configuration etc.
I forgot: missing vendor prefix, missing type. Please see how other
bindings are written. example-schema is also good to start with.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-18 9:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 3:06 [PATCH] usb: typec: tcpm: tcpci: Make the driver be compatible with the TCPCI spec [Rev 2.0 Ver 1.0, October 2017] Miao Zhu
2024-12-02 5:43 ` Xu Yang
2024-12-18 1:07 ` [PATCH v2 0/2] usb: typec: tcpci: Make the driver be compatible with TCPCI Spec Miao.Zhu
2024-12-18 1:07 ` [PATCH v2 1/2] usb: typec: tcpm: tcpci: Make the driver be compatible with the TCPCI spec [Rev 2.0 Ver 1.0, October 2017] Miao.Zhu
2024-12-18 1:07 ` [PATCH v2 2/2] dt-bindings: usb: ptn5110: add TCPC properties Miao.Zhu
2024-12-18 2:22 ` Rob Herring (Arm)
2024-12-18 5:22 ` [PATCH v3 " Miao.Zhu
2024-12-18 8:04 ` Krzysztof Kozlowski
2024-12-18 9:04 ` Krzysztof Kozlowski [this message]
2024-12-18 5:28 ` Miao.Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdbff25d-fe9d-4602-add5-aa2f9d4806d1@kernel.org \
--to=krzk@kernel.org \
--cc=James.Li1@synopsys.com \
--cc=Jianheng.Zhang@synopsys.com \
--cc=Martin.McKenny@synopsys.com \
--cc=Miao.Zhu@synopsys.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=emanuele.ghidoli@toradex.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=rdbabiera@google.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.