From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E873A23AA; Thu, 16 Nov 2023 21:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EKuij+E0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2317C433C7; Thu, 16 Nov 2023 21:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700171064; bh=ald44zxPKSHHWmxtiq1CnFZGTT8QFCngOMNKW7PPBEg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=EKuij+E0DyF+eivwhkO6BCqM1ch2c6nR/mSnS9oz4i6zX42cLjDdjyJMLHnQCu7n/ +rhEauEneiIBBb5QaZa912jIJyAGdD0hPxSzCR/WgE6hfqGxRqP86pTzhll3uLnJWt iZyaGtZrrOaXjfb3WfbskirBjiDaKS4pFc1qBX4s9hlXCKQS27jqp+jPJhmblhhMfG CjqiLrLPsK/kecRe3k8QN6Z9D1flWAoGkOXKFi3Y4JGugq/4NsyqEI5ZiQxbOKkesO xuIh2yb4UNEgkY2/aMzbA5S2XDB7W1OavUXTJ5q0+jU2qaVp9V0d6u6eLrUWuuqy0K FIZqx4zS5J12g== Message-ID: Date: Thu, 16 Nov 2023 23:44:17 +0200 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] usb: cdns3-ti: add suspend/resume procedures for J7200 To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Chen , Pawel Laszczak , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , "Vardhan, Vibhore" Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Gr=C3=A9gory_Clement?= , Thomas Petazzoni References: <20231113-j7200-usb-suspend-v1-0-ad1ee714835c@bootlin.com> <20231113-j7200-usb-suspend-v1-3-ad1ee714835c@bootlin.com> <5080372b-1f48-4cbc-a6c4-8689c28983cb@kernel.org> Content-Language: en-US From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +Vibhore, On 16/11/2023 20:56, Théo Lebrun wrote: > Hello Roger, > > On Thu Nov 16, 2023 at 1:40 PM CET, Roger Quadros wrote: >> On 15/11/2023 17:02, Théo Lebrun wrote: >>> On Wed Nov 15, 2023 at 12:37 PM CET, Roger Quadros wrote: >>>> On 13/11/2023 16:26, Théo Lebrun wrote: >>>>> Hardware initialisation is only done at probe. The J7200 USB controller >>>>> is reset at resume because of power-domains toggling off & on. We >>>>> therefore (1) toggle PM runtime at suspend/resume & (2) reconfigure the >>>>> hardware at resume. >>>> >>>> at probe we are doing a pm_runtime_get() and never doing a put thus >>>> preventing any runtime PM. >>> >>> Indeed. The get() from probe/resume are in symmetry with the put() from >>> suspend. Is this wrong in some manner? >>> >>>>> index c331bcd2faeb..50b38c4b9c87 100644 >>>>> --- a/drivers/usb/cdns3/cdns3-ti.c >>>>> +++ b/drivers/usb/cdns3/cdns3-ti.c >>>>> @@ -197,6 +197,50 @@ static int cdns_ti_probe(struct platform_device *pdev) >>>>> return error; >>>>> } >>>>> >>>>> +#ifdef CONFIG_PM >>>>> + >>>>> +static int cdns_ti_suspend(struct device *dev) >>>>> +{ >>>>> + struct cdns_ti *data = dev_get_drvdata(dev); >>>>> + >>>>> + if (!of_device_is_compatible(dev_of_node(dev), "ti,j7200-usb")) >>>>> + return 0; >>>>> + >>>>> + pm_runtime_put_sync(data->dev); >>>>> + >>>>> + return 0; >>>> >>>> You might want to check suspend/resume ops in cdns3-plat and >>>> do something similar here. >>> >>> I'm unsure what you are referring to specifically in cdns3-plat? >> >> What I meant is, calling pm_runtime_get/put() from system suspend/resume >> hooks doesn't seem right. >> >> How about using something like pm_runtime_forbid(dev) on devices which >> loose USB context on runtime suspend e.g. J7200. >> So at probe we can get rid of the pm_runtime_get_sync() call. > > What is the goal of enabling PM runtime to then block (ie forbid) it in > its enabled state until system suspend? If USB controller retains context on runtime_suspend on some platforms then we don't want to forbid PM runtime. > > Thinking some more about it and having read parts of the genpd source, > it's unclear to me why there even is some PM runtime calls in this > driver. No runtime_suspend/runtime_resume callbacks are registered. > Also, power-domains work as expected without any PM runtime calls. Probably it was required when the driver was introduced. > > The power domain is turned on when attached to a device > (see genpd_dev_pm_attach). It gets turned off automatically at > suspend_noirq (taking into account the many things that make genpd > complex: multiple devices per PD, subdomains, flags to customise the > behavior, etc.). Removing calls to PM runtime at probe keeps the driver > working. > > So my new proposal would be: remove all all PM runtime calls from this > driver. Anything wrong with this approach? Nothing wrong if we don't expect runtime_pm to work with this driver. > > Only possible reason I see for having PM runtime in this wrapper driver > would be cut the full power-domain when USB isn't used, with some PM > runtime interaction with the children node. But that cannot work > currently as we don't register a runtime_resume to init the hardware, > so this cannot be the current expected behavior. > >> e.g. >> >> pm_runtime_set_active(dev); >> pm_runtime_enable(dev); >> if (cnds_ti->can_loose_context) >> pm_runtime_forbid(dev); >> >> pm_runtime_set_autosuspend_delay(dev, CNDS_TI_AUTOSUSPEND_DELAY); /* could be 20ms? */ > > Why mention autosuspend in this driver? This will turn the device off in > CNDS_TI_AUTOSUSPEND_DELAY then nothing enables it back using > pm_runtime_get. We have nothing to reconfigure the device, ie no > runtime_resume, so we must not go into runtime suspend. It would be enabled/disabled based on when the child "cdns3,usb" does runtime_resume/suspend. > >> pm_runtime_mark_last_busy(dev); >> pm_runtime_use_autosuspend(dev); >> >> You will need to modify the suspend/resume handlers accordingly. >> https://docs.kernel.org/power/runtime_pm.html#runtime-pm-and-system-sleep >> >> What I'm not sure of is if there are any TI platforms that retain USB context >> on power domain off. Let me get back on this. Till then we can assume that >> all platforms loose USB context on power domain off. > > Good question indeed! Thanks for looking into it. From what I see all 5 > DT nodes which use this driver in upstream devicetrees have a > power-domain configured. So if the behavior is the same on all three TI > platforms (which would be the logical thing to assume) it would make > sense that all controllers lose power at suspend. > > Thanks, > > -- > Théo Lebrun, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com -- cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 144DDC197A0 for ; Thu, 16 Nov 2023 21:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wHwUUa0lSeIkyHTXXlKb0RZtUlNOAGNd/j5e4VCwF84=; b=lnCHwekNwcJrQI aKrQrSr6zblUdsuMcH+jTydBOoeutmCGyJ+VBwSaAKjcu6jCkhtr0+zLp7aGxQuKFTmjJ+s2XutpP MAzGbNKek3i+fJQ84+BIJTWxH9ZyBHwGR22Yxw2BgDA3Wa1DYyceLxm+0g3/KqhhQ9/LxoQrCDPZV LM3a/TpVV6LCGB/xIbt/KWftSnJdapUgshmC7bB2BBBGfnSKCpZ6+ibrrJhNu8cHHLc++cBDAOKff fqjD/I1H4LqN1tYA2qVb2WUOV5+LCkfSw40Hy5fimyKanrZLlLkiwaBKw1thH4FiLn/ZtZGI4Dl7O 9CmdWjJkGfmxwOV9Ksqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3kA6-004wQb-17; Thu, 16 Nov 2023 21:44:34 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r3kA3-004wOe-0A for linux-arm-kernel@lists.infradead.org; Thu, 16 Nov 2023 21:44:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A902D61BA3; Thu, 16 Nov 2023 21:44:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2317C433C7; Thu, 16 Nov 2023 21:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700171064; bh=ald44zxPKSHHWmxtiq1CnFZGTT8QFCngOMNKW7PPBEg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=EKuij+E0DyF+eivwhkO6BCqM1ch2c6nR/mSnS9oz4i6zX42cLjDdjyJMLHnQCu7n/ +rhEauEneiIBBb5QaZa912jIJyAGdD0hPxSzCR/WgE6hfqGxRqP86pTzhll3uLnJWt iZyaGtZrrOaXjfb3WfbskirBjiDaKS4pFc1qBX4s9hlXCKQS27jqp+jPJhmblhhMfG CjqiLrLPsK/kecRe3k8QN6Z9D1flWAoGkOXKFi3Y4JGugq/4NsyqEI5ZiQxbOKkesO xuIh2yb4UNEgkY2/aMzbA5S2XDB7W1OavUXTJ5q0+jU2qaVp9V0d6u6eLrUWuuqy0K FIZqx4zS5J12g== Message-ID: Date: Thu, 16 Nov 2023 23:44:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] usb: cdns3-ti: add suspend/resume procedures for J7200 To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Chen , Pawel Laszczak , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , "Vardhan, Vibhore" Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Gr=C3=A9gory_Clement?= , Thomas Petazzoni References: <20231113-j7200-usb-suspend-v1-0-ad1ee714835c@bootlin.com> <20231113-j7200-usb-suspend-v1-3-ad1ee714835c@bootlin.com> <5080372b-1f48-4cbc-a6c4-8689c28983cb@kernel.org> Content-Language: en-US From: Roger Quadros In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231116_134431_178622_A3116A28 X-CRM114-Status: GOOD ( 33.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org K1ZpYmhvcmUsCgpPbiAxNi8xMS8yMDIzIDIwOjU2LCBUaMOpbyBMZWJydW4gd3JvdGU6Cj4gSGVs bG8gUm9nZXIsCj4gCj4gT24gVGh1IE5vdiAxNiwgMjAyMyBhdCAxOjQwIFBNIENFVCwgUm9nZXIg UXVhZHJvcyB3cm90ZToKPj4gT24gMTUvMTEvMjAyMyAxNzowMiwgVGjDqW8gTGVicnVuIHdyb3Rl Ogo+Pj4gT24gV2VkIE5vdiAxNSwgMjAyMyBhdCAxMjozNyBQTSBDRVQsIFJvZ2VyIFF1YWRyb3Mg d3JvdGU6Cj4+Pj4gT24gMTMvMTEvMjAyMyAxNjoyNiwgVGjDqW8gTGVicnVuIHdyb3RlOgo+Pj4+ PiBIYXJkd2FyZSBpbml0aWFsaXNhdGlvbiBpcyBvbmx5IGRvbmUgYXQgcHJvYmUuIFRoZSBKNzIw MCBVU0IgY29udHJvbGxlcgo+Pj4+PiBpcyByZXNldCBhdCByZXN1bWUgYmVjYXVzZSBvZiBwb3dl ci1kb21haW5zIHRvZ2dsaW5nIG9mZiAmIG9uLiBXZQo+Pj4+PiB0aGVyZWZvcmUgKDEpIHRvZ2ds ZSBQTSBydW50aW1lIGF0IHN1c3BlbmQvcmVzdW1lICYgKDIpIHJlY29uZmlndXJlIHRoZQo+Pj4+ PiBoYXJkd2FyZSBhdCByZXN1bWUuCj4+Pj4KPj4+PiBhdCBwcm9iZSB3ZSBhcmUgZG9pbmcgYSBw bV9ydW50aW1lX2dldCgpIGFuZCBuZXZlciBkb2luZyBhIHB1dCB0aHVzCj4+Pj4gcHJldmVudGlu ZyBhbnkgcnVudGltZSBQTS4KPj4+Cj4+PiBJbmRlZWQuIFRoZSBnZXQoKSBmcm9tIHByb2JlL3Jl c3VtZSBhcmUgaW4gc3ltbWV0cnkgd2l0aCB0aGUgcHV0KCkgZnJvbQo+Pj4gc3VzcGVuZC4gSXMg dGhpcyB3cm9uZyBpbiBzb21lIG1hbm5lcj8KPj4+Cj4+Pj4+IGluZGV4IGMzMzFiY2QyZmFlYi4u NTBiMzhjNGI5Yzg3IDEwMDY0NAo+Pj4+PiAtLS0gYS9kcml2ZXJzL3VzYi9jZG5zMy9jZG5zMy10 aS5jCj4+Pj4+ICsrKyBiL2RyaXZlcnMvdXNiL2NkbnMzL2NkbnMzLXRpLmMKPj4+Pj4gQEAgLTE5 Nyw2ICsxOTcsNTAgQEAgc3RhdGljIGludCBjZG5zX3RpX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9k ZXZpY2UgKnBkZXYpCj4+Pj4+ICAJcmV0dXJuIGVycm9yOwo+Pj4+PiAgfQo+Pj4+PiAgCj4+Pj4+ ICsjaWZkZWYgQ09ORklHX1BNCj4+Pj4+ICsKPj4+Pj4gK3N0YXRpYyBpbnQgY2Ruc190aV9zdXNw ZW5kKHN0cnVjdCBkZXZpY2UgKmRldikKPj4+Pj4gK3sKPj4+Pj4gKwlzdHJ1Y3QgY2Ruc190aSAq ZGF0YSA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+Pj4+PiArCj4+Pj4+ICsJaWYgKCFvZl9kZXZp Y2VfaXNfY29tcGF0aWJsZShkZXZfb2Zfbm9kZShkZXYpLCAidGksajcyMDAtdXNiIikpCj4+Pj4+ ICsJCXJldHVybiAwOwo+Pj4+PiArCj4+Pj4+ICsJcG1fcnVudGltZV9wdXRfc3luYyhkYXRhLT5k ZXYpOwo+Pj4+PiArCj4+Pj4+ICsJcmV0dXJuIDA7Cj4+Pj4KPj4+PiBZb3UgbWlnaHQgd2FudCB0 byBjaGVjayBzdXNwZW5kL3Jlc3VtZSBvcHMgaW4gY2RuczMtcGxhdCBhbmQKPj4+PiBkbyBzb21l dGhpbmcgc2ltaWxhciBoZXJlLgo+Pj4KPj4+IEknbSB1bnN1cmUgd2hhdCB5b3UgYXJlIHJlZmVy cmluZyB0byBzcGVjaWZpY2FsbHkgaW4gY2RuczMtcGxhdD8KPj4KPj4gV2hhdCBJIG1lYW50IGlz LCBjYWxsaW5nIHBtX3J1bnRpbWVfZ2V0L3B1dCgpIGZyb20gc3lzdGVtIHN1c3BlbmQvcmVzdW1l Cj4+IGhvb2tzIGRvZXNuJ3Qgc2VlbSByaWdodC4KPj4KPj4gSG93IGFib3V0IHVzaW5nIHNvbWV0 aGluZyBsaWtlIHBtX3J1bnRpbWVfZm9yYmlkKGRldikgb24gZGV2aWNlcyB3aGljaAo+PiBsb29z ZSBVU0IgY29udGV4dCBvbiBydW50aW1lIHN1c3BlbmQgZS5nLiBKNzIwMC4KPj4gU28gYXQgcHJv YmUgd2UgY2FuIGdldCByaWQgb2YgdGhlIHBtX3J1bnRpbWVfZ2V0X3N5bmMoKSBjYWxsLgo+IAo+ IFdoYXQgaXMgdGhlIGdvYWwgb2YgZW5hYmxpbmcgUE0gcnVudGltZSB0byB0aGVuIGJsb2NrIChp ZSBmb3JiaWQpIGl0IGluCj4gaXRzIGVuYWJsZWQgc3RhdGUgdW50aWwgc3lzdGVtIHN1c3BlbmQ/ CgpJZiBVU0IgY29udHJvbGxlciByZXRhaW5zIGNvbnRleHQgb24gcnVudGltZV9zdXNwZW5kIG9u IHNvbWUgcGxhdGZvcm1zCnRoZW4gd2UgZG9uJ3Qgd2FudCB0byBmb3JiaWQgUE0gcnVudGltZS4K Cj4gCj4gVGhpbmtpbmcgc29tZSBtb3JlIGFib3V0IGl0IGFuZCBoYXZpbmcgcmVhZCBwYXJ0cyBv ZiB0aGUgZ2VucGQgc291cmNlLAo+IGl0J3MgdW5jbGVhciB0byBtZSB3aHkgdGhlcmUgZXZlbiBp cyBzb21lIFBNIHJ1bnRpbWUgY2FsbHMgaW4gdGhpcwo+IGRyaXZlci4gTm8gcnVudGltZV9zdXNw ZW5kL3J1bnRpbWVfcmVzdW1lIGNhbGxiYWNrcyBhcmUgcmVnaXN0ZXJlZC4KPiBBbHNvLCBwb3dl ci1kb21haW5zIHdvcmsgYXMgZXhwZWN0ZWQgd2l0aG91dCBhbnkgUE0gcnVudGltZSBjYWxscy4K ClByb2JhYmx5IGl0IHdhcyByZXF1aXJlZCB3aGVuIHRoZSBkcml2ZXIgd2FzIGludHJvZHVjZWQu Cgo+IAo+IFRoZSBwb3dlciBkb21haW4gaXMgdHVybmVkIG9uIHdoZW4gYXR0YWNoZWQgdG8gYSBk ZXZpY2UKPiAoc2VlIGdlbnBkX2Rldl9wbV9hdHRhY2gpLiBJdCBnZXRzIHR1cm5lZCBvZmYgYXV0 b21hdGljYWxseSBhdAo+IHN1c3BlbmRfbm9pcnEgKHRha2luZyBpbnRvIGFjY291bnQgdGhlIG1h bnkgdGhpbmdzIHRoYXQgbWFrZSBnZW5wZAo+IGNvbXBsZXg6IG11bHRpcGxlIGRldmljZXMgcGVy IFBELCBzdWJkb21haW5zLCBmbGFncyB0byBjdXN0b21pc2UgdGhlCj4gYmVoYXZpb3IsIGV0Yy4p LiBSZW1vdmluZyBjYWxscyB0byBQTSBydW50aW1lIGF0IHByb2JlIGtlZXBzIHRoZSBkcml2ZXIK PiB3b3JraW5nLgo+IAo+IFNvIG15IG5ldyBwcm9wb3NhbCB3b3VsZCBiZTogcmVtb3ZlIGFsbCBh bGwgUE0gcnVudGltZSBjYWxscyBmcm9tIHRoaXMKPiBkcml2ZXIuIEFueXRoaW5nIHdyb25nIHdp dGggdGhpcyBhcHByb2FjaD8KCk5vdGhpbmcgd3JvbmcgaWYgd2UgZG9uJ3QgZXhwZWN0IHJ1bnRp bWVfcG0gdG8gd29yayB3aXRoIHRoaXMgZHJpdmVyLgoKPiAKPiBPbmx5IHBvc3NpYmxlIHJlYXNv biBJIHNlZSBmb3IgaGF2aW5nIFBNIHJ1bnRpbWUgaW4gdGhpcyB3cmFwcGVyIGRyaXZlcgo+IHdv dWxkIGJlIGN1dCB0aGUgZnVsbCBwb3dlci1kb21haW4gd2hlbiBVU0IgaXNuJ3QgdXNlZCwgd2l0 aCBzb21lIFBNCj4gcnVudGltZSBpbnRlcmFjdGlvbiB3aXRoIHRoZSBjaGlsZHJlbiBub2RlLiBC dXQgdGhhdCBjYW5ub3Qgd29yawo+IGN1cnJlbnRseSBhcyB3ZSBkb24ndCByZWdpc3RlciBhIHJ1 bnRpbWVfcmVzdW1lIHRvIGluaXQgdGhlIGhhcmR3YXJlLAo+IHNvIHRoaXMgY2Fubm90IGJlIHRo ZSBjdXJyZW50IGV4cGVjdGVkIGJlaGF2aW9yLgo+IAo+PiBlLmcuCj4+Cj4+ICAgICAgICAgcG1f cnVudGltZV9zZXRfYWN0aXZlKGRldik7Cj4+ICAgICAgICAgcG1fcnVudGltZV9lbmFibGUoZGV2 KTsKPj4gICAgICAgICBpZiAoY25kc190aS0+Y2FuX2xvb3NlX2NvbnRleHQpCj4+ICAgICAgICAg ICAgICAgICBwbV9ydW50aW1lX2ZvcmJpZChkZXYpOwo+Pgo+PiAgICAgICAgIHBtX3J1bnRpbWVf c2V0X2F1dG9zdXNwZW5kX2RlbGF5KGRldiwgQ05EU19USV9BVVRPU1VTUEVORF9ERUxBWSk7CS8q IGNvdWxkIGJlIDIwbXM/ICovCj4gCj4gV2h5IG1lbnRpb24gYXV0b3N1c3BlbmQgaW4gdGhpcyBk cml2ZXI/IFRoaXMgd2lsbCB0dXJuIHRoZSBkZXZpY2Ugb2ZmIGluCj4gQ05EU19USV9BVVRPU1VT UEVORF9ERUxBWSB0aGVuIG5vdGhpbmcgZW5hYmxlcyBpdCBiYWNrIHVzaW5nCj4gcG1fcnVudGlt ZV9nZXQuIFdlIGhhdmUgbm90aGluZyB0byByZWNvbmZpZ3VyZSB0aGUgZGV2aWNlLCBpZSBubwo+ IHJ1bnRpbWVfcmVzdW1lLCBzbyB3ZSBtdXN0IG5vdCBnbyBpbnRvIHJ1bnRpbWUgc3VzcGVuZC4K Ckl0IHdvdWxkIGJlIGVuYWJsZWQvZGlzYWJsZWQgYmFzZWQgb24gd2hlbiB0aGUgY2hpbGQgImNk bnMzLHVzYiIKZG9lcyBydW50aW1lX3Jlc3VtZS9zdXNwZW5kLgoKPiAKPj4gICAgICAgICBwbV9y dW50aW1lX21hcmtfbGFzdF9idXN5KGRldik7Cj4+ICAgICAgICAgcG1fcnVudGltZV91c2VfYXV0 b3N1c3BlbmQoZGV2KTsKPj4KPj4gWW91IHdpbGwgbmVlZCB0byBtb2RpZnkgdGhlIHN1c3BlbmQv cmVzdW1lIGhhbmRsZXJzIGFjY29yZGluZ2x5Lgo+PiBodHRwczovL2RvY3Mua2VybmVsLm9yZy9w b3dlci9ydW50aW1lX3BtLmh0bWwjcnVudGltZS1wbS1hbmQtc3lzdGVtLXNsZWVwCj4+Cj4+IFdo YXQgSSdtIG5vdCBzdXJlIG9mIGlzIGlmIHRoZXJlIGFyZSBhbnkgVEkgcGxhdGZvcm1zIHRoYXQg cmV0YWluIFVTQiBjb250ZXh0Cj4+IG9uIHBvd2VyIGRvbWFpbiBvZmYuIExldCBtZSBnZXQgYmFj ayBvbiB0aGlzLiBUaWxsIHRoZW4gd2UgY2FuIGFzc3VtZSB0aGF0Cj4+IGFsbCBwbGF0Zm9ybXMg bG9vc2UgVVNCIGNvbnRleHQgb24gcG93ZXIgZG9tYWluIG9mZi4KPiAKPiBHb29kIHF1ZXN0aW9u IGluZGVlZCEgVGhhbmtzIGZvciBsb29raW5nIGludG8gaXQuIEZyb20gd2hhdCBJIHNlZSBhbGwg NQo+IERUIG5vZGVzIHdoaWNoIHVzZSB0aGlzIGRyaXZlciBpbiB1cHN0cmVhbSBkZXZpY2V0cmVl cyBoYXZlIGEKPiBwb3dlci1kb21haW4gY29uZmlndXJlZC4gU28gaWYgdGhlIGJlaGF2aW9yIGlz IHRoZSBzYW1lIG9uIGFsbCB0aHJlZSBUSQo+IHBsYXRmb3JtcyAod2hpY2ggd291bGQgYmUgdGhl IGxvZ2ljYWwgdGhpbmcgdG8gYXNzdW1lKSBpdCB3b3VsZCBtYWtlCj4gc2Vuc2UgdGhhdCBhbGwg Y29udHJvbGxlcnMgbG9zZSBwb3dlciBhdCBzdXNwZW5kLgo+IAo+IFRoYW5rcywKPiAKPiAtLQo+ IFRow6lvIExlYnJ1biwgQm9vdGxpbgo+IEVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5l ZXJpbmcKPiBodHRwczovL2Jvb3RsaW4uY29tCgotLSAKY2hlZXJzLAotcm9nZXIKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK