From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D28AC7EE21 for ; Fri, 5 May 2023 01:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jMY9jWoqSZW3rk3DJlAoTLlbk8Eif1MOMIOFzEjQI1Q=; b=deGolyASK6XlYEQxfIcPESaM60 HygQ7IcwgNAbsnmTINn9dK6SNNEUzQPeKS/1BhOhkSJsLtHzRBL4r3P15Lb6E0BtCZN7kDsPhmriu E+EN5cIXzdfEr/lRW1vZkpRVi4e+6ujGCBA48lKqD4+FT3IHCvtJox1NntIGbgSd9zFUU1NxkM+WN ThXwUSkW0zPXcykZyBa3mX+x+INcYASlzFY37TK9Pyu2+eQlBjOe70+ijmGw1wVNfqqUP/xHfLGKM ACXKrnQx7m8yu8N7OA9L1X+doVhS5Z74ZffCNsUukDqAhSopjyY4D0RDhY9VrO7Z30rkPXkW02Oyx Q8QxZnsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1puk5E-009S1o-0S; Fri, 05 May 2023 01:18:04 +0000 Received: from mail-bn7nam10on2061b.outbound.protection.outlook.com ([2a01:111:f400:7e8a::61b] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puk5B-009S13-1b for linux-nvme@lists.infradead.org; Fri, 05 May 2023 01:18:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZlKMBw+6u6A5w/SPAA9KuxGJWFBP4UorniSJSxvtxBQQkBRI4CDyiOX3z/lX1XIpu3diQnG6Ddm/+/xmguLuG1E6ZJ4cyfU6YSNwUng1mM6OJ9B/oj97EMAZSm092iYQPh5GNjAE0Rl5+78Yk53O1xbQqeheFXJIWrG3V2jkZesiYXIUgZpZRVsUBX4CusvzwbzSR536EUGakzZ34debl4zG3nwrzjAR3Lcsw7UDBmcH9fwVgSMJV4U6Jh8ypUduV95J+f/HSQTAvHiA7I57XXhEH7tvZp3XBw1Q+7C7TY1SEsLUgZnMBjsQTHpC/PZ81xkbu7EZQZ+qclr65kNYSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jMY9jWoqSZW3rk3DJlAoTLlbk8Eif1MOMIOFzEjQI1Q=; b=QZbCeHg4+8v9sFs1UyD8S2QX13VXB6wjiHwT5WoIg/RvZm7uAH3ef0oPX+/x3hjOaxoEBhvd5q9cfdO9SwbJfXLz5UmVCJqcJkSkTFgv5G2QG0epQZpSJLyNv+p25Ae/cvakK+h+/oHvHxCOITeThyYnQUazgFf0eaCjKRjt3PSeQhuqXGjNJJT5iUNvuuDqaZR27SKjicD0X/2OZNKth7SW7i3kgin5wE4xzcc3h+D3rxV3ES3Idy/2XIRSEQTlU578iRbtcTTzvEMw7g7cDp8S/AqBUMZr9zXbU9BLLmw8ziFZCsUueXu+6aRwBtYZhiAlCkBvSL6Vg5uej1AhxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jMY9jWoqSZW3rk3DJlAoTLlbk8Eif1MOMIOFzEjQI1Q=; b=tQ1dOoWE5s93bgMJBwL3iC/xQedGcigA6+j/VO8eU3obmhL0kRmaUyAaobDZcKEigwR+qoSnkecCNtvw7grDCrgO8MnU6RRwvVmrkPUoTeLln4l9CozpEjAgmE/PcVKZhP229oKo7Z2INkd3mAbPXYXk1ZO9uuw8618maQoXdCC4q9gp4AzoXJLHNqRcJoFLHDtD9jyyOTUJeYPxYpTLr1svMtBA7kfVewe6Uv+rrk8heTC/mxEqp8s17YXqNOiq2MyWkUIVcmxtQIEAvRQmupiqGYw9FCHNnDWU2Vw74SNeh0n33SgJ9sUtFJEBtK8tN5zb3X8V90xUu1K4Bfay7Q== Received: from MW2PR12MB4667.namprd12.prod.outlook.com (2603:10b6:302:12::28) by CH2PR12MB4277.namprd12.prod.outlook.com (2603:10b6:610:ae::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Fri, 5 May 2023 01:17:56 +0000 Received: from MW2PR12MB4667.namprd12.prod.outlook.com ([fe80::6922:cae7:b3cc:4c2a]) by MW2PR12MB4667.namprd12.prod.outlook.com ([fe80::6922:cae7:b3cc:4c2a%6]) with mapi id 15.20.6363.022; Fri, 5 May 2023 01:17:55 +0000 From: Chaitanya Kulkarni To: Sagi Grimberg CC: Irvin Cote , "linux-nvme@lists.infradead.org" , Chaitanya Kulkarni , Keith Busch , Christoph Hellwig Subject: Re: [PATCH] nvme: Fix memory leak in nvme_init_ctrl error path Thread-Topic: [PATCH] nvme: Fix memory leak in nvme_init_ctrl error path Thread-Index: AQHZfdFXdlfIMKDBbEyVCJAfcvh7La9JlYWAgAAw3oCAARzRgA== Date: Fri, 5 May 2023 01:17:55 +0000 Message-ID: References: <20230503150925.863308-1-sagi@grimberg.me> <581f5ee4-7adf-fea7-54cb-11a56e3f082c@nvidia.com> <17ad8acb-bf02-f194-75a4-b1508c8f6cbc@grimberg.me> In-Reply-To: <17ad8acb-bf02-f194-75a4-b1508c8f6cbc@grimberg.me> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW2PR12MB4667:EE_|CH2PR12MB4277:EE_ x-ms-office365-filtering-correlation-id: 031c06ff-fd41-4421-bba3-08db4d068e57 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wmWew/G+y8MdZpj5g+D+of0EGLk+VYCRnLbqO3Tq0uWq1BSob90IdMgA7uwyQUZkbBWANSozAMAdGx89Qw3L+LtYmXaWaoVL2FjYOLVXw4rwxR7gPetvP01okT8A621o+SQ7x8JG3PqhQKKHbygPcbfbGU2vD/EPnzBE9Yf+mril9g/EZke/Az0246Y+9NsaLIc5x45b89OoPzT2288tYVLK3nggVmUqlNjLLzE6/SPNPUWDjO0GiKVk90ZP/vDEcVE1yoDI5LOOEkhjosS+kgX+/lGUbqajDjRnJcwrpLWujz8+LGfkzPbGC0v4RAaqglwKTjK7hky8VnE/jr+un5LaOvOC3p6PvldovM5oJ6ZghHavPlSSRgqYcGnCBm2hq+PuNTsvr6rsSV+dNi1nWnrpK/goFS/5UDB5e7Rm5Uy0265q55+MYDtBOiTbxGdRVbYrkD8vMPUU7bq2Pwe5Wf73gwoUkaDs9kNN2k2HNrsDU7shoilzPdrLR/N9ES2SWMajIhYyxu5wZLw8sc+HgMDctsYAk0oCNFR3NOSlQkIhCUmomV//pdYklUcrCQmXM2+webjeGUf3mWk3cSbiFTeiZQF51gv7y/amHcxyTr8GKQBPA2nrutvmMOadxCbw17rm1Q4CYHmUgbFeYwrTHM9I7BJ6uHQHvC1P247ET/Wnb3O+LJet5v/ymS9nY/qs8EaTTakSfFmkKuooIWrg7OEy1OL3grVdW9rhEcsPszTfwFUH6SMIeq1uBT8u9XNR x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR12MB4667.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(39860400002)(346002)(136003)(376002)(451199021)(31696002)(86362001)(36756003)(66556008)(71200400001)(316002)(54906003)(66476007)(64756008)(91956017)(76116006)(66446008)(966005)(478600001)(6486002)(66946007)(6916009)(4326008)(41300700001)(5660300002)(2906002)(8936002)(8676002)(38070700005)(38100700002)(186003)(122000001)(6512007)(53546011)(6506007)(2616005)(31686004)(533714005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QnpQK3ZpU3JWbURraVNrM2d5MGQvQVBkTmlvRVVtMkxHWjlhcmxjTEtVWEkx?= =?utf-8?B?cHdlTFZHQ3dpRzlMd2l2UmxicGlqQXhNT0tTNS8xSEJRWmkrSk9iMkZPVkF5?= =?utf-8?B?R0p0a1Y0Wk0rUHFZZEhGTER4SGJtdHUzM3cyYWh3dit2ZE9Nb0ZnOUt2OHhH?= =?utf-8?B?REdRMXcvWWlLUGFsT21rTFVoaCttdGZxVmx5MWVvTkRJOTVPdnZveHBKck9Y?= =?utf-8?B?QUpqSkwvaWRkUnd5RUhhbUxUUlloaTQ4SVdQYzc2WGl4dU9tU3pCVEZhdTJ6?= =?utf-8?B?eXQwWGdTVTVyZlE2eHVqT0VXb0hUYmVXNEhad1V2ZlhqUllPRVluUG9OL2Vn?= =?utf-8?B?UUFkYktIeWhueS9NcEdkaHpMYVJNRG1zL00zdDVsbTVsMG15Wm9NV0FEYjd2?= =?utf-8?B?akdSRy9aZ0NwM2VmdHJzSEtlMUI2V0dBcGNzcTI3czVMNU1Qd0VxL0NVaHk2?= =?utf-8?B?eENEQmRmYWhQazFZRndid1dwS0Z3NGVDMVpyT21zeWxDUE9NZXpPMTI4SE9G?= =?utf-8?B?SFM1OU1RZzlKcDA4L1hFZWtMSzl4UFV3Z1lkem5WdndkOU9TREkwZjkweUJY?= =?utf-8?B?by8rZkRsbzhqK29QeUpXQkpkazFHT1hyS2JDRG5oTk9aaHkzNERGdktUNkhi?= =?utf-8?B?ejhDdjQvN3o3TWNoVks0YjFIcFpxa2pRSmN4VHVXVkxZOTJNVnc0SXcrWmZQ?= =?utf-8?B?eWE2V1BnNWtOeHZzc0RjWXp6Y2NhT1RBS1VueG4wakxNY2ZIUitOQTVocVZU?= =?utf-8?B?QTV1NjlzcmY0VUljQXpqNVgyMHlSaUYwb21RKzAxczBYUXNCWk8wU1pLdEZo?= =?utf-8?B?OXRScFlWOHpSZnl2aEt3SmF1aHJNUWgrNGVGK2U2L1NwSUp3eXhWUzdmRE5U?= =?utf-8?B?SnRHM1RZUnc1ZGxXQzV4R3ozbW84YWxaM0liMEszaVdpenNxRjNZV0ZPemJX?= =?utf-8?B?c1BuZDZmclhLVGdlSkhNWGZQckowZlQ1NytpUDRaVTFKNzhWcCt5czN3SjRq?= =?utf-8?B?OE00R3haYnV5dDlpYVVUcDd6NVJHeWx3VFBaV0ZrZkJFVjk5RTZJOVZMNkRJ?= =?utf-8?B?NFFpVDRKeWIrOGJhNGxVa0VpSFFSMU13R1c1ZHIvMWh6RFcvRXhmVk5NWlZC?= =?utf-8?B?Z1ppQzNmRXc3WXYyaHNIRmd2Mi9pMzJVanJvSkM0cVlwa2M0UWxyMzlIeXJa?= =?utf-8?B?bkp6TXFoRklpdURRa0NwSkMraXlOaE9NMy9ZSFZMNUVEenVnckc2bFF1dkRH?= =?utf-8?B?enp0eFNMU25QUUxEZXc3MFRWUHFJeVhMZVd5ODlmUFZTanlHcEpYRkNUWXdj?= =?utf-8?B?eEZmajZyeGV6aEtreFBnUlVKRzdDSm5EV1E4WDJDYWdCRURHMzUraXNtOXc1?= =?utf-8?B?aUNubUtuRXQ0YWwxV3B6c0tLOThEYUF6TlRER2NubkpRdG9DQTZMK1d1aTRE?= =?utf-8?B?Z3hUTHp2eTVLY1FuZWJydVAxOWYzUDFYS3YvYTNVUW5GekxTdC84U3p6WW9M?= =?utf-8?B?c2ZvQ0hNaW9SbW5WaUJUQ09INGZvSDRmQlVwUi9vcG9tWUxONGZmS1VLcXZj?= =?utf-8?B?b3lNNys5dXVXMDV4aG1pVGJTU1B2R0wxdXQ0c0drcWZ0VXBSdEFhN1JUR0Ey?= =?utf-8?B?a1o2Qlk4dWNRT0lLK3BHcXF1VE16KzZSSURuQ0VIakdMQ01LUXFpOWNUdHJx?= =?utf-8?B?eE4wTWgyTndIaUM3VUtGNkRvQW8wTDl2Sm4wWUJsbWNnUTNEYlRlQ25rOXA2?= =?utf-8?B?RTRwQ3hRUWR2c0ZtNzF6RlJyQlBMYmI5dUFQbFl3MUJNU2FOMmxtbXRmcE51?= =?utf-8?B?WmFrYXY4Znl5aTdaYzN1M1NXTkhGeVF2QmVnWDlsOU90ekZHcW5sRWJDMHlR?= =?utf-8?B?WCtVckEyemlUekFBRTBPNFlOdWluMVBBcmJMeDFvRWhoR3hqOWFUdWswUm02?= =?utf-8?B?dDg5L21CYkFDRVlpbG51SDhyT1VCOE0vc2xUZkZvejE4bjUyTG1MOXRYQ2No?= =?utf-8?B?Zkp3YnJzcnB1cHRnWVR0bmowSlJlUVZ4aEZNVkFGQVVWaGY0TlZiUTlxcVVj?= =?utf-8?B?VEFlVzRQRTNITVpwVk9IcmJ6WGtySHhSZmJwVnFiVkFhaUluRUJvaHJyOG9C?= =?utf-8?B?UUsxdDIyMVlodUhJU3NQVVI4SFQ3N0xMMHp1VmpKN0QxdzZkR29SanlZeDNa?= =?utf-8?Q?40/VEXFr05cZ7/Zeb0K7bNcZ3GkTwV3K95mGTHHj5Sau?= Content-Type: text/plain; charset="utf-8" Content-ID: <89946969E43B9B4FBB46A330CF0DB944@namprd12.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB4667.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 031c06ff-fd41-4421-bba3-08db4d068e57 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2023 01:17:55.6147 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ItXuZeTiWPmL5A28SUWUKdhTpWRx2NGXMmP2Vyes0GX8RGRghGOnRgPSPmFfVQqnOj0xEG18DkjL831xGbTUow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4277 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230504_181801_558869_3F8F24A1 X-CRM114-Status: GOOD ( 12.77 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org T24gNS80LzIzIDAxOjE4LCBTYWdpIEdyaW1iZXJnIHdyb3RlOg0KPg0KPj4gSSB0cnkgdG8gYXBw bHkgdGhpcyBwYXRjaCBvbiBsaW51eC1udm1lIG52bWUtNi40IGl0IGlzIG5vdCBhcHBseWluZywN Cj4+IHdoaWNoIHRyZWUgSSBzaG91bGQgdXNlIGZvciB0aGlzIHRvIHRlc3QgaXQgPw0KPj4NCj4+ IG52bWUgKG52bWUtNi40KSAjIGdpdCBhcHBseSBpbml0LWN0cmwtZml4LnBhdGNoDQo+PiBlcnJv cjogcGF0Y2ggZmFpbGVkOiBkcml2ZXJzL252bWUvaG9zdC9jb3JlLmM6NTEzNw0KPj4gZXJyb3I6 IGRyaXZlcnMvbnZtZS9ob3N0L2NvcmUuYzogcGF0Y2ggZG9lcyBub3QgYXBwbHkNCj4NCj4gSXQg aXMgb24gdG9wIG9mIHlvdXIgc2VyaWVzIGZvciB0aGUgb3RoZXIgbWVtbGVha3MNCg0KV2l0aCB0 aGlzIGFwcGxpZWQgb24gdGhlIHRvcCBvZiBbMV0gb24gbGludXgtbnZtZTpudm1lLTYuNCwNCmJs a3Rlc3RzIG52bWUvMDQ0IGFuZCBudm1lLzA0NSBhcmUgcGFzc2luZyB3aXRob3V0IHByb2R1Y2lu Zw0Ka21lbWxlYWsgWzJdLg0KDQp3aXRob3V0IHRoaXMgcGF0Y2ggSSdtIHN0aWxsIGdldHRpbmcg Oi0NCg0KIMKgIGJhY2t0cmFjZToNCiDCoMKgwqAgWzwwMDAwMDAwMDAzYjNhYjg5Pl0ga21hbGxv Y190cmFjZSsweDI1LzB4OTANCiDCoMKgwqAgWzwwMDAwMDAwMGVlNmE2MmJjPl0gZGV2aWNlX2Fk ZCsweDRjZi8weDg1MA0KIMKgwqDCoCBbPDAwMDAwMDAwNjk1OWQ2ZGI+XSBjZGV2X2RldmljZV9h ZGQrMHg0NC8weDkwDQogwqDCoMKgIFs8MDAwMDAwMDBhOTI1NDM5Mz5dIG52bWVfaW5pdF9jdHJs KzB4MzUyLzB4NDEwIFtudm1lX2NvcmVdDQogwqDCoMKgIFs8MDAwMDAwMDBhOGE4MDFhNz5dIDB4 ZmZmZmZmZmZjMDUxNThiMw0KIMKgwqDCoCBbPDAwMDAwMDAwYTU2NmJkOTI+XSAweGZmZmZmZmZm YzAzNzM0Y2INCiDCoMKgwqAgWzwwMDAwMDAwMDFiODhmYzFkPl0gdmZzX3dyaXRlKzB4YzUvMHgz YzANCiDCoMKgwqAgWzwwMDAwMDAwMDIxZDQ3MmRmPl0ga3N5c193cml0ZSsweDVmLzB4ZTANCiDC oMKgwqAgWzwwMDAwMDAwMDAxY2FkMThlPl0gZG9fc3lzY2FsbF82NCsweDNiLzB4OTANCiDCoMKg wqAgWzwwMDAwMDAwMDFmYzYyMTBmPl0gZW50cnlfU1lTQ0FMTF82NF9hZnRlcl9od2ZyYW1lKzB4 NzIvMHhkYw0KDQoNCkZlZWwgZnJlZSB0byBhZGQgOi0NClRlc3RlZC1ieTogQ2hhaXRhbnlhIEt1 bGthcm5pIDxrY2hAbnZpZGlhLmNvbT4NCg0KLWNrDQoNClsxXSBodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9waXBlcm1haWwvbGludXgtbnZtZS8yMDIzLUFwcmlsLzAzOTQ5Ni5odG1sDQoNCg0K