From: "Jiayuan Chen" <jiayuan.chen@linux.dev>
To: xuanqiang.luo@linux.dev, edumazet@google.com, kuniyu@google.com,
pabeni@redhat.com
Cc: kerneljasonxing@gmail.com, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, horms@kernel.org,
"Xuanqiang Luo" <luoxuanqiang@kylinos.cn>
Subject: Re: [RESEND PATCH net-next v7 2/3] inet: Avoid ehash lookup race in inet_ehash_insert()
Date: Tue, 14 Oct 2025 06:46:00 +0000 [thread overview]
Message-ID: <be003347ec43dba9fbe70d549da45610e1edd399@linux.dev> (raw)
In-Reply-To: <20251014022703.1387794-3-xuanqiang.luo@linux.dev>
October 14, 2025 at 10:27, xuanqiang.luo@linux.dev mailto:xuanqiang.luo@linux.dev wrote:
>
> From: Xuanqiang Luo <luoxuanqiang@kylinos.cn>
>
> Since ehash lookups are lockless, if one CPU performs a lookup while
> another concurrently deletes and inserts (removing reqsk and inserting sk),
> the lookup may fail to find the socket, an RST may be sent.
>
> The call trace map is drawn as follows:
> CPU 0 CPU 1
> ----- -----
> inet_ehash_insert()
> spin_lock()
> sk_nulls_del_node_init_rcu(osk)
> __inet_lookup_established()
> (lookup failed)
> __sk_nulls_add_node_rcu(sk, list)
> spin_unlock()
>
> As both deletion and insertion operate on the same ehash chain, this patch
> introduces a new sk_nulls_replace_node_init_rcu() helper functions to
> implement atomic replacement.
>
> Fixes: 5e0724d027f0 ("tcp/dccp: fix hashdance race for passive sessions")
> Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
> Signed-off-by: Xuanqiang Luo <luoxuanqiang@kylinos.cn>
Reviewed-by: Jiayuan Chen <jiayuan.chen@linux.dev>
next prev parent reply other threads:[~2025-10-14 6:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 2:27 [RESEND PATCH net-next v7 0/3] net: Avoid ehash lookup races xuanqiang.luo
2025-10-14 2:27 ` [RESEND PATCH net-next v7 1/3] rculist: Add hlist_nulls_replace_rcu() and hlist_nulls_replace_init_rcu() xuanqiang.luo
2025-10-14 13:36 ` Eric Dumazet
2025-10-14 2:27 ` [RESEND PATCH net-next v7 2/3] inet: Avoid ehash lookup race in inet_ehash_insert() xuanqiang.luo
2025-10-14 6:46 ` Jiayuan Chen [this message]
2025-10-14 13:59 ` Eric Dumazet
2025-10-14 2:27 ` [RESEND PATCH net-next v7 3/3] inet: Avoid ehash lookup race in inet_twsk_hashdance_schedule() xuanqiang.luo
2025-10-14 6:46 ` Jiayuan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be003347ec43dba9fbe70d549da45610e1edd399@linux.dev \
--to=jiayuan.chen@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=luoxuanqiang@kylinos.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xuanqiang.luo@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.