All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Peter Griffin <peter.griffin@linaro.org>,
	Alim Akhtar	 <alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	 linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: samsung: exynos4210-i9100: Enable RTS/CTS in Bluetooth node
Date: Tue, 01 Sep 2026 16:27:03 +0200	[thread overview]
Message-ID: <be168b7cd89c23855dc4e5b0df57940e902afa27.camel@crapouillou.net> (raw)
In-Reply-To: <20260829101509.138284-1-paul@crapouillou.net>

Hi,

Le samedi 29 août 2026 à 12:15 +0200, Paul Cercueil a écrit :
> The BCM4330 is connected using CTS/RTS too, so add the 'uart-has-
> rtscts'
> property.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> 
> Notes:
>     Changes:
>     
>     V1 was: "ARM: dts: samsung: exynos4210-i9100: Fix Bluetooth node"
>     
>     -v2: Drop max-speed property. It's only supposed to be used in
> some
>          cases, which don't apply here. As this was the "fix" for
> getting
>          Bluetooth to work on my device, which will be applied to the
>          driver instead, the Fixes: tag was removed.

I'll V3. I think I did not understand properly what 'max-speed' was
for, and indeed it does apply in this case - the Bluetooth chip's
maximum rate is 4 Mbps while the max baudrate of the SoC's UART is 3
Mbps.

Cheers,
-Paul

> 
>  arch/arm/boot/dts/samsung/exynos4210-i9100.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
> b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
> index 8a635bee59fa..95964be7daa8 100644
> --- a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
> +++ b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
> @@ -875,6 +875,7 @@ &serial_0 {
>  	status = "okay";
>  
>  	pinctrl-names = "default";
> +	uart-has-rtscts;
>  	pinctrl-0 = <&bt_en>, <&bt_res>, <&uart0_data>,
> <&uart0_fctl>;
>  
>  	bluetooth {


  reply	other threads:[~2026-09-01 14:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260829101532eucas1p29f4e04d4dfd169377793c276221059a6@eucas1p2.samsung.com>
2026-08-29 10:15 ` [PATCH v2] ARM: dts: samsung: exynos4210-i9100: Enable RTS/CTS in Bluetooth node Paul Cercueil
2026-09-01 14:27   ` Paul Cercueil [this message]
2026-09-02  8:36   ` Marek Szyprowski
2026-09-03 13:29     ` Paul Cercueil
2026-09-07  8:16       ` Marek Szyprowski
2026-09-09  5:57         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be168b7cd89c23855dc4e5b0df57940e902afa27.camel@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.