All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Griffin Kroah-Hartman <griffin@kroah.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: image: mdc800: change kmalloc() to kzalloc()
Date: Wed, 2 Sep 2026 11:35:46 +0200	[thread overview]
Message-ID: <be2bbb52-617e-4b9a-b8a1-ed5c2faf81e0@suse.com> (raw)
In-Reply-To: <2026090159-aspire-vanquish-da99@gregkh>



On 01.09.26 16:30, Greg Kroah-Hartman wrote:

> With old hardware like this, let's just stick to this "obviously
> correct" patch, and if someone with the hardware ever shows up, we can
> then test short message information like this.  As-is, this prevents a
> simple "leak kernel memory to userspace with a hand-crafted-device" bug.

You are not wrong, but if I put on my security person hat I cannot
ignore that we are still leaking information among users. That is
the obvious fixes would be memsets in open(), not in init()

	Regards
		Oliver


      reply	other threads:[~2026-09-02  9:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 10:04 [PATCH] usb: image: mdc800: change kmalloc() to kzalloc() Griffin Kroah-Hartman
2026-09-01 12:17 ` Oliver Neukum
2026-09-01 14:30   ` Greg Kroah-Hartman
2026-09-02  9:35     ` Oliver Neukum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be2bbb52-617e-4b9a-b8a1-ed5c2faf81e0@suse.com \
    --to=oneukum@suse.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=griffin@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.