Re: [PATCH 0/7] Pipe config debug dump diet

[Maarten Lankhorst <maarten.lankhorst@linux.intel.com>]

Op 17-11-16 om 13:30 schreef Tvrtko Ursulin:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> My Nth attempt to trim this by merging some short lines together and also by
> not dumping data not relevant for the platform at hand.
>
> On Skylake it saves six lines from a typical modesetting dump, from 26:
>
>  [i915]] [CRTC:29:pipe A][modeset] config ffff88014b886800 for pipe A
>  [i915]] cpu_transcoder: EDP
>  [i915]] pipe bpp: 18, dithering: 1
>  [i915]] fdi/pch: 0, lanes: 0, gmch_m: 0, gmch_n: 0, link_m: 0, link_n: 0, tu: 0
>  [i915]] dp: 1, lanes: 2, gmch_m: 4847916, gmch_n: 8388608, link_m: 269328, link_n: 524288, tu: 64
>  [i915]] dp: 1, lanes: 2, gmch_m2: 0, gmch_n2: 0, link_m2: 0, link_n2: 0, tu2: 0
>  [i915]] audio: 0, infoframes: 0
>  [i915]] requested mode:
>   [drm]] Modeline 0:"1920x1080" 60 138700 1920 1968 2000 2080 1080 1083 1088 1111 0x48 0xa
>  [i915]] adjusted mode:
>   [drm]] Modeline 0:"1920x1080" 60 138700 1920 1968 2000 2080 1080 1083 1088 1111 0x48 0xa
>  [i915]] crtc timings: 138700 1920 1968 2000 2080 1080 1083 1088 1111, type: 0x48 flags: 0xa
>  [i915]] port clock: 270000
>  [i915]] pipe src size: 1920x1080
>  [i915]] num_scalers: 2, scaler_users: 0x0, scaler_id: -1
>  [i915]] gmch pfit: control: 0x00000000, ratios: 0x00000000, lvds border: 0x00000000
>  [i915]] pch pfit: pos: 0x00000000, size: 0x00000000, disabled
>  [i915]] ips: 0
>  [i915]] double wide: 0
>  [i915]] dpll_hw_state: ctrl1: 0x3, cfgcr1: 0x0, cfgcr2: 0x0
>  [i915]] planes on this crtc
>  [i915]] [PLANE:23:plane 1A] enabled
>  [i915]]  FB:61, fb = 1920x1080 format = XR24 little-endian (0x34325258)
>  [i915]]  scaler:-1 src 0x0+1920+1080 dst 0x0+1920+1080
>  [i915]] [PLANE:25:plane 2A] disabled, scaler_id = -1
>  [i915]] [PLANE:27:cursor A] disabled, scaler_id = -1
>
> To 20 lines:
>
>  [i915]] [CRTC:31:pipe A][modeset]
>  [i915]] cpu_transcoder: EDP, pipe bpp: 18, dithering: 1
>  [i915]] dp m_n: lanes: 2; gmch_m: 4847916, gmch_n: 8388608, link_m: 269328, link_n: 524288, tu: 64
>  [i915]] dp m2_n2: lanes: 2; gmch_m: 0, gmch_n: 0, link_m: 0, link_n: 0, tu: 0
>  [i915]] audio: 0, infoframes: 0
>  [i915]] requested mode:
>   [drm]] Modeline 0:"1920x1080" 60 138700 1920 1968 2000 2080 1080 1083 1088 1111 0x48 0xa
>  [i915]] adjusted mode:
>   [drm]] Modeline 0:"1920x1080" 60 138700 1920 1968 2000 2080 1080 1083 1088 1111 0x48 0xa
>  [i915]] crtc timings: 138700 1920 1968 2000 2080 1080 1083 1088 1111, type: 0x48 flags: 0xa
>  [i915]] port clock: 270000, pipe src size: 1920x1080
>  [i915]] num_scalers: 2, scaler_users: 0x0, scaler_id: -1
>  [i915]] pch pfit: pos: 0x00000000, size: 0x00000000, disabled
>  [i915]] ips: 0, double wide: 0
>  [i915]] dpll_hw_state: ctrl1: 0x3, cfgcr1: 0x0, cfgcr2: 0x0
>  [i915]] planes on this crtc
>  [i915]] [PLANE:25:plane 1A] FB:63, fb = 1920x1080 format = XR24 little-endian (0x34325258)
>  [i915]]      scaler:-1 src 0x0+1920+1080 dst 0x0+1920+1080
>  [i915]] [PLANE:27:plane 2A] disabled, scaler_id = -1
>  [i915]] [PLANE:29:cursor A] disabled, scaler_id = -1
>
> On older platforms it would save even two more by skipping the scaler lines.
>
> I am uncertain of the DP m_n/m2_n2 business. Perhaps there is an opportunity to
> skip one of those on some platforms?
>
> Anyways.. every little helps! :) (for developers when hunting for interesting
> stuff in logs, disk space on the CI farm, etc,... )
>
> Tvrtko Ursulin (7):
>   drm/i915: Extract intel_link_m_n config printing into a helper
>   drm/i915: Dump FDI config only where applicable
>   drm/i915: Don't log pipe config kernel pointer and duplicated pipe
>     name
>   drm/i915: Compact a few pipe config debug lines
>   drm/i915: Only dump scaler config where supported
>   drm/i915: Only dump possible panel fitter config for the platform
>   drm/i915: Introduce enableddisabled helper
>
>  drivers/gpu/drm/i915/i915_debugfs.c        |   3 +-
>  drivers/gpu/drm/i915/i915_drv.h            |   5 ++
>  drivers/gpu/drm/i915/intel_display.c       | 130 +++++++++++++++--------------
>  drivers/gpu/drm/i915/intel_dsi_panel_vbt.c |   8 +-
>  drivers/gpu/drm/i915/intel_panel.c         |   2 +-
>  drivers/gpu/drm/i915/intel_pm.c            |   3 +-
>  6 files changed, 78 insertions(+), 73 deletions(-)
if (!pipe_config->has_drrs) m2/n2 are unused.

For whole series:

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx