From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25AA3CA9ED2 for ; Mon, 12 Oct 2026 21:03:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A17D46B008A; Mon, 12 Oct 2026 17:03:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C9956B009F; Mon, 12 Oct 2026 17:03:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B7FA6B00A0; Mon, 12 Oct 2026 17:03:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 27A7D6B008A for ; Mon, 12 Oct 2026 17:03:31 -0400 (EDT) Received: from smtpin04.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A57EF1A08FE for ; Mon, 12 Oct 2026 21:03:30 +0000 (UTC) X-FDA: 85315200180.04.EE142C3 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf24.hostedemail.com (Postfix) with ESMTP id D6672180008 for ; Mon, 12 Oct 2026 21:03:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=iwa4zYia; spf=pass (imf24.hostedemail.com: domain of vbabka@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=vbabka@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1791839008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8a9guZQ9UXhmWtlczU1xVFFTkDdI91mnDaX9njUfUDA=; b=IcRipFAAO2s/nKWdQiiKrfwozqoylXzsqIde2oLFiFsHQa5kHizSNmnpqx3Sc+2Jev2CN7 b4fvs1jwU5etezyLdLCBicoiKMJBL2e/4sTLJspd/I1NnCLfDtWoyrZgUiNou9eGIXpJHG WnqR6rcw9NSnn22OVN9KU9rUun6lhog= ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1791839009; b=glcHn9Y+HfNul4Vtrzt8IJuyh7o607SNBn9ASVtpgRekN57UGj0KD6/mdurZk2RPgrZ9eD 1nKfMy4fINsmPKmsJg1dLAilTixGeDt3HTMe0NM6YAl3aRsC5GfCN5Z2QDOnxu6i2zh5tb nSeT4njhexl3YsYH9Dl9yo9QD+a8MME= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=iwa4zYia; spf=pass (imf24.hostedemail.com: domain of vbabka@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=vbabka@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id C921744011; Mon, 12 Oct 2026 21:03:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4196C1F0089B; Mon, 12 Oct 2026 21:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791839007; bh=8a9guZQ9UXhmWtlczU1xVFFTkDdI91mnDaX9njUfUDA=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=iwa4zYia+5w/t/XiWlULLwwMV7DmTgBMmyVF8U6tpQKGm4BI9sgOrr6xXopzh4eee 2glTihabvgLw0LmaL9pHCbZ2f9EOiXAfjmBBSCwwZzkdLm93rCWYJQ6nU3gbQ7y7hM 7EawWNKw8PrMWCyeRu6YhDFDZMR9b+kMdZyqsFJ6BjzNSfWzit5Uba+OOzirdFFqUc xKmQl36xMYAscXx7Yi5/4hfkGy83vdEtplRm/nQUx08umZV/QTw8BsTh7uVc7ABTCf tJ7M5pa2ETketAJBIDNuK9CtVXQAeyb10KYuTo5TPcafJZ7gTdAGTcIrPCiWcHA1Gi wJmpD9ghvu9rQ== Message-ID: Date: Mon, 12 Oct 2026 23:03:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 2/8] ipc, msg: Account msg_msg allocations with GFP_KERNEL_ACCOUNT again Content-Language: en-US From: "Vlastimil Babka (SUSE)" To: Kees Cook Cc: Christian Brauner , Jan Kara , Andrew Morton , Roman Gushchin , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org, Pedro Falcato , Kuniyuki Iwashima , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261006092030.got.500-kees@kernel.org> <20261006092035.166776-2-kees@kernel.org> <38befa8c-3885-44eb-813c-0ee34cd55248@kernel.org> Autocrypt: addr=vbabka@kernel.org; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSNWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBrZXJuZWwub3JnPsLBsAQTAQoAWhYhBKlA1DSZLC6OmRA9UCJPp+fM gqZkBQJqFFy6GxSAAAAAAAQADm1hbnUyLDIuNSsxLjEyLDIsMgIbAwUJGtCBUAULCQgHAwUV CgkICwUWAgMBAAIeBQIXgAAKCRAiT6fnzIKmZJIUEADFx/tREzUImHrEwVHeSvDFmA7tJysI UVrlvrM09E7GIuzphzv7jYmo8n3ANpCczLEVr4G0syYQdTigaZgv3+FQDIIzhKih1IHhu1Ei XHlywNWKnQxxQEUNi5Mwx43wQz5XVw9F1A7gtKBKNtfogO511hAbrzagrYajyQacEJ/+sfhZ 9Da8ltHIXD8pcYaHUfQgEusCgmEd9+KrUwrTbckFKmYq5chuE6yJ4J0EmWknL096jIE6CnzF FRslQ3B1UKDjxVsm1ZHfir5NeWszLkTvGFsddFaWTgh8UycESG6VQzKXjjewXu2pG7YQYRpj QKm1W5X2TkwWkXRBZTmfmbhxIUMh3+zf5wQ463rSmDN/8v81tdqBtAW6rH/kzg1GvkaTHXn0 507yEHFzBksk2viAuIxxr7km8+/KARYLIdGtx30EG8cKzAUZOK6WqxtNCsXUJNrVE8CWrCaD icoNu7Fs1c5hmPHdSTnU48ce67449DdnO4neLSNhRiGlMHJgfJUmgrxu/hcYeOZ3haWmEQ2w uW1Mh01OHi8QZHCEyAbABrPs9GUgccc/4eYXX9hIgxfSkYzn8f+8NuIFPWl/0uTvjgqU29FQ SbzOLxHq9439Ox40G5mS5eZXRGxITYR+6TXvRGI6P/264jvflnr/pDGUttaikU+0W+1uxgKH cmYbEc7ATQRbGTU1AQgAn0H6UrFiWcovkh6EXVcl+SeqyO6JHOPm+e9Wu0Vw+VIUvXZVUVVQ La1PQDUi6j00ChlcR66g9/V0sPIcSutacPKfdKYOBvzd4rlhL8rfrdEsQw5ApZxrA8kYZVMh FmBRKAa6wos25moTlMKpCWzTH84+WO5+ziCTsTUZASAToz3RdunTD+vQcHj0GqNTPAHK63sf bAB2I0BslZkXkY1RLb/YhuA6E7JyEd2pilZOrIuBGl/5q2qSakgnAVFWFBR/DO27JuAksYnq +aH8vI0xGvwn75KqSk4UzAkDzWSmO4ZHuahKtQgZNsMYV+PGayRBX9b9zbldzopoLBdqHc4n jQARAQABwsF8BBgBCgAmAhsMFiEEqUDUNJksLo6ZED1QIk+n58yCpmQFAmfIHFQFCRYU6J8A CgkQIk+n58yCpmS2PA//bqN1LfcotmArgElsa+0EGZSQlYgK48pm8WAeTXTngudP9IJ4SuKY HR5RNjHcBeqN+Me0zxRqYzRb8nGanHEkDyf4Im8DQM8d6vbyU+FcPmG4skud4kgS1zMHnlVd SXfSIwKC/hKgdHG8aBV7545Lz9X6Iohea+94wneD0aw/hqF+QWewGZhWJriWAZtvEkzNjQOi 4U9F/trLten/x7bpphDSnDMKJtITbtzATT1Dq7o7VpIUK1nCTQALMuMjKCdi8OdU/+V+R3O4 0PXWvX8qrvqYapVbZ+9KqT74FsuB0Ya9uXwgBF2Q6cRuETZk5vqaqKxzqoQZCO8AOz/58j6O 2RHNy/mZEN+7tJ5Tsq42zVJ4jxsT8b9YplavCMsnBgDeRWhcbYhCyttoL7nYISyWg4kQYZ/P wIV3OuNv2f8iKYsxNsRuClOAF82+gvqOy1/1pprFjy8uo2pkoOrb63aOP3vO5VHnRKgra6dq NcaZ+c6J4H+nEJGi2SkHAUJz5oBzuThvPudLvPA/SK8sKoM01IRxSihev/S/5WLazXB1PGem OCbvzC1IjWJJraxiDJ5IygokapUa2RP7+WBR22skQ3SSl6G107QgWKSyTOGWEaRmV53vxQLV jXuCmzSSasTL60zq5yGrT4/DYQVSNEUiUbG4pYekxJujNeEDkUlky0Y= In-Reply-To: <38befa8c-3885-44eb-813c-0ee34cd55248@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D6672180008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ymimunkhyapp8bcr1kg4hd7ifne1pn5j X-HE-Tag: 1791839008-952551 X-HE-Meta: U2FsdGVkX1//nebzDFC1sdcMZ5xF+yTsw7SeZJTOw+Fu3RpaF3FYXC9SFWmPpRDb9u44X/7v5nolRSZf4VRQZQLDLfNu5pX/R3YR7X6BAvpjWe812jUTMcE6vr+Wbu0t6uMeNzfsFRCs3gLO/AFzhxVpH/qxXChRHcSRKAW97j78qnWKpd4cdM970zKe2YJ/TADKHwBolENYtEda3/p2aD8ZeRY1wWdQl8+R2WdKD+nj+avb20KeA8MNJcP1OFmFwLVBB7HyXLZb41ENk5x+vS7052X6pSjp9g33Kfv3O1Y8nVpnFoq5z9GikOI1RUNli2I8G3MlVsIuagZBJK1KP1+GIxtsKgjLERizkGSHubJnkqa7ukc2VWQB0pYOImQaKq/0ZwguoVkTP+Cdc9qWJVy3s6X/CvOHxyxWR9yHla3GLxl+DCI+rr4+wH0gHURwdORFXnYDvsB0fPdVoAgpQc3llE40PoYWEezxL+w+480hhws8NoONKxRr8hsAfwKl7SjLLRLb7YGdzS7Ic9B8EEDlqrK/vehagR/FdNQ6rDZ9M9yUIRtenM7WL+Fi+EtUFZvpVkTIbNpVsVhYwBSCyYESgXEyc3FFXaZX3CDqmldFksVuoHBApic3slj7K/77SxOBIrG7JD7DbYhtqIqNQ3tvxwUzLNEy4TGIMEA14WkSBOoKjAyTg3AWWJGxZANSL8b5wxQTsIlTYhM4vqFYjUhL/W+vM2zXQ4MP2lPzUQv9vvq+A9rfymb6Ux/WVsrkWAJX18pq742d9LaDRk3UK+Pm6B6cdBt2ZTkJhWwkMU2LaMUNtuBaRlgNkAps4ib/65/qeo7+OqpCjbfaNzv7gzy0Zj/sFtiBkCNZaEQUt5jnREfz0Vek8mrp7dXaJivzz/8/i8brlp3zKNIwV2lTkL1UUEKiUoJxRCMFlu1d1Nj1iwMLy1jVqOOxNUqVGEauDISbWUlUflnwRaeR9MU v9AQIwCe zLdbjspyRnHpT3cRJpK+AeJZaPs/o5C3NsYGey+CAO2fWrGFoLxWU0HW9gmCUFMY24epDm0uNI5Jv8E34YT9a0uXUALx9igpiZVc6aEGHmZi0wqKbBstKD7j6J3IxsDYjjK1SXxmNYBibwllVbjypU6Qse3C2ivFJ5BYRxy5hqPC9+c3vZ2nsVVDWoNtflIqOn3bEQNYHpp5BqBzH3TMEBLD4PVW6dMwuhySSjFsuAWxH2vZXstJkex8OelgqHrSmCg0p6qc20trpb/Wjs/r8uweRDmEfC/w5vmhZZwGwewcuhfXFC7Z1jEYWu4EYnuczXUQ6Jk3jE0dnDLI= Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/12/26 19:55, Vlastimil Babka (SUSE) wrote: > On 10/6/26 11:20, Kees Cook wrote: >> Since commit 734bbc1c97ea7 ("ipc, msg: Use dedicated slab buckets for >> alloc_msg()"), alloc_msg() allocates with GFP_KERNEL, and a msg_msg is >> accounted only through SLAB_ACCOUNT on its bucket caches. With >> CONFIG_SLAB_BUCKETS=n, kmem_buckets_create() creates no caches and >> kmem_buckets_alloc() is a GFP_KERNEL kmalloc() from the general caches, >> which do not account it; the same happens when kmem_buckets_create() >> fails. Either way, the allocation is not charged to the sender's memory >> cgroup. >> >> Allocate with GFP_KERNEL_ACCOUNT again, as before that commit. Memcg >> charges such an allocation in whichever cache serves it, so drop the >> SLAB_ACCOUNT, which no longer adds anything. >> >> Build tested ARCH=x86_64 defconfig with GCC 16.2.0, with >> CONFIG_SLAB_BUCKETS as y and n. >> >> Fixes: 734bbc1c97ea7 ("ipc, msg: Use dedicated slab buckets for alloc_msg()") >> Assisted-by: LLM >> Signed-off-by: Kees Cook > > Could we, for the purposes of a backportable fix, just have both > SLAB_ACCOUNT and GFP_KERNEL_ACCOUNT in place? That should do the right thing > regardless of CONFIG_SLAB_BUCKETS state, no? BTW we're thinking to add 1+2 (once this part is clarified) for 7.4 (with stable@ for patch 2). But for the rest we'll have to target 7.5 as it's only a week to the 7.4 merge window now.