From: "Garg, Shivank" <shivankg@amd.com>
To: "pfalcato@suse.de" <pfalcato@suse.de>,
"nphamcs@gmail.com" <nphamcs@gmail.com>,
"chrisl@kernel.org" <chrisl@kernel.org>,
"shikemeng@huaweicloud.com" <shikemeng@huaweicloud.com>,
"vbabka@kernel.org" <vbabka@kernel.org>,
"willy@infradead.org" <willy@infradead.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"youngjun.park@lge.com" <youngjun.park@lge.com>,
"jack@suse.cz" <jack@suse.cz>,
"minchan@kernel.org" <minchan@kernel.org>,
"baohua@kernel.org" <baohua@kernel.org>,
"liam@infradead.org" <liam@infradead.org>,
"kasong@tencent.com" <kasong@tencent.com>,
"jannh@google.com" <jannh@google.com>,
"ljs@kernel.org" <ljs@kernel.org>,
"baoquan.he@linux.dev" <baoquan.he@linux.dev>,
"senozhatsky@chromium.org" <senozhatsky@chromium.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH mm-new v2 2/5] mm/swapops: remove unused make_guard_swp_entry()
Date: Thu, 19 Nov 2026 05:23:52 +0000 [thread overview]
Message-ID: <be3c4adef1bbccac2e113f4be2dae96abd79c570.camel@amd.com> (raw)
In-Reply-To: <20261117-unused-sym-mm-v2-2-2f845e94dd50@amd.com>
On Tue, 2026-11-17 at 07:16 +0000, Shivank Garg wrote:
> make_guard_swp_entry() has no callers.
>
> Signed-off-by: Shivank Garg <shivankg@amd.com>
> ---
> include/linux/swapops.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/swapops.h b/include/linux/swapops.h
> index 603f9e3f909c..6f62fc3c8cfa 100644
> --- a/include/linux/swapops.h
> +++ b/include/linux/swapops.h
> @@ -306,11 +306,6 @@ static inline swp_entry_t make_poisoned_swp_entry(void)
> return make_pte_marker_entry(PTE_MARKER_POISONED);
> }
>
> -static inline swp_entry_t make_guard_swp_entry(void)
> -{
> - return make_pte_marker_entry(PTE_MARKER_GUARD);
> -}
> -
> struct page_vma_mapped_walk;
>
> #ifdef CONFIG_ARCH_HAS_PMD_SOFTLEAVES
Hi Andrew,
Please fold this additional info to commit as suggested by Dev:
make_guard_swp_entry() was added in 7c53dfbdb024 ("mm: add PTE_MARKER_GUARD
PTE marker"), has never had a caller, and none has been posted in 2 years.
If you prefer, I can send V3 with updated commit text.
Thanks,
Shivank
next prev parent reply other threads:[~2026-11-19 5:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 7:16 [PATCH mm-new v2 0/5] mm: remove unused functions Shivank Garg
2026-11-17 7:16 ` [PATCH mm-new v2 1/5] mm: remove unused helpers from pagemap.h Shivank Garg
2026-11-17 10:01 ` Barry Song
2026-11-18 16:11 ` Dev Jain
2026-11-19 4:31 ` Dev Jain
2026-11-19 5:21 ` Garg, Shivank
2026-11-19 5:35 ` + mm-remove-unused-helpers-from-pagemaph.patch added to mm-nonmm-unstable branch Andrew Morton
2026-11-17 7:16 ` [PATCH mm-new v2 2/5] mm/swapops: remove unused make_guard_swp_entry() Shivank Garg
2026-11-17 10:02 ` Barry Song
2026-11-19 4:32 ` Dev Jain
2026-11-19 5:23 ` Garg, Shivank [this message]
2026-11-19 5:35 ` + mm-swapops-remove-unused-make_guard_swp_entry.patch added to mm-nonmm-unstable branch Andrew Morton
2026-11-17 7:16 ` [PATCH mm-new v2 3/5] mm/swap: remove unused folio_to_swp_tb() Shivank Garg
2026-11-17 10:03 ` Barry Song
2026-11-18 16:13 ` Dev Jain
2026-11-18 16:23 ` Nhat Pham
2026-11-19 5:35 ` + mm-swap-remove-unused-folio_to_swp_tb.patch added to mm-nonmm-unstable branch Andrew Morton
2026-11-17 7:16 ` [PATCH mm-new v2 4/5] mm/zsmalloc: remove unused zpdesc_lock() Shivank Garg
2026-11-17 10:04 ` Barry Song
2026-11-18 2:17 ` Sergey Senozhatsky
2026-11-19 4:36 ` Dev Jain
2026-11-19 5:35 ` + mm-zsmalloc-remove-unused-zpdesc_lock.patch added to mm-nonmm-unstable branch Andrew Morton
2026-11-19 19:14 ` [PATCH mm-new v2 4/5] mm/zsmalloc: remove unused zpdesc_lock() Nhat Pham
2026-11-17 7:16 ` [PATCH mm-new v2 5/5] mm: nommu: remove unused heap_stack_gap Shivank Garg
2026-11-17 10:07 ` Barry Song
2026-11-19 4:38 ` Dev Jain
2026-11-19 5:35 ` + mm-nommu-remove-unused-heap_stack_gap.patch added to mm-nonmm-unstable branch Andrew Morton
2026-11-18 17:05 ` [PATCH mm-new v2 0/5] mm: remove unused functions Dev Jain
2026-11-18 17:14 ` Dev Jain
2026-11-18 18:55 ` Garg, Shivank
2026-11-19 3:55 ` Dev Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be3c4adef1bbccac2e113f4be2dae96abd79c570.camel@amd.com \
--to=shivankg@amd.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baoquan.he@linux.dev \
--cc=chrisl@kernel.org \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=kasong@tencent.com \
--cc=liam@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=pfalcato@suse.de \
--cc=senozhatsky@chromium.org \
--cc=shikemeng@huaweicloud.com \
--cc=vbabka@kernel.org \
--cc=willy@infradead.org \
--cc=youngjun.park@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.