From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DDCDE9904A for ; Fri, 10 Apr 2026 08:20:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wB75r-0001kd-DY; Fri, 10 Apr 2026 04:19:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wB75p-0001ju-Lu for qemu-devel@nongnu.org; Fri, 10 Apr 2026 04:19:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wB75o-0001Jk-0l for qemu-devel@nongnu.org; Fri, 10 Apr 2026 04:19:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775809195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1somlgRxhwBDjFzZka83KVIYD/+WD314nW9PJccUXwc=; b=O2R43dzXIEOTdf1njvQTA5kx6tKLTiC2IfVvYiEvWH90iidEvGg/mNQt724bYPPpq7LCWE v6j9600ARvmZHOkQKz2QZBlhP7lklU5DBtpfYnZdqIJ4394s8gmhK5Pu1VKcjp/FIaZKUq sGa4Bq22NfLKa9xhLTOD8rbVPD2nNbE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-5h1klwLWPem3lU9l0TRSjw-1; Fri, 10 Apr 2026 04:19:53 -0400 X-MC-Unique: 5h1klwLWPem3lU9l0TRSjw-1 X-Mimecast-MFC-AGG-ID: 5h1klwLWPem3lU9l0TRSjw_1775809193 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-488a75d674fso12162675e9.2 for ; Fri, 10 Apr 2026 01:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775809192; x=1776413992; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=1somlgRxhwBDjFzZka83KVIYD/+WD314nW9PJccUXwc=; b=XqOmmolE0uVAThkePI54r71M1cN6TfY07e1OGpxW3C3PxquE6Ez7KCqc5uh+Vyq6uK 4pjX1c15SExT4j9zCtoNbVhEcr5tsR81DgTtJl7JgS02xX2XIta36QFzF66Ozs8euaJu EnA34rhFpEcxSlLuTDXkgOYTHyTUIi+gTZ3hrur3rkkH3ox7kNeIRjs/BFL3hwVAaIcn ehd8dhW5wag5Mpqls7YR0R8GDGNavlPrSxd6arpGRoMjbqSywPg8m1s+uGjRhqqNkwMV MPJkscPgayNBhjt3G8SAiVM/59vvdL+FCcQnltrMcbBW1JNQS3PeK7ArOFMqvdyh7PVR xJtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775809192; x=1776413992; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1somlgRxhwBDjFzZka83KVIYD/+WD314nW9PJccUXwc=; b=dNxOwLzJWYCaiOIB7YBIiKeLV2T/kgpQZk+Ez7HxJUBbCPwDdSdXq8S9lE0zag3DP8 CTBHLkrY7n01FeMBoIst3L5byjY5n4ohcXRIlUxrr5z2C+7WmYxVtd/viGjknPek41v+ O0TyxLXnfCSyI3JriU8YHx8OuZ6yOcE2frJx0IkI+f6zat5xbIArAIBz3oN6ZaD8newr 18Co+G5lVQgpmmTDLd3VV8RukwZQJeys/1UGdU6OBoMIjZjJwXS6iMz3QONkcZYBZbSX SEKdB2jnj4d7fyREUfXOdskWNQZx3OAcdj5aSpvVpQlA7wjQinxZq5C9skutFYxhJ0xM ZHtQ== X-Forwarded-Encrypted: i=1; AJvYcCUB+59kYe3vOO64Cq69O4OgfHlc7byPNy9ZX7AlRS1hpqYmLEIsaj2ywnxbyiLAGviX7J8LhS2e2QGJ@nongnu.org X-Gm-Message-State: AOJu0YzLS7/xT7yJvOZnHqQyMyzMecJ5XZ5iSQVQRsj4uihnCvrnZKbV cVHuRbzevW3Y7ywk48SSH7YtBoCJWTrE9LQ0rjIlW6HdvxMFA/54aibqrYvLfTZTxxuU51/g63/ 28CPV4r38NqS8YXybli88IZheen6IFA/OHd8XBa2h8zOIHAzTjDpEHzb3 X-Gm-Gg: AeBDieuAQ9IciEeX6IgLfgMr7fR5SJfLkdxuekG4dvLgHxjG5ArqEJuBLEJ2Wz3DtwD +Dp/qnlo9t1h5Y5ZUp4UOVI+cuy2sSDw/no2Q2N3C7qM9/+ElQP/c1LiBxvDj777jd9quxVijAx oLd+hPm97eNbs5Qxe+Vd6FNjlHbHuhiT/bzX/Jz36ndqO93tErqZUOEmK7bhdeycMWO0FaTCFTm WWDAUu13kXuFw4jqef8ktbnDY4u2WhmbxvNRm/LEmQvScB4MxKnXaLX9VjzZ8DsnglNnUCmolUd 4W+m3bPhiseKauV6qGu+jeswoHgfl6Pi+056WqtpEhDLqN1Rp81TOKCyYiMJsaDGYNhWRblmlDj Sys+g+LTJLUW6Z3L1cGvngr1Y9UaR41dV+zaMFhMTUoxzHdaJnxv7xi5PrA== X-Received: by 2002:a05:600c:45c9:b0:488:9696:488a with SMTP id 5b1f17b1804b1-488d68a0d6fmr24008765e9.30.1775809192400; Fri, 10 Apr 2026 01:19:52 -0700 (PDT) X-Received: by 2002:a05:600c:45c9:b0:488:9696:488a with SMTP id 5b1f17b1804b1-488d68a0d6fmr24008345e9.30.1775809191854; Fri, 10 Apr 2026 01:19:51 -0700 (PDT) Received: from ?IPV6:2a01:e0a:165:d60:bbdd:3c5e:7d8b:3f72? ([2a01:e0a:165:d60:bbdd:3c5e:7d8b:3f72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d5888a97sm65093165e9.2.2026.04.10.01.19.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2026 01:19:51 -0700 (PDT) Message-ID: Date: Fri, 10 Apr 2026 10:19:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] hw/vfio/ap: Callbacks for migration of guests with pass-through access to AP devices To: Anthony Krowiak , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, mjrosato@linux.ibm.com, jjherne@linux.ibm.com, pasic@linux.ibm.com, farman@linux.ibm.com, borntraeger@linux.ibm.com, alex@shazbot.org, cohuck@redhat.com References: <20260409141352.997844-1-akrowiak@linux.ibm.com> <20260409141352.997844-3-akrowiak@linux.ibm.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20260409141352.997844-3-akrowiak@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/9/26 16:13, Anthony Krowiak wrote: > From: Anthony Krowiak > > Implements the callbacks used by the VFIO migration framework to migrate > guests with pass-through access to s390 crypto devices. > > Signed-off-by: Anthony Krowiak > --- > hw/vfio/ap.c | 43 +++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 39 insertions(+), 4 deletions(-) > > diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c > index fd68983702..49947b18c3 100644 > --- a/hw/vfio/ap.c > +++ b/hw/vfio/ap.c > @@ -32,6 +32,7 @@ > #include "hw/s390x/ap-bridge.h" > #include "system/address-spaces.h" > #include "qom/object.h" > +#include "vfio-migration-internal.h" > > #define TYPE_VFIO_AP_DEVICE "vfio-ap" > > @@ -47,6 +48,7 @@ static const VMStateDescription vmstate_ap_device = { > .name = "vfio-ap-device", > .version_id = 1, > .minimum_version_id = 1, > + .unmigratable = 0, unneeded. > .fields = (const VMStateField[]) { > VMSTATE_END_OF_LIST() > }, > @@ -66,17 +68,44 @@ static void __attribute__((constructor)) vfio_ap_global_init(void) > qemu_mutex_init(&cfg_chg_events_lock); > } > > +static int vfio_ap_save_config(VFIODevice *vdev, QEMUFile *f, Error **errp) > +{ > + VFIOAPDevice *vapdev = container_of(vdev, VFIOAPDevice, vdev); > + > + return vmstate_save_state(f, &vmstate_ap_device, vapdev, NULL, errp); > +} > + > +static int vfio_ap_load_config(VFIODevice *vdev, QEMUFile *f) > +{ > + VFIOAPDevice *vapdev = container_of(vdev, VFIOAPDevice, vdev); > + Error *err = NULL; > + int ret; > + > + ret = vmstate_load_state(f, &vmstate_ap_device, vapdev, 1, &err); > + if (ret) { > + error_report_err(err); > + } > + > + return ret; > +} > + > +static Object *vfio_ap_get_object(VFIODevice *vbasedev) > +{ > + VFIOAPDevice *vdev = container_of(vbasedev, VFIOAPDevice, vdev); > + > + return OBJECT(vdev); > +} > + > static void vfio_ap_compute_needs_reset(VFIODevice *vdev) > { > vdev->needs_reset = false; > } > > -/* > - * We don't need vfio_hot_reset_multi and vfio_eoi operations for > - * vfio-ap device now. > - */ > struct VFIODeviceOps vfio_ap_ops = { > .vfio_compute_needs_reset = vfio_ap_compute_needs_reset, > + .vfio_save_config = vfio_ap_save_config, > + .vfio_load_config = vfio_ap_load_config, > + .vfio_get_object = vfio_ap_get_object, > }; > > static void vfio_ap_req_notifier_handler(void *opaque) > @@ -251,6 +280,10 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp) > goto error; > } > > + if (!vfio_migration_realize(vbasedev, errp)) { > + goto error; > + } > + > if (!vfio_ap_register_irq_notifier(vapdev, VFIO_AP_REQ_IRQ_INDEX, &err)) { > /* > * Report this error, but do not make it a failing condition. > @@ -287,6 +320,8 @@ static void vfio_ap_unrealize(DeviceState *dev) > > static const Property vfio_ap_properties[] = { > DEFINE_PROP_STRING("sysfsdev", VFIOAPDevice, vdev.sysfsdev), > + DEFINE_PROP_ON_OFF_AUTO("enable-migration", VFIOAPDevice, > + vdev.enable_migration, ON_OFF_AUTO_ON), Why not ON_OFF_AUTO_AUTO ? This would enable migration only if kernel has migration support. If not, the VM would still start but migration would be blocked. thanks, C. > #ifdef CONFIG_IOMMUFD > DEFINE_PROP_LINK("iommufd", VFIOAPDevice, vdev.iommufd, > TYPE_IOMMUFD_BACKEND, IOMMUFDBackend *),