From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Uwe Kleine-König" <ukleinek@debian.org>
Cc: wuruilong <wuruilong@loongson.cn>, linux-sparse@vger.kernel.org
Subject: Re: [ Patch 001 ] feature: add support for loongarch
Date: Wed, 4 Sep 2024 12:32:40 +0300 [thread overview]
Message-ID: <be45dda2-e0be-4a13-aca7-e44ed6016fa7@stanley.mountain> (raw)
In-Reply-To: <b973fec7-7722-45b4-91df-c540a6e91c9d@debian.org>
On Wed, Sep 04, 2024 at 11:21:45AM +0200, Uwe Kleine-König wrote:
> Hello Dan,
>
> On 9/4/24 07:39, Dan Carpenter wrote:
> > On Fri, May 24, 2024 at 10:47:23AM +0800, wuruilong wrote:
> > > +const struct target target_loongarch64 = {
> > > + .mach = MACH_LOONGARCH64,
> > > + .bitness = ARCH_LP64,
> > > +
> > > + .big_endian = 0,
> >
> > No need to initialize things to zero.
>
> While your concern is technically correct, mentioning it explicitly for a
> human reader is still nice IMHO.
The only reason I mentioned any of this is because the unsigned_char thing is
probably a bug. Otherwise, I don't go around nit-picking these types of things.
I don't have strong feelings about this.
regards,
dan carpenter
prev parent reply other threads:[~2024-09-04 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 2:47 [ Patch 001 ] feature: add support for loongarch wuruilong
2024-09-03 21:15 ` Uwe Kleine-König
2024-09-04 5:39 ` Dan Carpenter
2024-09-04 9:21 ` Uwe Kleine-König
2024-09-04 9:32 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be45dda2-e0be-4a13-aca7-e44ed6016fa7@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=linux-sparse@vger.kernel.org \
--cc=ukleinek@debian.org \
--cc=wuruilong@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.