From: Saeed Mahameed <saeed@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, kuba@kernel.org
Cc: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, sassmann@redhat.com,
Aaron Brown <aaron.f.brown@intel.com>
Subject: Re: [net-next 14/15] ice: join format strings to same line as ice_debug
Date: Mon, 02 Nov 2020 15:07:32 -0800 [thread overview]
Message-ID: <be6ac7df8079164d8e9cb42e381799629a4479fb.camel@kernel.org> (raw)
In-Reply-To: <20201102222338.1442081-15-anthony.l.nguyen@intel.com>
On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> When printing messages with ice_debug, align the printed string to
> the
> origin line of the message in order to ease debugging and tracking
> messages back to their source.
>
Just out of curiosity, you are only re-aligning the code and not the
printed messages themselves. How would this help ? did you mean help
with tracking the sources when doing grep like operations on the source
code ?
next prev parent reply other threads:[~2020-11-02 23:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 22:23 [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2020-11-02 Tony Nguyen
2020-11-02 22:23 ` [net-next 01/15] ice: cleanup stack hog Tony Nguyen
2020-11-02 22:23 ` [net-next 02/15] ice: rename shared Flow Director functions Tony Nguyen
2020-11-02 22:23 ` [net-next 03/15] ice: initialize ACL table Tony Nguyen
2020-11-02 22:23 ` [net-next 04/15] ice: initialize ACL scenario Tony Nguyen
2020-11-02 22:23 ` [net-next 05/15] ice: create flow profile Tony Nguyen
2020-11-02 22:23 ` [net-next 06/15] ice: create ACL entry Tony Nguyen
2020-11-02 22:23 ` [net-next 07/15] ice: program " Tony Nguyen
2020-11-02 22:23 ` [net-next 08/15] ice: don't always return an error for Get PHY Abilities AQ command Tony Nguyen
2020-11-02 22:23 ` [net-next 09/15] ice: Enable Support for FW Override (E82X) Tony Nguyen
2020-11-02 22:23 ` [net-next 10/15] ice: Remove gate to OROM init Tony Nguyen
2020-11-02 22:23 ` [net-next 11/15] ice: Remove vlan_ena from vsi structure Tony Nguyen
2020-11-02 22:23 ` [net-next 12/15] ice: cleanup misleading comment Tony Nguyen
2020-11-02 22:23 ` [net-next 13/15] ice: silence static analysis warning Tony Nguyen
2020-11-02 22:23 ` [net-next 14/15] ice: join format strings to same line as ice_debug Tony Nguyen
2020-11-02 23:07 ` Saeed Mahameed [this message]
2020-11-03 0:25 ` Jacob Keller
2020-11-02 22:23 ` [net-next 15/15] ice: Add space to unknown speed Tony Nguyen
2020-11-02 22:58 ` [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2020-11-02 Saeed Mahameed
2020-11-03 22:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6ac7df8079164d8e9cb42e381799629a4479fb.camel@kernel.org \
--to=saeed@kernel.org \
--cc=aaron.f.brown@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.